From: hch@lst.de (Christoph Hellwig) Date: Tue, 12 Mar 2019 15:33:45 +0100 Subject: [PATCH v4 3/3] nvmet-file: clamp-down file namespace lba_shift In-Reply-To: <20190311220227.23656-4-sagi@grimberg.me> References: <20190311220227.23656-1-sagi@grimberg.me> <20190311220227.23656-4-sagi@grimberg.me> Message-ID: <20190312143345.GB1149@lst.de> On Mon, Mar 11, 2019@03:02:27PM -0700, Sagi Grimberg wrote: > When the backing file is a tempfile for example, the inode i_blkbits > can be 1M in size which causes problems for hosts to support as the > disk block size. > > Signed-off-by: Sagi Grimberg > --- > drivers/nvme/target/io-cmd-file.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c > index 517522305e5c..d52fe965a5d5 100644 > --- a/drivers/nvme/target/io-cmd-file.c > +++ b/drivers/nvme/target/io-cmd-file.c > @@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) > goto err; > > ns->size = stat.size; > - ns->blksize_shift = file_inode(ns->file)->i_blkbits; > + /* > + * inode i_blkbits can be greater than the universally accepted upper > + * bound so make sure we export we export a sane namespace lba_shift. > + */ > + ns->blksize_shift = min_t(u8, > + file_inode(ns->file)->i_blkbits, PAGE_SHIFT); I still wonder why we clamp this down to PAGE SIZE rather than 4k. Everything larger than 4k has a huge chance of not working with most remote hosts, even if our target system has a larger page size.