From: Stephen Hemminger Subject: [RFC] net/vdev_netvsc: check for required related drivers Date: Wed, 13 Mar 2019 08:18:58 -0700 Message-ID: <20190313151858.2175-1-stephen@networkplumber.org> Cc: Stephen Hemminger To: dev@dpdk.org, vpp-dev@lists.fd.io Return-path: Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by dpdk.org (Postfix) with ESMTP id 92966239 for ; Wed, 13 Mar 2019 16:19:03 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id u9so1746853pgo.7 for ; Wed, 13 Mar 2019 08:19:03 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The vdev_netvsc virtual driver that is used to do initialization on Hyper-V/Azure won't work without failsafe and tap device. If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there. Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier. Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build. Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index 801f54c96e01..9c262358b5ee 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -812,6 +812,20 @@ vdev_netvsc_scan_callback(__rte_unused void *arg) struct rte_devargs *devargs; struct rte_bus *vbus = rte_bus_find_by_name("vdev"); + dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device, + "net_failsafe"); + if (!dev) { + DRV_LOG(ERR, "failsafe network device not present"); + return; + } + + dev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device, + "net_tap"); + if (!dev) { + DRV_LOG(ERR, "tap network device driver not present"); + return; + } + RTE_EAL_DEVARGS_FOREACH("vdev", devargs) if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME, VDEV_NETVSC_DRIVER_NAME_LEN)) -- 2.17.1