From: Greg Kroah-Hartman Subject: Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs Date: Wed, 13 Mar 2019 14:14:10 -0700 Message-ID: <20190313211410.GB32331@kroah.com> References: <20190228114343.36443-1-robertshearman@gmail.com> <20190228114343.36443-4-robertshearman@gmail.com> <20190313152044.GD10250@kroah.com> <20190313163610.qbuexiowfcqgqndu@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190313163610.qbuexiowfcqgqndu@ninjato> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Peter Rosin , Robert Shearman , Guenter Roeck , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Robert Shearman List-Id: linux-i2c@vger.kernel.org On Wed, Mar 13, 2019 at 05:36:10PM +0100, Wolfram Sang wrote: > Hi Greg, > > > > I was wondering if you think the below ABI addition looks sane to you? > > I am not the i2c maintainer :) > > Peter is the i2c-mux maintainer, so I trust him very much on the I2C > side of things. We just wondered if you'd notice a general flaw when > exposing such an interface to userspace. Ah, I see. No, looks fine to me, it's a single value, well documented, should be just fine. thanks, greg k-h