Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 603ECC43381 for ; Thu, 14 Mar 2019 18:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D03217F5 for ; Thu, 14 Mar 2019 18:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727081AbfCNSpO (ORCPT ); Thu, 14 Mar 2019 14:45:14 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:55777 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbfCNSpO (ORCPT ); Thu, 14 Mar 2019 14:45:14 -0400 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1h4VLs-0004G6-Mv; Thu, 14 Mar 2019 14:45:12 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x2EIaPuZ019546; Thu, 14 Mar 2019 14:36:25 -0400 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x2EIaPcW019544; Thu, 14 Mar 2019 14:36:25 -0400 Date: Thu, 14 Mar 2019 14:36:25 -0400 From: "John W. Linville" To: Vivien Didelot Cc: netdev@vger.kernel.org Subject: Re: [PATCH] ethtool: fec: add pretty dump Message-ID: <20190314183625.GB31709@tuxdriver.com> References: <20190214161536.19646-1-vivien.didelot@gmail.com> <20190214161536.19646-2-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214161536.19646-2-vivien.didelot@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 14, 2019 at 11:15:36AM -0500, Vivien Didelot wrote: > Add pretty dump for the port registers of the "fec" kernel driver. Only > offsets exposed by the driver are dumped by ethtool. > > Both register dump versions are supported, version 2 which corresponds > to the kernel compilation test: > > #if defined(CONFIG_M523x) || defined(CONFIG_M527x) > || defined(CONFIG_M528x) || defined(CONFIG_M520x) > || defined(CONFIG_M532x) || defined(CONFIG_ARM) > || defined(CONFIG_ARM64) || defined(CONFIG_COMPILE_TEST) > > and version 1 which corresponds to the opposite test. At the same time, > detail a few interesting registers of version 2. > > Kernels not patched for setting this version will cause ethtool to > dump the whole set of registers as it already does today. > > Signed-off-by: Vivien Didelot Queued for next release -- thanks! John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.