Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9576C43381 for ; Sat, 16 Mar 2019 02:06:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F244218AC for ; Sat, 16 Mar 2019 02:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="rERnxpOH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfCPCGc (ORCPT ); Fri, 15 Mar 2019 22:06:32 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55931 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbfCPCGc (ORCPT ); Fri, 15 Mar 2019 22:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xLFEFqJ4DHIF8Vxguk+3F7bZzobgNFn5SBJQpCyzMJI=; b=rERnxpOHQbpjGtjLpxAaCCtydb 1fmAfVqOwRqJkcz5/PD3wZQRxSDKfgHOMhQ2dHcjrEw7HKOpoDEpEfRg7rQINp6bWDID/JDEHuigQ I8GMUZ4aIL69DPw+Vso0MWfiTpHkWYNq1RnouPgWvAEsUc4LVKH2zg6TFDrql8Vjn5pE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h4yiR-0000wy-K5; Sat, 16 Mar 2019 03:06:27 +0100 Date: Sat, 16 Mar 2019 03:06:27 +0100 From: Andrew Lunn To: Petr Machata Cc: "netdev@vger.kernel.org" , Jiri Pirko , Ido Schimmel , "davem@davemloft.net" , Tariq Toukan , "jakub.kicinski@netronome.com" , "stephen@networkplumber.org" Subject: Re: [RFC PATCH net-next 0/3] RTNL: Add link-down reason reporting Message-ID: <20190316020627.GB29548@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > The party with visibility into details of this process is the driver. Hi Petr In the general case, i would disagree with this. It is the PHY layer which knows about these things. phylib and phylink. The MAC driver has no idea, it just sees that the carrier is off. There are however some drivers which do PHYs without using the Linux core code. But there are not so many of them. I would hope this code is designed for the general case, and can also be used by those that ignore the core code. Please could you explain how you see this being linked to phylib and phylink, without having to modify every MAC driver. Andrew