Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E767C43381 for ; Mon, 18 Mar 2019 00:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 490AB2086A for ; Mon, 18 Mar 2019 00:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="aKl6U9Aa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727596AbfCRADQ (ORCPT ); Sun, 17 Mar 2019 20:03:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56694 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbfCRADQ (ORCPT ); Sun, 17 Mar 2019 20:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WdlBmWRiJIUN8dO/ezZrJRkRzhZZ/WQttp/yFUlnIoo=; b=aKl6U9AaOUPVAtUP9JCou01/Ts hqPnFxQwYY2ir/ZiFrBAIGk2SrtWwLSXGmNzyUYCp+kW7KhtM/rjk9tmRQknCW5ihO9japAOA0RI4 YgFW6Y74C14WSIGLTTPwRiVfI9JPFaBpsddGZ02vnwkSKi1yNqotG4e99fTQcRegFRjQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h5fkG-0008U8-D9; Mon, 18 Mar 2019 01:03:12 +0100 Date: Mon, 18 Mar 2019 01:03:12 +0100 From: Andrew Lunn To: Roopa Prabhu Cc: Petr Machata , "netdev@vger.kernel.org" , Jiri Pirko , Ido Schimmel , "davem@davemloft.net" , Tariq Toukan , "jakub.kicinski@netronome.com" , "stephen@networkplumber.org" Subject: Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages Message-ID: <20190318000312.GB30224@lunn.ch> References: <3a247e91ebe81cdae4bae27ec1631c5015fb943f.1552672441.git.petrm@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Can't we use netdev_ops for this ?. That will allow any driver to just > support this readily. Hi Roopa I argued this is a PHY layer status information. We don't really want to have to modify every MAC driver to call into phylib/phylink. Yes, we can have a netdev_ops for those drivers which ignore the Linux PHY layer, but ideally we want to transparently call into the PHY layer to get this information, if the MAC is not doing odd things. Andrew