From: Maxime Ripard Subject: Re: [RFC PATCH] drm/sun4i: Implement gamma correction Date: Mon, 18 Mar 2019 13:20:03 +0100 Message-ID: <20190318122003.yyxxo2khyde3uvax@flea> References: <20190314025838.5867-1-anarsoul@gmail.com> <20190314154203.7fixwajcplie5l3j@flea> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0637445689==" Return-path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4331891FF for ; Mon, 18 Mar 2019 12:20:07 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vasily Khoruzhick Cc: David Airlie , Chen-Yu Tsai , dri-devel , arm-linux List-Id: dri-devel@lists.freedesktop.org --===============0637445689== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="unmgpp7gijcisay6" Content-Disposition: inline --unmgpp7gijcisay6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Mar 14, 2019 at 10:54:26AM -0700, Vasily Khoruzhick wrote: > On Thu, Mar 14, 2019 at 8:42 AM Maxime Ripard wrote: > > > > Hi Vasily, > > > > On Wed, Mar 13, 2019 at 07:58:38PM -0700, Vasily Khoruzhick wrote: > > > Add support for gamma corretion to sun4i TCON driver. Its LUT has 256 > > > entries and can be updated only when gamma correction is disabled. > > > > > > Signed-off-by: Vasily Khoruzhick > > > > It's not really clear to me what you expect a comment on? > > I'm not sure that I put gamma correction into right place - gamma lut > seems to be a property of CRTC, but registers are in TCON module. The TCON loosely maps to the CRTC, so that's ok. > Also I'm not sure if gamma correction is supported across all > Allwinner SoCs - if it doesn't, how do we handle this? I don't really know if that's supported on all of them, but the way to handle this would be to associate it with the compatible and add a quirk if that's relevant. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --unmgpp7gijcisay6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXI+M8wAKCRDj7w1vZxhR xT+wAQDe0QTMJvNOVnO9/VE/09yMrKTnvtisKdA1epzJ+4xzLwD/Tw5PEiQTSGAh zniXwV6vl8alV3vRbpnV30Ta5fNgLQE= =x5xf -----END PGP SIGNATURE----- --unmgpp7gijcisay6-- --===============0637445689== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0637445689==--