From: Imre Deak Subject: Re: [PATCH v7 2/4] drm/i915: Save the old CDCLK atomic state Date: Tue, 19 Mar 2019 21:16:36 +0200 Message-ID: <20190319191636.GA24229@ideak-desk.fi.intel.com> References: <20190319183618.22162-1-imre.deak@intel.com> <20190319183618.22162-3-imre.deak@intel.com> <20190319185125.GI3888@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8937289BA5 for ; Tue, 19 Mar 2019 19:16:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190319185125.GI3888@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMDg6NTE6MjVQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgTWFyIDE5LCAyMDE5IGF0IDA4OjM2OjE2UE0gKzAyMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IFRoZSBvbGQgc3RhdGUgd2lsbCBiZSBuZWVkZWQgYnkgYW4gdXBjb21p bmcgcGF0Y2ggdG8gZGV0ZXJtaW5lIGlmIHRoZQo+ID4gY29tbWl0IGluY3JlYXNlcyBvciBkZWNy ZWFzZXMgQ0RDTEssIHNvIG1vdmUgdGhlIG9sZCBzdGF0ZSB0byB0aGUgYXRvbWljCj4gPiBzdGF0 ZSAod2hpbGUga2VlcGluZyB0aGUgbmV3IG9uZSBpbiBkZXZfcHJpdikuIGNkY2xrLmxvZ2ljYWwg YW5kCj4gPiBjZGNsay5hY3R1YWwgaW4gdGhlIGF0b21pYyBzdGF0ZSBpc24ndCB1c2VkIGF0bSBh bnl3aGVyZSBhZnRlciB0aGUKPiA+IGF0b21pYyBjaGVjayBwaGFzZSwgc28gdGhpcyBzaG91bGQg YmUgc2FmZS4KPiA+IAo+ID4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j ZGNsay5jICAgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICA0ICsrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMSArCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nk Y2xrLmMKPiA+IGluZGV4IDdkY2NhODRmMzFkMS4uOTcwMDdkNzZmOWE3IDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gQEAgLTIxMDAsNiArMjEwMCwzMiBAQCBib29s IGludGVsX2NkY2xrX2NoYW5nZWQoY29uc3Qgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICphLAo+ ID4gIAkJYS0+dm9sdGFnZV9sZXZlbCAhPSBiLT52b2x0YWdlX2xldmVsOwo+ID4gIH0KPiA+ICAK PiA+ICsvKioKPiA+ICsgKiBpbnRlbF9jZGNsa19zd2FwX3N0YXRlIC0gbWFrZSBhdG9taWMgQ0RD TEsgY29uZmlndXJhdGlvbiBlZmZlY3RpdmUKPiA+ICsgKiBAc3RhdGU6IGF0b21pYyBzdGF0ZQo+ ID4gKyAqCj4gPiArICogVGhpcyBpcyB0aGUgQ0RDTEsgdmVyc2lvbiBvZiBkcm1fYXRvbWljX2hl bHBlcl9zd2FwX3N0YXRlKCkgc2luY2UgdGhlCj4gPiArICogaGVscGVyIGRvZXMgbm90IGhhbmRs ZSBkcml2ZXItc3BlY2lmaWMgZ2xvYmFsIHN0YXRlLgo+ID4gKyAqCj4gPiArICogU2ltaWxhcmx5 IHRvIHRoZSBhdG9taWMgaGVscGVycyB0aGlzIGZ1bmN0aW9uIGRvZXMgYSBjb21wbGV0ZSBzd2Fw LAo+ID4gKyAqIGkuZS4gaXQgYWxzbyBwdXRzIHRoZSBvbGQgc3RhdGUgaW50byBAc3RhdGUuIFRo aXMgaXMgdXNlZCBieSB0aGUgY29tbWl0Cj4gPiArICogY29kZSB0byBkZXRlcm1pbmUgaG93IENE Q0xLIGhhcyBjaGFuZ2VkIChmb3IgaW5zdGFuY2UgZGlkIGl0IGluY3JlYXNlIG9yCj4gPiArICog ZGVjcmVhc2UpLgo+ID4gKyAqLwo+ID4gK3ZvaWQgaW50ZWxfY2RjbGtfc3dhcF9zdGF0ZShzdHJ1 Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc3RhdGUtPmJhc2UuZGV2KTsKPiA+ICsJc3Ry dWN0IGludGVsX2NkY2xrX3N0YXRlIHRtcDsKPiA+ICsKPiA+ICsJdG1wID0gc3RhdGUtPmNkY2xr LmxvZ2ljYWw7Cj4gPiArCXN0YXRlLT5jZGNsay5sb2dpY2FsID0gZGV2X3ByaXYtPmNkY2xrLmxv Z2ljYWw7Cj4gPiArCWRldl9wcml2LT5jZGNsay5sb2dpY2FsID0gdG1wOwo+ID4gKwo+ID4gKwl0 bXAgPSBzdGF0ZS0+Y2RjbGsuYWN0dWFsOwo+ID4gKwlzdGF0ZS0+Y2RjbGsuYWN0dWFsID0gZGV2 X3ByaXYtPmNkY2xrLmFjdHVhbDsKPiA+ICsJZGV2X3ByaXYtPmNkY2xrLmFjdHVhbCA9IHRtcDsK PiAKPiBObyBsb3ZlIGZvciBzd2FwKCk/CgpEaWRuJ3QgcmVhbGl6ZSBJIGNhbiBhbHNvIHVzZSBp dCBmb3Igc3RydWN0cy4uIHdpbGwgZml4IHRoYXQuCgo+IAo+IFJldmlld2VkLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+ID4gK30KPiA+ICsK PiA+ICB2b2lkIGludGVsX2R1bXBfY2RjbGtfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NkY2xr X3N0YXRlICpjZGNsa19zdGF0ZSwKPiA+ICAJCQkgICAgY29uc3QgY2hhciAqY29udGV4dCkKPiA+ ICB7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBiNDE5OWNk NTMzNDkuLjljNGFkMTI0MzAyYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiBAQCAtMTM2NjMsMTAgKzEzNjYzLDEwIEBAIHN0YXRpYyBpbnQgaW50ZWxfYXRv bWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAkJICAgICAgIGludGVsX3N0 YXRlLT5taW5fdm9sdGFnZV9sZXZlbCwKPiA+ICAJCSAgICAgICBzaXplb2YoaW50ZWxfc3RhdGUt Pm1pbl92b2x0YWdlX2xldmVsKSk7Cj4gPiAgCQlkZXZfcHJpdi0+YWN0aXZlX2NydGNzID0gaW50 ZWxfc3RhdGUtPmFjdGl2ZV9jcnRjczsKPiA+IC0JCWRldl9wcml2LT5jZGNsay5sb2dpY2FsID0g aW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gPiAtCQlkZXZfcHJpdi0+Y2RjbGsuYWN0dWFs ID0gaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbDsKPiA+ICAJCWRldl9wcml2LT5jZGNsay5mb3Jj ZV9taW5fY2RjbGsgPQo+ID4gIAkJCWludGVsX3N0YXRlLT5jZGNsay5mb3JjZV9taW5fY2RjbGs7 Cj4gPiArCj4gPiArCQlpbnRlbF9jZGNsa19zd2FwX3N0YXRlKGludGVsX3N0YXRlKTsKPiA+ICAJ fQo+ID4gIAo+ID4gIAlkcm1fYXRvbWljX3N0YXRlX2dldChzdGF0ZSk7Cj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaAo+ID4gaW5kZXggMGI4NGU1NTdjMjY3Li44NWRkNmE5ZDFlNDIgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IEBAIC0xNjk4LDYgKzE2OTgsNyBAQCBi b29sIGludGVsX2NkY2xrX25lZWRzX21vZGVzZXQoY29uc3Qgc3RydWN0IGludGVsX2NkY2xrX3N0 YXRlICphLAo+ID4gIAkJCSAgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmIp Owo+ID4gIGJvb2wgaW50ZWxfY2RjbGtfY2hhbmdlZChjb25zdCBzdHJ1Y3QgaW50ZWxfY2RjbGtf c3RhdGUgKmEsCj4gPiAgCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAqYik7Cj4g PiArdm9pZCBpbnRlbF9jZGNsa19zd2FwX3N0YXRlKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUg KnN0YXRlKTsKPiA+ICB2b2lkIGludGVsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPiAgCQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAq Y2RjbGtfc3RhdGUpOwo+ID4gIHZvaWQgaW50ZWxfZHVtcF9jZGNsa19zdGF0ZShjb25zdCBzdHJ1 Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xrX3N0YXRlLAo+ID4gLS0gCj4gPiAyLjEzLjIKPiAK PiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZng=