Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4312CC43381 for ; Wed, 20 Mar 2019 15:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 114112184E for ; Wed, 20 Mar 2019 15:26:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="uXbVVqdI"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nm/Svfxb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbfCTP0g (ORCPT ); Wed, 20 Mar 2019 11:26:36 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57641 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbfCTP0g (ORCPT ); Wed, 20 Mar 2019 11:26:36 -0400 X-Greylist: delayed 449 seconds by postgrey-1.27 at vger.kernel.org; Wed, 20 Mar 2019 11:26:35 EDT Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9818C231C3; Wed, 20 Mar 2019 11:19:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 20 Mar 2019 11:19:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Bv4zMWXM0aUN7N1HwsjiyK04vnr /p6g0/ktb63jquYw=; b=uXbVVqdIa7mcuEOSGDDQ4CYBXNJSTljV7mUMuuGanGo aBou/qTfAFy/1/4BjLXr2/pBKk/rOmRbWuCWa9damPMTea97v7ACqopBUNnrcPZF kgoR4mMSaHnXpIj8eBIYY4APsVZ685dBQNN5MjAGlZwGQ66V5LXqmNmQXAYhtPE8 SMC8PUYODypA7Jsqx/EP6oGGHKf1D75zEDMaJ0x7VTUmZYcaOom2ZlNHK70ekGEU 7411CoBtUn/1CdoTYTYa0V7o+uydgLj5eyKLuesk+eKvQ9j8h7EStr+aocYYDaKt /9cSYT/4l8o1ALEAZ2Baee0J4miqG8kbrXfFF9VZ8Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Bv4zMW XM0aUN7N1HwsjiyK04vnr/p6g0/ktb63jquYw=; b=nm/Svfxbxk4ewY64phiII1 u//9tiyx40h2G19AKGh1ghFj02Q2nbMoPR/oyiuLXfs8feZ3EPbS8Hh2fC8GwRF/ YJChG5YLdvJlEUlAg2GqdHAvaK8BDYgaiZBcnzPZGMZ7WWa2LxWYNi0PvTFU58aa CkTB89U1dqpcKx2XNQUkx4bsxlabaqDXIJZQcQ8ImJ6Hwsm1B+ufYgrza/l8BUBy 5hZ97aii9lKBjooS1nUyhZ6c9Tg+i8JSTFT8db+QhAS9mIRkk44Vi817FJpVPSEL oxhkvnE6ZuSaLL2zUMcT03BVmEicMShVBNM5tNJS9kLViWEtlPikYaIVSzJrD69g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id D1AB71030F; Wed, 20 Mar 2019 11:19:04 -0400 (EDT) Date: Wed, 20 Mar 2019 16:19:03 +0100 From: Greg KH To: Alexander Shishkin Cc: stable@vger.kernel.org Subject: Re: [PATCH v4.19.y] stm class: Prevent division by zero Message-ID: <20190320151903.GB32063@kroah.com> References: <20190320080944.2272-1-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320080944.2272-1-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 20, 2019 at 10:09:44AM +0200, Alexander Shishkin wrote: > commit bf7cbaae0831252b416f375ca9b1027ecd4642dd upstream. > > Using STP_POLICY_ID_SET ioctl command with dummy_stm device, or any STM > device that supplies zero mmio channel size, will trigger a division by > zero bug in the kernel. > > Prevent this by disallowing channel widths other than 1 for such devices. > > Signed-off-by: Alexander Shishkin > Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices") > --- > drivers/hwtracing/stm/core.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Thanks for all of the backports, now queued up. greg k-h