From: Anthony PERARD Subject: Re: [PATCH] public/io/blkif.h: make the comments on "sectors" self-consistent Date: Thu, 21 Mar 2019 15:23:38 +0000 Message-ID: <20190321152338.GQ11621@perard.uk.xensource.com> References: <20190320125228.36440-1-paul.durrant@citrix.com> <20190321122211.GB10145@perard.uk.xensource.com> <59c47c75ca664fd6b38dbaf42fd7d935@AMSPEX02CL02.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h6zXr-00009o-Kn for xen-devel@lists.xenproject.org; Thu, 21 Mar 2019 15:23:51 +0000 Content-Disposition: inline In-Reply-To: <59c47c75ca664fd6b38dbaf42fd7d935@AMSPEX02CL02.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: "xen-devel@lists.xenproject.org" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMTI6MzA6NDRQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+ID4gT24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMTI6NTI6MjhQTSArMDAwMCwgUGF1bCBE dXJyYW50IHdyb3RlOgo+ID4gPiBDdXJyZW50bHkgdGhlIGNvbW1lbnQgYXQgbGluZSAjMjY3IGNs YWltcyB0aGF0IHRoZSB2YWx1ZSBzaG91bGQgYmUKPiA+ID4gZXhwcmVzc2VkIGluIG51bWJlciBs b2dpY2FsIHNlY3RvcnMsIHdoZXJlYXMgdGhlIGNvbW1lbnQgYXQgbGluZSAjNjEzCj4gPiA+IHN0 YXRlcyB0aGF0IHRoZSB2YWx1ZSBzaG91bGQgYmUgZXhwcmVzc2VkIHN0cmljdGx5IGluIHVuaXRz IG9mIDUxMiBieXRlcy4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxw YXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ID4gLS0tCj4gPiA+IENjOiBLb25yYWQgUnplc3p1 dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+Cj4gPiA+Cj4gPiA+IExvb2tpbmcgYXQg eGVuLWJsa2Zyb250IGluIExpbnV4LCBJJ20gYWxzbyBub3QgY29udmluY2VkIHRoYXQgaXQgd291 bGQKPiA+ID4gZnVuY3Rpb24gY29ycmVjdGx5IGlzIHNlY3Rvci1zaXplICE9IDUxMiBhbnl3YXkg c28gSSB3b25kZXIgd2hldGhlciB0aGlzCj4gPiA+IHBhdGNoIHNob3VsZCBnbyBmdXJ0aGVyIGFu ZCBkZWZpbmUgdGhhdCBzZWN0b3Itc2l6ZSBpcyBzdHJpY3RseSA1MTIuCj4gPiA+IC0tLQo+ID4g PiAgeGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggfCAzICstLQo+ID4gPiAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0t Z2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMv aW8vYmxraWYuaAo+ID4gPiBpbmRleCAxNWE3MWUzZmVhLi5kN2M5MDRkOWRjIDEwMDY0NAo+ID4g PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYuaAo+ID4gPiArKysgYi94ZW4vaW5j bHVkZS9wdWJsaWMvaW8vYmxraWYuaAo+ID4gPiBAQCAtMjY0LDggKzI2NCw3IEBACj4gPiA+ICAg KiBzZWN0b3JzCj4gPiA+ICAgKiAgICAgIFZhbHVlczogICAgICAgICA8dWludDY0X3Q+Cj4gPiA+ ICAgKgo+ID4gPiAtICogICAgICBUaGUgc2l6ZSBvZiB0aGUgYmFja2VuZCBkZXZpY2UsIGV4cHJl c3NlZCBpbiB1bml0cyBvZiBpdHMgbG9naWNhbAo+ID4gPiAtICogICAgICBzZWN0b3Igc2l6ZSAo InNlY3Rvci1zaXplIikuCj4gPiA+ICsgKiAgICAgIFRoZSBzaXplIG9mIHRoZSBiYWNrZW5kIGRl dmljZSwgZXhwcmVzc2VkIGluIHVuaXRzIG9mIDUxMiBieXRlcy4KPiA+ID4gICAqCj4gPiA+ICAg KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioKPiA+ID4gICAqICAgICAgICAgICAgICAgICAgICAgICAgICAg IEZyb250ZW5kIFhlbkJ1cyBOb2Rlcwo+ID4gCj4gPiBCdXQgT1ZNRidzIGZyb250ZW5kLCBtaW5p b3MnIGZyb250ZW5kLCBGcmVlQlNEJ3MgZnJvbnRlbmQgYWxsIGRvCj4gPiBzZWN0b3Itc2l6ZSAq IHNlY3RvcnMgdG8gZmlndXJlIG91dCB0aGUgc2l6ZSBvZiB0aGUgbWVkaWEuCj4gPiBCdXQgbG9v a3MgbGlrZSBmb3IgYXQgbGVhc3QgT1ZNRiwgSU8gcmVxdWVzdHMgYXJlIGhhbmRsZWQgd2l0aCBh IHNlY3RvcnMKPiA+IHNpemUgb2YgNTEyLgo+ID4gCj4gPiBJIHRoaW5rIEZyZWVCU0QncyBiYWNr ZW5kIGFsc28gc2V0ICJzZWN0b3JzIiBiYXNlZCBvbiAic2VjdG9yLXNpemUiLCBidXQKPiA+IG9u IHRoZSBvdGhlciBoYW5kLCAic2VjdG9yLXNpemUiIGlzIGFsd2F5cyBzZXQgdG8gNTEyLgo+ID4g SSB0aGluayBpdCB0aGUgc2FtZSBmb3IgdGhlIG9sZCBxZW11IChiZWZvcmUgUGF1bCdzIHJlZmFj dG9yaW5nKS4KPiA+IAo+ID4gSSB0aGluayBJIHdvdWxkIGJlIGZpbmUgd2l0aCB0aGUgcGF0Y2gg Z29pbmcgZnVydGhlciBhbmQgaGF2ZQo+ID4gInNlY3Rvci1zaXplIiBhbHdheXMgNTEyLCBhcyBz b21lIGltcGxlbWVudGF0aW9uIGFyZSBiYWNrZWQgd2l0aAo+ID4gdGhpcyBhc3N1bXB0aW9uIChM aW51eCwgd2hpY2ggSSBoYXZlbid0IGNoZWNrZWQpLgo+ID4gCj4gPiAoSSBkb24ndCB3YW50IHRv IGhhdmUgdG8gcGF0Y2ggT1ZNRiBiZWNhdXNlIHRoZSBwcm90b2NvbCBjaGFuZ2VkLikKPiAKPiBU aGUgcHJvYmxlbSB3ZSBmYWNlIGlzIGJhY2tlbmRzIHBvaW50aW5nIGF0IGRpc2tzIHRoYXQgZG9u J3QgZG8gNTEyIGJ5dGUgbG9naWNhbCBibG9jayBlbXVsYXRpb24uIFRoZXJlIGhhcyB0byBiZSBz b21lIGhvcGUgZm9yIGRlYWxpbmcgd2l0aCB0aGVtLiBJZiB3ZSBzYXkgdGhhdCB0aGUgY3VycmVu dCBzdGF0ZSBvZiBhZmZhaXJzIGlzIHRoYXQgZXZlcnl0aGluZyBpcyBicm9rZW4gKHdoaWNoIEkg dGhpbmsgaXQgaXMgYXMgZmFyIGFzIExpbnV4IGJsa2Zyb250L2Jsa2JhY2sgYXJlIGNvbmNlcm5l ZCkgc28gd2UgZW5mb3JjZSBzZWN0b3Itc2l6ZSA9PSA1MTIgaW4gdGhlIHByb3RvY29sIHRoZW4g dGhlIG9ubHkgaG9wZSBJIGNhbiBzZWUgaXMgZm9yIGZyb250ZW5kcyB0byBpbnRyb2R1Y2UgYSBm bGFnIHRvIHNheSAnbm8gZW11bGF0aW9uJyB0byBwcm9tcHQgdGhlIGZyb250ZW5kIHRvIHVzZSBw aHlzaWNhbC1zZWN0b3Itc2l6ZSBhcyBsb2dpY2FsIHNlY3Rvci1zaXplLi4uIG9yIHNvbWV0aGlu ZyBsaWtlIHRoYXQuCgpJIGNvdWxkbid0IGZpZ3VyZSBvdXQgaG93IExpbnV4IGludGVycHJldCB0 aGUgInNlY3RvcnMiIG5vZGUuCgpUaGUgb25seSBwcm9ibGVtIEkgc2VlIGlzIHRoZSBjb250cmFk aWN0aW9uIGJldHdlZW4gbGluZSAjMjY3IGFuZCAjNjEzCm9uIHRoZSB1bml0IG9mICJzZWN0b3Jz IiwgInNlY3Rvci1zaXplIi1ieXRlcyB2cyA1MTItYnl0ZXMuCgpPdGhlcndpc2UsIGBzZWN0b3Jf bnVtYmVyYCwgYGZpcnN0X3NlY3RgIGFuZCBgbGFzdF9zZWN0YCBpbgpibGtpZl9yZXF1ZXN0X3Qg YW5kIGJsa2lmX3JlcXVlc3Rfc2VnbWVudCBhcmUgZGVmaW5lZCBhcyA1MTItYnl0ZXMuCgpJIHRo aW5rIHRoaXMgaXMgaG93IHRoZSBjdXJyZW50cyBpbXBsZW1lbnRhdGlvbnMgYXJlIHdvcmtpbmc6 CiAgICBtZWRpYS9kaXNrIHNpemUgPSAic2VjdG9ycyIgKiAic2VjdG9yLXNpemUiCnRoZW4sICJz ZWN0b3JzIiBhbmQgInNlY3Rvci1zaXplIiBhcmUgbmV2ZXIgdXNlZCBhZ2Fpbi4KCgpJIGRvbid0 IGtub3cgaXMgdGhlcmUgaXMgYWN0YWxseSBhIHByb2JsZW0gd2l0aCBkaXNrcyBkb24ndCB1bmRl cnN0YW5kCjUxMiBieXRlcyBsb2dpY2FsIGJsb2NrLCBidXQgdGhlcmUgaXMgYSBjb21tZW50IGF0 dGFjaCB0bwpibGtpZl9yZXF1ZXN0X3Q6CiAgICBIb3dldmVyIHRoZXkgbXVzdCBiZSBwcm9wZXJs eSBhbGlnbmVkIHRvIHRoZSByZWFsIHNlY3RvciBzaXplIG9mIHRoZQogICAgcGh5c2ljYWwgZGlz aywgInBoeXNpY2FsLXNlY3Rvci1zaXplIgoKCkNoZWVycywKCi0tIApBbnRob255IFBFUkFSRAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==