Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA75FC43381 for ; Sun, 24 Mar 2019 10:14:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F1F4222A7 for ; Sun, 24 Mar 2019 10:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="UHeS2SA9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728742AbfCXKOw (ORCPT ); Sun, 24 Mar 2019 06:14:52 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50766 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbfCXKOv (ORCPT ); Sun, 24 Mar 2019 06:14:51 -0400 Received: by mail-wm1-f66.google.com with SMTP id z11so6081802wmi.0 for ; Sun, 24 Mar 2019 03:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6OtqAbsei/zfM08YHf0k45yAi91Ec8fd6UqOldZKcv4=; b=UHeS2SA9HQjWD7oB+/d6UP1eReidUasy2eggtCkaMHNtRM7L1+CK61EimYNOZyqv1m u6vHOeiflBzpLmda97DDsH5iAA9+H7HXSgoWmWBHjuqu6U4sbBImNAKj4dTPWI1vmXnp V7nhir/LCXmzh+xDyruvnUp1ZqeGKdW4gDzCD1U/Vi/ei2L1Y5RsGLTc7bTYZQYYN/3S a4uLmrRieMwt3grgz4b2vP4bDdub+90+YI57LOzSTzuHb3lzLtUk1//+jZKBoRpGdNtG ZybMUhYbrxOIjfBj7pv0GsAafByF4bSB8tJL57OFHj3GAGDktG77MfbM3vknN7xIRWXT 6IsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6OtqAbsei/zfM08YHf0k45yAi91Ec8fd6UqOldZKcv4=; b=Fj84oudRgLOkNRjXdXQyGMABUKJHCOGlBcHIc54kdFPQGYuB7p8ZoKkt5BTAZUMPt0 mGrPrcQWBYxWxWotJXOCzwayeUByV2ddQUzx7D8KMTCnkJ2p6vg5dKvrsjpgCRROgsmA RLaoFJV050ErH01sHFkeVcaahuXErPdAwYQsqCUDYWn0Bu4+81w8gxgEKVtPYqDg3rTu IG2KcKtzUvggWhoC2jVHNQyDQ8zUMcCK2yD59djv0K9fIOIjR2eQmfXv0VQQ7c0GQWBM Tb86xWaq+e+kAAKM2WXOUiyStiXen4HlSvFieRuClqSEntgdVHB1DIVqVMCx/C38GoTl +dJw== X-Gm-Message-State: APjAAAUITp1N838yXJgL/nO44iNEtKISG7LyTqxJkEGpQdaFqwBUyw8v 3DDbjgI4XCqDofgaTOKApY0pJT2MZVo= X-Google-Smtp-Source: APXvYqyTUfrZ+34YRBH/B+Nk6J97NsePyMn9UDDjzR9Q2aBgvLntevety2IAnX1bUxpQoANBUhv3pw== X-Received: by 2002:a1c:2543:: with SMTP id l64mr2320158wml.116.1553422489209; Sun, 24 Mar 2019 03:14:49 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id y63sm14313865wmb.31.2019.03.24.03.14.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 03:14:48 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v3 10/15] net: devlink: disallow port_attrs_set() to be called before register Date: Sun, 24 Mar 2019 11:14:33 +0100 Message-Id: <20190324101438.6376-11-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us> References: <20190324101438.6376-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Since the port attributes are static and cannot change during the port lifetime, WARN_ON if some driver calls it after registration. Also, no need to call notifications as it is noop anyway due to check of devlink_port->registered there. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 35ae9980ce86..f4dbd404688f 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5430,12 +5430,13 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, { struct devlink_port_attrs *attrs = &devlink_port->attrs; + if (WARN_ON(devlink_port->registered)) + return; attrs->set = true; attrs->flavour = flavour; attrs->port_number = port_number; attrs->split = split; attrs->split_subport_number = split_subport_number; - devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW); } EXPORT_SYMBOL_GPL(devlink_port_attrs_set); -- 2.17.2