Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25978C4360F for ; Sun, 24 Mar 2019 10:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E72DA222A7 for ; Sun, 24 Mar 2019 10:15:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="YYF1k3qv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728722AbfCXKOu (ORCPT ); Sun, 24 Mar 2019 06:14:50 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36613 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728686AbfCXKOs (ORCPT ); Sun, 24 Mar 2019 06:14:48 -0400 Received: by mail-wr1-f66.google.com with SMTP id y13so6887311wrd.3 for ; Sun, 24 Mar 2019 03:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QbXxYC4bPcq6HE6efEAFxcdZns4ygiB9zR5dVd6KLfI=; b=YYF1k3qvlKzBYg4VuoRIXiIOzAdVTq7z3LrURlr9XOc9hGRtJgQv0/fWuPhXbaFHbZ 0WRL/Bs4tsYZI3ML86VuECV0RGO/efg6rWEeKF6x9lvEa3sC/J92nIqURPTlRyLHS/hB L9XzMVQy7UfZemnczgvKjA507doc6UV2Bdfmj26v6aaV/I/ORnMk/fY980gUUWU4recd 6ilRm8vXCJv2PvhNgqI6eOb5j5zCuFfka/aCtM3cRKfdZbH+1dz1YnDKtZenWoHjb4yy xBCHhX6ffVO+qTgsffGWoNchhKfLMfv2tvCgZooykmEXWJF6M1pMvf2NcgNSFvM3jKvQ GU2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QbXxYC4bPcq6HE6efEAFxcdZns4ygiB9zR5dVd6KLfI=; b=MxjOl+gD4tULiqlNTbxpqshl6k+i23eqhxpLXuTg0zc+VpthJOEjO1FWhUrfLTA70q Sh0BE5dV8aakeiJ73yjCjorqLw1RCJrH4JYTNxTm6s3b8zRGdoYEHx2islZRQSQparCl VXBefM+bv+XFAXvn+OtdH0XJjEXe5j6IE75Dgw39fGp4T+IWvbWGbp1tAO4dp+muhRZX dKMC2ktyhqJyjJkftfFUHzooT/pycyhlW5toLM+AlMx8Gc6jg2S5WugHr1kSnvvt4lN+ SzIiVOVT6B2VwiGiG3t7ErOSwyUl1iHu15FTjwTO7PkObFEJrmU9+InjBHEnOkVrsknm 4lyg== X-Gm-Message-State: APjAAAXGqZvkPw6kzVbfZYceNaM4l2Q7W/tjZRbOXfUeUlBPdwWnQZtt 9Lgwb+ikYFuoltKtCk6gDoAk/PjOJgY= X-Google-Smtp-Source: APXvYqzZ4tXK4PrgWGS0ZcDItLAR6nWlfJ5M4LXF5Re8YDk8O378QZxUtN9QbGP6Z7C8iCSBYOlqAg== X-Received: by 2002:adf:9427:: with SMTP id 36mr12831682wrq.128.1553422486408; Sun, 24 Mar 2019 03:14:46 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id y3sm6157909wmi.27.2019.03.24.03.14.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 03:14:46 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v3 07/15] net: devlink: don't pass return value of __devlink_port_type_set() Date: Sun, 24 Mar 2019 11:14:30 +0100 Message-Id: <20190324101438.6376-8-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us> References: <20190324101438.6376-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko __devlink_port_type_set() returns void, it makes no sense to pass it on, so don't do that. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index b40fd1addf14..35ae9980ce86 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5384,8 +5384,7 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, void devlink_port_type_eth_set(struct devlink_port *devlink_port, struct net_device *netdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_ETH, netdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev); } EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); @@ -5398,8 +5397,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); void devlink_port_type_ib_set(struct devlink_port *devlink_port, struct ib_device *ibdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_IB, ibdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_IB, ibdev); } EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); @@ -5410,8 +5408,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); */ void devlink_port_type_clear(struct devlink_port *devlink_port) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_NOTSET, NULL); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_NOTSET, NULL); } EXPORT_SYMBOL_GPL(devlink_port_type_clear); -- 2.17.2