From: Guenter Roeck Subject: Re: [alsa-devel] [PATCH] ASoC: intel: Fix crash at suspend/resume after failed codec registration Date: Mon, 25 Mar 2019 09:29:59 -0700 Message-ID: <20190325162959.GA28275@roeck-us.net> References: <1553294388-25293-1-git-send-email-linux@roeck-us.net> <5451ba5b-1a5d-41b0-2b39-772c326de785@linux.intel.com> <20190325121232.GF7284@sirena.org.uk> <50fafc60-0ee4-ab33-8d24-dfc149215bee@roeck-us.net> <20190325150533.GI7284@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190325150533.GI7284@sirena.org.uk> Sender: stable-owner@vger.kernel.org To: Mark Brown Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Jie Yang , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Liam Girdwood , Jarkko Nikula , Curtis Malainey List-Id: alsa-devel@alsa-project.org On Mon, Mar 25, 2019 at 03:05:33PM +0000, Mark Brown wrote: > On Mon, Mar 25, 2019 at 07:21:00AM -0700, Guenter Roeck wrote: > > > It is actually a bit more complicated than that. The stored pointer (drv->soc_card) > > isn't released. The problem is that dev_get_drvdata(drv->soc_card->dev) is NULL, > > which causes the crash. I don't think there is a UAF involved - I built the > > test image with KASAN enabled and it did not barf at me. > > What is a "UAF"? > use-after-free. Sorry, I saw that term used so often recently that I somehow thought it was common and started using it myself. Guenter > > Overall the implementation does seem a bit suspicious to me. I don't really > > understand why the platform driver handles suspend/resume for the cards. > > But that may just be my lack of understanding. However, either case, I think the > > Haswell driver (sst-haswell-pcm.c) has a similar problem. I am also not sure if > > It's certainly a bit unusual, usually the platform driver would just > deal with suspending itself and the card driver would handle overall > card suspension together with the core.