Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B93C43381 for ; Tue, 26 Mar 2019 12:03:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8F092075C for ; Tue, 26 Mar 2019 12:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="XOXiab8u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731511AbfCZMDW (ORCPT ); Tue, 26 Mar 2019 08:03:22 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40386 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731483AbfCZMDR (ORCPT ); Tue, 26 Mar 2019 08:03:17 -0400 Received: by mail-wr1-f68.google.com with SMTP id t5so13953196wri.7 for ; Tue, 26 Mar 2019 05:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TD+Ok/bxAY2v4xJCh5srLIcTX6P5QrnsXSeHjvIwPdU=; b=XOXiab8ub4QJYn65ysy2n9SSKD1BjFTC5TFhrKu41tgyZbcbCO52/SUZRnc+i9+0dV loUoq4Hs6qwOfAYAa1wpTYX/KNSMqwNQw7Cd7jSpncudYeuSkg+PoIi6zjnpfvP4xvBX CKoeTeMCgC8Tla6KR6eh5BsJkN5JNGcQOMSkh+ccEQ9GMW7kOloyxf0ev6jgKgDUjQre XTL3X2YRM6MRiU++g8dGkhtdvHKYyctBbDfQurd/ZSd+/n+I3lxV7wuXpbKcRUq5htEI eVda2VoAxLu+3TMz5Xe4N2obtoB7xRXEi8xU/nv0UExljSmIQZm61OqRnkSDA91YUDKi bBug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TD+Ok/bxAY2v4xJCh5srLIcTX6P5QrnsXSeHjvIwPdU=; b=YkwjnWQo8O7gAkWWxDJp+403ubI+XQZjvnAtPLfTeH7Fost6bpWWIhmcEtMQIoaqHj sarcDVZF2ixWRvBBeQMUr84+DgYMGiqQ0z+v9Jhx5rDRB2rKESQ+xMxe4aXW9hDoDNxc aP4x/LyqdpUNc3BdBTOxolaBmmviF6rAcYVKEnwPEYtyzAC9FCYql3Go7LBCIyZvXZKW ft4NRsbb5QpTFQV86WvnMb7tNRO3egBqDO985Rg+qWEkuTJCz23EnGOt1EKrd2kFJ5Td u3gY8oGtjzpiqr8HTC88RfSwxyXhA16Lub56eLEeYe9m9fW2COge9ero9rkKYHob6xuN oeWw== X-Gm-Message-State: APjAAAViRBjm2w9a1fwVd64dB6ELQYZhFPhkyxb3G6AnpqBqvZ0C3BnK jkZSPYEdYOftWqVqgTonaQ0384sEB44= X-Google-Smtp-Source: APXvYqzwD0t+7s26V9yEcL85oaCNgZ8i23w553gzH5/VM/QVak96Xx673hXZQUvvTS9Oeb1t3+AjoQ== X-Received: by 2002:adf:dd0f:: with SMTP id a15mr19001952wrm.221.1553601795896; Tue, 26 Mar 2019 05:03:15 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id d17sm15262614wrw.88.2019.03.26.05.03.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 05:03:15 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: [patch net-next v2 07/12] bnxt: remove ndo_get_phys_port_name implementation Date: Tue, 26 Mar 2019 13:03:02 +0100 Message-Id: <20190326120307.2953-8-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190326120307.2953-1-jiri@resnulli.us> References: <20190326120307.2953-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Rely on the previously introduced fallback and let the core call devlink in order to get the physical port name. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index eca36cac594e..35e34e23ba33 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -10048,23 +10048,6 @@ static int bnxt_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh, return rc; } -static int bnxt_get_phys_port_name(struct net_device *dev, char *buf, - size_t len) -{ - struct bnxt *bp = netdev_priv(dev); - int rc; - - /* The PF and it's VF-reps only support the switchdev framework */ - if (!BNXT_PF(bp)) - return -EOPNOTSUPP; - - rc = snprintf(buf, len, "p%d", bp->pf.port_id); - - if (rc >= len) - return -EOPNOTSUPP; - return 0; -} - int bnxt_get_port_parent_id(struct net_device *dev, struct netdev_phys_item_id *ppid) { @@ -10122,7 +10105,6 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_bridge_getlink = bnxt_bridge_getlink, .ndo_bridge_setlink = bnxt_bridge_setlink, .ndo_get_port_parent_id = bnxt_get_port_parent_id, - .ndo_get_phys_port_name = bnxt_get_phys_port_name, .ndo_get_devlink_port = bnxt_get_devlink_port, }; -- 2.17.2