Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465C1C43381 for ; Wed, 27 Mar 2019 17:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18F152082F for ; Wed, 27 Mar 2019 17:57:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="rlwB+5U8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbfC0R5t (ORCPT ); Wed, 27 Mar 2019 13:57:49 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42083 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727469AbfC0R5t (ORCPT ); Wed, 27 Mar 2019 13:57:49 -0400 Received: by mail-qt1-f193.google.com with SMTP id p20so19901760qtc.9 for ; Wed, 27 Mar 2019 10:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=HQhsEMNeRaoFtrjlnd0HA2KadW7OqxICIM9Dm91vbj4=; b=rlwB+5U8sSTi3r91x2MmwBfsXzbbRo9ofWOHN0nMZa0hMupL4FLB0Uvjs57tnNdKKB KjCPbBvAo8l9Dqj6oZbeXB6wItRRMojYtY60vqCbUNP77oWy9Ajsa3tQ3pvPry8QNOG1 SFdHf8xaIAkO9s0RCGHQZdjvfrpoUe72wouQ/MQ00rDR/2I76nyDwfKB4DyEksxeSqFu BiPDbPQjeBW5GZ92M/8VEeOaHnZrBhkHMSCjb1YtmoBFXA8qn4PCm41PsoQ5Zay595PF UtZ0UEnwtarauIJMKhXHQ4PF7eTCVlHuXib0SxlfsBTPGA04fEexDi+LRa27Oug9GE9b kikA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=HQhsEMNeRaoFtrjlnd0HA2KadW7OqxICIM9Dm91vbj4=; b=aw/crZHDFXKYE6W7yD4tKYcKhcYcNTTiVobA6MUFmt4HQ4o0TY24tC/W7g0hJBaVUf WBWIF5k+zAOppAaM3jK0Xj1oagQbSp1ziZ9Tl17JJblKEXGYlBdevqY5VwXMXonmsqFO SFzCgwcmw0lgrofvESX7P4C4T2rYEdy55VWXyBPdpoG2RMoPOwUpIIK8J3XwOX9vdURC FCKRezhQYsNRB85xaNn3FzIuVfPzkexfGVhsY+9cWMPctem6JmmDanoBQ31eyyiwLAgm OhY/ef5FKMYgeZKlG5Qa8ZmcJve+rxN7gYOKOYBzI0BSh4Hc8kyRwgqvTnR6kdO/4AGZ j1kw== X-Gm-Message-State: APjAAAXK9eZF4JR7Dj8orQUVihpJB3hPuHNWq1rRCob31gWFvISwVora 1P90tgf0ti6eai5wlpqRk0rTdA== X-Google-Smtp-Source: APXvYqzhPVLHOvQ1qTEmcZR0PR3ZOYFh2jKnolhXbXkmZbWDUfUeuuyzqp4xbEwKuCwXPklELR4OqA== X-Received: by 2002:ac8:f6e:: with SMTP id l43mr32212663qtk.322.1553709468614; Wed, 27 Mar 2019 10:57:48 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c50sm3368326qtd.60.2019.03.27.10.57.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 10:57:48 -0700 (PDT) Date: Wed, 27 Mar 2019 10:57:45 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next v3 02/12] net: replace ndo_get_devlink with ndo_get_devlink_port Message-ID: <20190327105745.397deec9@cakuba.netronome.com> In-Reply-To: <20190327151958.2649-3-jiri@resnulli.us> References: <20190327151958.2649-1-jiri@resnulli.us> <20190327151958.2649-3-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 27 Mar 2019 16:19:48 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Follow-up patch is going to need a devlink port instance according to > a netdev. Devlink port instance should be always available when devlink > is used. So change the recently introduced ndo_get_devlink to > ndo_get_devlink_port. With that, adjust the wrapper for the only > user to get devlink pointer. > > Signed-off-by: Jiri Pirko > Reviewed-by: Michal Kubecek > Reviewed-by: Florian Fainelli Reviewed-by: Jakub Kicinski