From: Stephen Hemminger Subject: [PATCH 1/2] net/netvsc: fix lgtm static checker complaint Date: Wed, 27 Mar 2019 14:08:42 -0700 Message-ID: <20190327210843.13813-2-stephen@networkplumber.org> References: <20190327210843.13813-1-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger To: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Return-path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 41F4F11A4 for ; Wed, 27 Mar 2019 22:08:48 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id g12so3890801pll.11 for ; Wed, 27 Mar 2019 14:08:48 -0700 (PDT) In-Reply-To: <20190327210843.13813-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since previous test is for mtu < 1519 the next else if is always true. This causes the lgtm static tool to complain. Not a real issue, just cosmetic. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 6197118b01ee..8818d68cea5c 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -123,7 +123,7 @@ hn_update_packet_stats(struct hn_stats *stats, const struct rte_mbuf *m) stats->size_bins[0]++; else if (s < 1519) stats->size_bins[6]++; - else if (s >= 1519) + else stats->size_bins[7]++; } -- 2.17.1