From: Kevin Wolf Subject: Re: [PATCH v2 0/2] xen-block: fix sector size confusion Date: Mon, 1 Apr 2019 11:34:05 +0200 Message-ID: <20190401093405.GA4935@localhost.localdomain> References: <20190327173206.9065-1-paul.durrant@citrix.com> <3585a316-6349-b89e-99be-799b055594db@citrix.com> <20190328114012.GG1420@perard.uk.xensource.com> <28bfdf32-916f-fb55-e2ab-13871b5e0fdd@citrix.com> <20190328115619.GC4857@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hAtKY-0001xo-2H for xen-devel@lists.xenproject.org; Mon, 01 Apr 2019 09:34:14 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Stefano Stabellini , "qemu-block@nongnu.org" , Andrew Cooper , "qemu-devel@nongnu.org" , Max Reitz , Stefan Hajnoczi , Anthony Perard , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org QW0gMDEuMDQuMjAxOSB1bSAxMTowMSBoYXQgUGF1bCBEdXJyYW50IGdlc2NocmllYmVuOgo+ID4g LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEtldmluIFdvbGYgW21haWx0bzpr d29sZkByZWRoYXQuY29tXQo+ID4gU2VudDogMjggTWFyY2ggMjAxOSAxMTo1Ngo+ID4gVG86IEFu ZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+Cj4gPiBDYzogQW50aG9ueSBQ ZXJhcmQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+OyBQYXVsIER1cnJhbnQgPFBhdWwuRHVy cmFudEBjaXRyaXguY29tPjsgeGVuLQo+ID4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IHFl bXUtYmxvY2tAbm9uZ251Lm9yZzsgcWVtdS1kZXZlbEBub25nbnUub3JnOyBTdGVmYW5vIFN0YWJl bGxpbmkKPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgTWF4IFJlaXR6IDxtcmVpdHpAcmVk aGF0LmNvbT47IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVkaGF0LmNvbT4KPiA+IFN1Ympl Y3Q6IFJlOiBbWGVuLWRldmVsXSBbUEFUQ0ggdjIgMC8yXSB4ZW4tYmxvY2s6IGZpeCBzZWN0b3Ig c2l6ZSBjb25mdXNpb24KPiA+IAo+ID4gQW0gMjguMDMuMjAxOSB1bSAxMjo0NiBoYXQgQW5kcmV3 IENvb3BlciBnZXNjaHJpZWJlbjoKPiA+ID4gT24gMjgvMDMvMjAxOSAxMTo0MCwgQW50aG9ueSBQ RVJBUkQgd3JvdGU6Cj4gPiA+ID4gT24gV2VkLCBNYXIgMjcsIDIwMTkgYXQgMDg6MzI6MjhQTSAr MDAwMCwgUGF1bCBEdXJyYW50IHdyb3RlOgo+ID4gPiA+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0KPiA+ID4gPj4+IEZyb206IEFuZHJldyBDb29wZXIKPiA+ID4gPj4+IFNlbnQ6IDI3IE1h cmNoIDIwMTkgMTg6MjAKPiA+ID4gPj4+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBj aXRyaXguY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBxZW11LQo+ID4gYmxv Y2tAbm9uZ251Lm9yZzsKPiA+ID4gPj4+IHFlbXUtZGV2ZWxAbm9uZ251Lm9yZwo+ID4gPiA+Pj4g Q2M6IEtldmluIFdvbGYgPGt3b2xmQHJlZGhhdC5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBNYXggUmVpdHoKPiA+ID4gPj4+IDxtcmVpdHpAcmVkaGF0 LmNvbT47IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVkaGF0LmNvbT47IEFudGhvbnkgUGVy YXJkCj4gPiA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiA+ID4gPj4+IFN1YmplY3Q6IFJl OiBbWGVuLWRldmVsXSBbUEFUQ0ggdjIgMC8yXSB4ZW4tYmxvY2s6IGZpeCBzZWN0b3Igc2l6ZSBj b25mdXNpb24KPiA+ID4gPj4+Cj4gPiA+ID4+PiBPbiAyNy8wMy8yMDE5IDE3OjMyLCBQYXVsIER1 cnJhbnQgd3JvdGU6Cj4gPiA+ID4+Pj4gVGhlIFhlbiBibGtpZiBwcm90b2NvbCBpcyBjb25mdXNp bmcgYnV0IGRpc2N1c3Npb24gd2l0aCB0aGUgbWFpbnRhaW5lcgo+ID4gPiA+Pj4+IGhhcyBjbGFy aWZpZWQgdGhhdCBzZWN0b3IgYmFzZWQgcXVhbnRpdGllcyBpbiByZXF1ZXN0cyBhbmQgdGhlICdz ZWN0b3JzJwo+ID4gPiA+Pj4+IHZhbHVlIGFkdmVydGl6ZWQgaW4geGVuc3RvcmUgc2hvdWxkIGFs d2F5cyBiZSBpbiB0ZXJtcyBvZiA1MTItYnl0ZQo+ID4gPiA+Pj4+IHVuaXRzIGFuZCBub3QgdGhl IGFkdmVydGlzZWQgbG9naWNhbCAnc2VjdG9yLXNpemUnIHZhbHVlLgo+ID4gPiA+Pj4+Cj4gPiA+ ID4+Pj4gVGhpcyBzZXJpZXMgZml4ZXMgeGVuLWJsb2NrIHRvIGFkaGVyZSB0byB0aGUgc3BlYy4K PiA+ID4gPj4+IEkgdGhvdWdodCB3ZSBhZ3JlZWQgdGhhdCBoYXJkY29kaW5nIHRoaW5ncyB0byA1 MTIgYnl0ZXMgd2FzIHRoZSB3cm9uZwo+ID4gPiA+Pj4gdGhpbmcgdG8gZG8uCj4gPiA+ID4+IFRv IHNvbWUgZXh0ZW50IHdlIGRlY2lkZWQgaXQgd2FzIHRoZSAqb25seSogdGhpbmcgdG8gZG8uCj4g PiA+ID4+Cj4gPiA+ID4+PiBJIHdhcyBleHBlY3Rpbmcgc29tZXRoaW5nIGxpa2U6Cj4gPiA+ID4+ Pgo+ID4gPiA+Pj4gMSkgQ2xhcmlmeSB0aGUgc3BlYyB3aXRoIHRoZSBpbnRlbmRlZCBtZWFuaW5n LCAod2hpY2ggaXMgd2hhdCBzb21lCj4gPiA+ID4+PiBpbXBsZW1lbnRhdGlvbnMgYWN0dWFsbHkg dXNlIGFscmVhZHkpIGFuZCB3b250IGNyaXBwbGUgNGsgZGF0YXBhdGhzLgo+ID4gPiA+Pj4gMikg SW50cm9kdWNlIGEgY29tcGF0aWJpbGl0eSBrZXkgZm9yICJJIGRvbid0IHJlbHkgb24gc2VjdG9y LXNpemUgYmVpbmcKPiA+ID4gPj4+IDUxMiIsIHdoaWNoIGZpeGVkIGltcGxlbWVudGF0aW9ucyBz aG91bGQgYWR2ZXJ0aXNlLgo+ID4gPiA+Pj4gMykgU3BlY2lmeSB0aGF0IGJlY2F1c2Ugb2YgYnVn cyBpbiB0aGUgc3BlYyB3aGljaCBnb3Qgb3V0IGludG8gdGhlIHdpbGQsCj4gPiA+ID4+PiBkcml2 ZXJzIHdoaWNoIGRvbid0IGZpbmQgdGhlIGtleSBiZWluZyBhZHZlcnRpc2VkIGJ5IHRoZSBvdGhl ciBlbmQKPiA+ID4gPj4+IHNob3VsZCBlbXVsYXRlIHNlY3Rvci1zaXplPTUxMiBmb3IgY29tcGF0 aWJpbGl0eSB3aXRoIGJyb2tlbgo+ID4gPiA+Pj4gaW1wbGVtZW50YXRpb25zLgo+ID4gPiA+PiBZ ZXMsIHRoYXQncyBob3cgd2UgYXJlIGdvaW5nIHRvIGZpeCB0aGluZ3MuCj4gPiA+ID4+Cj4gPiA+ ID4+PiBXaGF0ZXZlciB0aGUgZXZlbnR1YWwgd2F5IG91dCwgdGhlIGZpcnN0IHRoaW5nIHdoaWNo IG5lZWRzIHRvIGhhcHBlbiBpcwo+ID4gPiA+Pj4gYW4gdXBkYXRlIHRvIHRoZSBzcGVjLCBiZWZv cmUgYWN0aW9ucyBhcmUgdGFrZW4gdG8gYWx0ZXIgZXhpc3RpbmcKPiA+ID4gPj4+IGltcGxlbWVu dGF0aW9ucy4KPiA+ID4gPj4gV2VsbCB0aGUgaW1wbGVtZW50YXRpb24gaXMgY3VycmVudGx5IHdy b25nIHcuci50LiB0aGUgc3BlYyBhbmQgdGhlc2UgcGF0Y2hlcyBmaXggdGhhdC4gQXMgbG9uZyBh cwo+ID4gc2VjdG9yLXNpemUgcmVtYWlucyBhdCA1MTIgdGhlbiBubyBleGlzdGluZyBmcm9udGVu ZCBzaG91bGQgYnJlYWssIHNvIEkgZ3Vlc3MgeW91IGNvdWxkIGFyZ3VlIHRoYXQKPiA+IHBhdGNo ICMyIHNob3VsZCBhbHNvIG1ha2Ugc3VyZSB0aGF0IHNlY3Rvci1zaXplIGlzIGFsc28gNTEyLi4u IGJ1dCB0aGF0IGlzIG5vdCB5ZXQgaW4gdGhlIHNwZWMuCj4gPiA+ID4+IEkgZ3Vlc3MgSSdtIG9r IHRvIGRlZmVyIHBhdGNoICMyIHVudGlsIGEgcmV2aXNlZCBzcGVjLiBpcyBhZ3JlZWQsIGJ1dCB0 aGUgc2hpcCBoYXMgYWxyZWFkeSBzYWlsZWQKPiA+IGFzIGZhciBhcyBwYXRjaCAjMSBnb2VzLgo+ ID4gPiA+Pgo+ID4gPiA+PiBBbnRob255LCB0aG91Z2h0cz8KPiA+ID4gPiBTbyBRRU1VIHVzZWQg dG8gYWx3YXlzIHNldCAic2VjdG9yLXNpemUiIHRvIDUxMiwgYW5kIHVzZWQgdGhhdCBmb3IKPiA+ ID4gPiByZXF1ZXN0LiBUaGUgbmV3IGltcGxlbWVudGF0aW9uIChub3QgcmVsZWFzZWQgeWV0KSBk b2Vzbid0IGRvIHRoYXQKPiA+ID4gPiBhbnltb3JlLCBhbmQgbWF5IHNldCAic2VjdG9yLXNpemUi IHRvIGEgZGlmZmVyZW50IHZhbHVlIGFuZCB1c2VkIHRoYXQKPiA+ID4gPiBmb3IgcmVxdWVzdHMu Cj4gPiA+ID4KPiA+ID4gPiBwYXRjaCAjMSBpcyBvbmUgd2F5IHRvIGZpeCB0aGUgcmVxdWVzdHMg KGFuZCBhdm9pZCByZWdyZXNzaW9uKSBhbmQKPiA+ID4gPiBtb3JlIGNsZWFybHkgc3BlbGwgb3V0 IHRoZSB3ZWlyZCB0aGluZyBhYm91dCB0aGUgc3BlYy4KPiA+ID4gPgo+ID4gPiA+IEkgYWxzbyB0 aGluayBwYXRjaCAjMiBpcyB0b28gc29vbiBhbmQgc2hvdWxkIHBvaW50IHRvIGEgY29tbWl0IGlu Cj4gPiA+ID4geGVuLmdpdCBpbnN0ZWFkIG9mIGEgdGhyZWFkIG9uIHhlbi1kZXZlbC4KPiA+ID4g Pgo+ID4gPiA+IEluIHRoZSBtZWFudGltZSwgd2Ugc2hvdWxkIHByb2JhYmx5IHNldCAic2VjdG9y LXNpemUiIHRvIDUxMiwgbGlrZSBRRU1VCj4gPiA+ID4gdXNlZCB0byBkbyBhbnl3YXksIHdpdGgg YSBjb21tZW50IGFib3V0IHRoZSBmYWN0IHRoYXQgZGlmZmVyZW50Cj4gPiA+ID4gaW1wbGVtZW50 YXRpb25zIHVzZXMgc2VjdG9yLXNpemUgZGlmZmVyZW50bHkgYW5kIGEgdmFsdWUgb2YgNTEyIHdv dWxkCj4gPiA+ID4gd29yayBmaW5lLgo+ID4gPgo+ID4gPiBIbW0gLSBJIGhhZG4ndCByZWFsaXNl ZCB0aGlzIGlzIGFuIHVucmVsZWFzZWQgaXNzdWUgaW4gcWVtdS4KPiA+ID4KPiA+ID4gU28sIFFl bXUgdXNlZCB0byB1bmNvbmRpdGlvbmFsbHkgc2V0IHNlY3Rvci1zaXplPTUxMiwgYW5kIHlvdXIg d29yayB0bwo+ID4gPiBxZGV2LWlmeSBldmVyeXRoaW5nIGludHJvZHVjZWQgYSBjaGFuZ2Ugd2hp Y2ggaGFzIGlkZW50aWZpZWQgYQo+ID4gPiBzcGVjL3Byb3RvY29sIGlzc3VlPwo+ID4gCj4gPiBU aGUgb2xkIGltcGxlbWVudGF0aW9uIGhhcyB0aGUgc2VjdG9yIHNpemUgaGFyZGNvZGVkOgo+ID4g Cj4gPiAgICAgI2RlZmluZSBCTE9DS19TSVpFICA1MTIKPiA+IAo+ID4gV2hlcmVhcyB0aGUgcWRl dmlmaWVkIHZlcnNpb24gdXNlcyBERUZJTkVfQkxPQ0tfUFJPUEVSVElFUygpLCB3aGljaAo+ID4g aW5jbHVkZXMgdXNlci12aXNpYmxlIG9wdGlvbnMgZm9yIGxvZ2ljYWwvcGh5c2ljYWxfYmxvY2tf c2l6ZS4KPiA+IAo+ID4gU28gYmVmb3JlLCB5b3UgY291bGRuJ3QgZXZlbiBkZWZpbmUgYSBkaWZm ZXJlbnQgc2VjdG9yIHNpemUgYW5kIHRoZQo+ID4gcXVlc3Rpb24gd2hldGhlciA1MTIgb3IgdGhl IHNlY3RvciBzaXplIHNob3VsZCBiZSB1c2VkIGRpZG4ndCBtYWtlIGEKPiA+IGRpZmZlcmVuY2Ug YW55d2F5Lgo+ID4gCj4gPiA+IElmIHNvLCB0aGVuIEkgdGhpbmsgaXQgaXMgZmluZSBmb3IgdGhp cyBzZXJpZXMgdG8gc3RhdGUgKG11Y2ggbW9yZQo+ID4gPiBjbGVhcmx5IHRoYW4gaXQgZG9lcykg dGhhdCBpdCBpcyByZXR1cm5pbmcgcWVtdSdzIGJlaGF2aW91ciB0byBtYXRjaCB0aGUKPiA+ID4g Y3VycmVudGx5IHJlbGVhc2VkIHZlcnNpb24sIGJlY2F1c2Ugd2UndmUgZGlzY292ZXJlZCBhbiBp c3N1ZSBpbiB0aGUKPiA+ID4gc3BlYy9wcm90b2NvbCwgYW5kIHRoYXQgd2Ugd2lsbCBzdWJzZXF1 ZW50bHkgd29yayBhZGRyZXNzIHRoZSBpc3N1ZSBpbgo+ID4gPiB0aGUgc3BlYyBhbmQgcHJvdmlk ZSBhIGZvcndhcmRzIHBhdGggd2hpY2ggZG9lc24ndCBpbnZvbHZlIG5haWxpbmcgb3VyCj4gPiA+ IGZlZXQgdG8gdGhlIGZsb29yLgo+ID4gCj4gPiBUaGUgY2xvc2VzdCB0aGluZyB0byByZXR1cm5p bmcgdG8gdGhlIG9sZCBiZWhhdmlvdXIgd291bGQgYmUgZXJyb3JpbmcKPiA+IG91dCBkdXJpbmcg ZGV2aWNlIGluaXRpYWxpc2F0aW9uIGlmIGxvZ2ljYWxfYmxvY2tfc2l6ZSAhPSA1MTIuCj4gCj4g T25lIHRoaW5nIEkndmUgbm90IGZpZ3VyZWQgb3V0Li4uIElmIEkgY3JlYXRlIGEgYmxvY2tkZXYg aW4gUUVNVSB0aGF0Cj4gaXMgcG9pbnRpbmcgYXQgYSByZWFsIGRldmljZSB3aXRoIGEgbG9naWNh bF9ibG9ja19zaXplIG9mIDRrLCB3aWxsIHRoZQo+IFFFTVUgYmxvY2sgbGF5ZXIgcGVyZm9ybSB0 aGUgbmVjZXNzYXJ5IHJlYWQtbW9kaWZ5LXdyaXRlIGN5Y2xlcyBmb3IKPiBhY2Nlc3NlcyA8IDRr PyBJT1cgd291bGQgaXQgYmUgc2FmZSB0byBhbHdheXMgYWR2ZXJ0aXNlIGEgc2l6ZSBvZiA1MTIK PiB0byBhIGZyb250ZW5kPwoKWWVzLCBmb3IgNTEyIGFjY2Vzc2VzIG9uIG5hdGl2ZSA0ayBkaXNr cyB3aXRoIE9fRElSRUNULCB0aGUgUUVNVSBibG9jawpsYXllciBwZXJmb3JtcyB0aGUgbmVjZXNz YXJ5IFJNVy4gT2YgY291cnNlLCBpdCBzdGlsbCBjb21lcyB3aXRoIGEKcGVyZm9ybWFuY2UgcGVu YWx0eSwgc28geW91IHdhbnQgdG8gYXZvaWQgc3VjaCBzZXR1cHMsIGJ1dCB0aGV5IGRvIHdvcmsu Cgo+IFRoZSBwcm9ibGVtIHdpdGggZXJyb3Jpbmcgb3V0IGR1cmluZyBkZXZpY2UgaW5pdCBpcyB0 aGF0IGl0IGRvZXMgbm90Cj4gZ2l2ZSB1cyBhIHdheSBvZiBmaXhpbmcgdGhpbmdzIGluIGZ1dHVy ZSwgYXMgdGhlIGZyb250ZW5kIGhhcyBub3QKPiBzdGFydGVkIGF0IHRoYXQgdGltZSBhbmQgdGh1 cyB3ZSdkIGhhdmUgbm8gaWRlYSB3aGV0aGVyIGl0IGNvdWxkIHVzZQo+IHdoYXRldmVyIHByb3Rv Y29sIGZpeCB3ZSBjb21lIHVwIHdpdGguIEkgdGhpbmsgdGhlIG9ubHkgdGhpbmcgdGhlCj4gYmFj a2VuZCBjb3VsZCBkbyBpcyByZWZ1c2UgdG8gY29ubmVjdCB0byBhbiBvbGQgZnJvbnRlbmQgaWYK PiBsb2dpY2FsX2Jsb2NrX3NpemUgIT0gNTEyLgoKSSB3YXMganVzdCB0aGlua2luZyBvZiBnZXR0 aW5nIGJhY2sgdG8gdGhlIG9sZCBzdGF0ZSwgd2l0aCBhIHF1aWNrIGZpeAooYnkgbWFraW5nIHRo ZSBwcm9ibGVtYXRpYyBuZXcgc2V0dGluZyBpbmFjY2Vzc2libGUpIGZvciB0aGUgYnVnIGluIDQu MAp0aGF0IGNvdWxkIHBvc3NpYmxlIGJlIG1lcmdlZCB0b2RheSBvciB0b21vcnJvdyBmb3IgcmMy LgoKV2hhdCB5b3UgbmVlZCB0byBkbyBmb3IgYWN0dWFsbHkgc3VwcG9ydGluZyA0ayBkaXNrcyBp biB0aGUgbG9uZyB0ZXJtCihRRU1VIDQuMSBvciBsYXRlcikgZGVwZW5kcyBvbiB3aGF0IHRoZSBk cml2ZXJzIGxvb2sgbGlrZSBjdXJyZW50bHkgYW5kCmlzIGEgc2VwYXJhdGUgZGlzY3Vzc2lvbi4K CktldmluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs