Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C9AAC43381 for ; Mon, 1 Apr 2019 13:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A0C8208E4 for ; Mon, 1 Apr 2019 13:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554126835; bh=4q6AxROz+u63FEhG1ItNeFzCUFIBKblEmHTARXIa4RM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TKxXJIKEdd3Y37WP4lliTiBZzphDdFdH7lN4gh7P92L+wMXBf90ifWyXv9gragYhM 3a7KYSf/z3Pt4bi1VsGbQfkDLdHa242kX4kClJCn8/d+6bWm1FSFUNHqimcXZKsr6B e71KZtZqRLS6P5Pm7Y3/aOtIcgUk2Yqe3hYkeXV8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727065AbfDANxy (ORCPT ); Mon, 1 Apr 2019 09:53:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:55778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbfDANxy (ORCPT ); Mon, 1 Apr 2019 09:53:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F7D020830; Mon, 1 Apr 2019 13:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554126833; bh=4q6AxROz+u63FEhG1ItNeFzCUFIBKblEmHTARXIa4RM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wDXXN5JVliO778ma0erpzkmnCLhQdzgBMZtabuRSckvBLEuQCT4YUaro6NbWD7EQS erguoDkWM8S/DieOegRULtRQ3QQXZLQ5WPuiYUZslA489XQjyYxXlFrUYgQUrJT+w/ XqK4hLumqtzZ+3aFgPEKuY9lEYGItjUNWtu1bfik= Date: Mon, 1 Apr 2019 15:53:49 +0200 From: Greg KH To: Heikki Krogerus Cc: anil.kumar.k@intel.com, brian.j.wood@intel.com, stable@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v4.19.x] usb: typec: class: Don't use port parent for getting mux handles Message-ID: <20190401135349.GB23581@kroah.com> References: <20190328114432.41636-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328114432.41636-1-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 28, 2019 at 02:44:32PM +0300, Heikki Krogerus wrote: > commit 23481121c81d984193edf1532f5e123637e50903 upstream. > > It is not possible to use the parent of the port device when > requesting mux handles as the parent may be a multiport USB > Type-C or PD controller. The muxes must be assigned to the > ports, not the controllers. > > This will also move the requesting of the muxes after the > port device is initialized. > > [ heikki: This patch fixes an issue where port->id was used uninitialized. ] > > Cc: # 4.19.x: cd7753d: drivers: base: Helpers for adding device connection descriptions > Cc: # 4.19.x: 140a4ec: platform: x86: intel_cht_int33fe: Register all connections at once > Cc: # 4.19.x: 78d2b54: platform: x86: intel_cht_int33fe: Add connection for the DP alt mode > Cc: # 4.19.x: 495965a: platform: x86: intel_cht_int33fe: Add connections for the USB Type-C port > Cc: # 4.19.x > Cc: # 4.19.x: 148b0aa: platform: x86: intel_cht_int33fe: Remove the old connections for the muxes > Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C Multiplexers") > Acked-by: Hans de Goede > Tested-by: Hans de Goede > Signed-off-by: Heikki Krogerus > --- > Hi, > > This is a request to backport commit 23481121c81d984193edf1532f5e123637e50903 > > It was not marked as a fix, but it does fix an issue where a > variable "port->id" was used in function typec_register_port() > without initializing it. > > The patch has additional prerequisites which are listed in > the sign-off area. Please note that there is also one patch > listed there after this one. Ok, all are now queued up. Please let me know if I missed anything. thanks, greg k-h