Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE541C4360F for ; Tue, 2 Apr 2019 13:56:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C57220882 for ; Tue, 2 Apr 2019 13:56:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="HwoGl5lX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732190AbfDBN4b (ORCPT ); Tue, 2 Apr 2019 09:56:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47382 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731186AbfDBN4b (ORCPT ); Tue, 2 Apr 2019 09:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a3+zvTYuvXGtZ/1HtfGCQcClMIi3WWGLLAtz4MThSwk=; b=HwoGl5lXCBZGBgbVdyJlfYCg+y 0ineYAUrNnDEcBYNuc6F1yf+vHxMzjXdh9t9bgSHrf/5guNHeG87/F40WoMcJxU2vgzz94u8+ugZO EyrA9D/2vc6f8XNqVMJf0prBMiFvsbJn+fADVXv+dGWnSRQbbYsv13YYf13HcLTNnPeg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hBJto-0004sr-3Z; Tue, 02 Apr 2019 15:56:24 +0200 Date: Tue, 2 Apr 2019 15:56:24 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 2/2] net: phy: deal properly with autoneg incomplete in genphy_c45_read_lpa Message-ID: <20190402135624.GB18443@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 31, 2019 at 07:54:07PM +0200, Heiner Kallweit wrote: > The link partner advertisement registers are not guaranteed to contain > valid values if autoneg is incomplete. Therefore, if > MDIO_AN_STAT1_COMPLETE isn't set, let's clear all link partner > capability bits. This also avoids unnecessary register reads if link > is down and phylib is in polling mode. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew