Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC6AC4360F for ; Tue, 2 Apr 2019 13:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 368662133D for ; Tue, 2 Apr 2019 13:56:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="BM+9erC/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732195AbfDBN4k (ORCPT ); Tue, 2 Apr 2019 09:56:40 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47385 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731186AbfDBN4k (ORCPT ); Tue, 2 Apr 2019 09:56:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=p1JrbsFm7EXpo/0TFFpNiDGr9BCBoCHUIfr52BrnnRc=; b=BM+9erC/8IF+R2TEpsZ/STY5aF AW+q8R9yxD8yq8flhaqdqfEKc0ZnjQXPJKl8HrECPRyxiuTTcMwEWbFhl8rr8h8BVP8cg3Lwjbu1o q2lxIBJAXAAKHzbN0dblQP8nrHkrGVpSq/Te3ryd2XL23RbAbl3WquYlLczPDDPY/4Mc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hBJu1-0004tZ-Ko; Tue, 02 Apr 2019 15:56:37 +0200 Date: Tue, 2 Apr 2019 15:56:37 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability Message-ID: <20190402135637.GC18443@lunn.ch> References: <0eba5bda-62c1-711e-12b5-1d71593ffad8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eba5bda-62c1-711e-12b5-1d71593ffad8@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 31, 2019 at 07:52:51PM +0200, Heiner Kallweit wrote: > Currently mii_lpa_mod_linkmode_lpa_t() checks bit LPA_LPACK to detect > whether link partner supports autoneg. This doesn't work correctly at > least on Aquantia AQCS109 when it negotiates 1000Base-T2 mode. > The "link partner is autoneg-capable" bit as defined by clause 45 is > set however. Better let's switch in general to use the clause 45 > standard for link partner autoneg detection. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew