From: Paul Durrant Subject: [PATCH v2] public/io/blkif.h: try to fix the semantics of sector based quantities Date: Tue, 2 Apr 2019 17:58:03 +0100 Message-ID: <20190402165803.28667-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hBMjn-0007fv-Nu for xen-devel@lists.xenproject.org; Tue, 02 Apr 2019 16:58:15 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Paul Durrant , Jan Beulich , Athony PERARD , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org VGhpcyBpcyBhY3R1YWxseSB2MiBvZiB0aGUgcGF0Y2ggcG9zdGVkIGluIFsxXS4gUGxlYXNlIHNl ZSB0aGUgdGhyZWFkCnN0YXJ0aW5nIHRoZXJlIGZvciBtb3JlIGNvbnRleHQuLi4KClRoZSBzZW1h bnRpY3Mgb2Ygc2VjdG9yIGJhc2VkIHF1YW50aWVzLCBzdWNoIGFzIGZpcnN0X3NlY3QgYW5kIGxh c3Rfc2VjdCBpbgpibGtpZl9yZXF1ZXN0X3NlZ21lbnQsIGFuZCB0aGUgdmFsdWUgb2YgInNlY3Rv cnMiIGluIHRoZSBiYWNrZW5kIGluZm8KaW4geGVuc3RvcmUgaGF2ZSBiZWNvbWUgY29uZnVzZWQu IFNvbWUgY29tbWVudHMgaW4gdGhlIGhlYWRlciBzdWdnZXN0IHRoZXkKc2hvdWxkIGJlIHN1cHBs aWVkL2ludGVycHJldGVkIHN0cmljdGx5IGluIHRlcm1zIG9mIDUxMi1ieXRlIHVuaXRzLCBvdGhl cnMKc3VnZ2VzdCB0aGV5IHNob3VsZCBiZSBzY2FsZWQgYnkgdGhlIHZhbHVlIG9mICJzZWN0b3It c2l6ZSIgaS5lLiB0aGUKbG9naWNhbCBibG9jayBzaXplIG9mIHRoZSB1bmRlcmx5aW5nIGJhY2tl bmQgc3RvcmFnZS4KVGhpcyBjb25mdXNpb24gaGFzIGNhdXNlZCBtaXhlZCBzZW1hbnRpY3MgdG8g YmVjb21lIGluZ3JhaW5lZCBpbiBmcm9udGVuZAppbXBsZW1lbnRhdGlvbnMuIEZvciBpbnN0YW5j ZSBMaW51eCB4ZW4tYmxrZnJvbnQuYyBjb250YWlucyBjb2RlIHN1Y2ggYXM6CgogICAgZnNlY3Qg PSBvZmZzZXQgPj4gOTsKICAgIGxzZWN0ID0gZnNlY3QgKyAobGVuID4+IDkpIC0gMTsKCndoZXJl YXMgdGhlIFdpbmRvd3MgWEVOVkJEIGZyb250ZW5kIGNvbnRhaW5zIHRoZSBmb2xsb3dpbmcgZXF1 aXZhbGVudCBjb2RlOgoKICAgIFNlZ21lbnQtPkZpcnN0U2VjdG9yID0gKFVDSEFSKSgoT2Zmc2V0 ICsgU2VjdG9yU2l6ZSAtIDEpIC8gU2VjdG9yU2l6ZSk7CiAgICAqU2VjdG9yc05vdyA9IF9fbWlu KFNlY3RvcnNMZWZ0LCBTZWN0b3JzUGVyUGFnZSAtIFNlZ21lbnQtPkZpcnN0U2VjdG9yKTsKICAg IFNlZ21lbnQtPkxhc3RTZWN0b3IgPSAoVUNIQVIpKFNlZ21lbnQtPkZpcnN0U2VjdG9yICsgKlNl Y3RvcnNOb3cgLSAxKTsKCih3aGVyZSBTZWN0b3JTaXplIGlzIHRoZSAic2VjdG9yLXNpemUiIHZh bHVlIGFkdmVydGl6ZWQgaW4geGVuc3RvcmUpLgoKVGh1cyBpdCBoYXMgYmVjb21lIHVuc2FmZSBm b3IgYSBiYWNrZW5kIHRvIHNldCAic2VjdG9yLXNpemUiIHRvIGFueXRoaW5nCm90aGVyIHRoYW4g NTEyIGFzIGl0IGRvZXMgbm90IGtub3cgd2hpY2ggd2F5IHRoZSBmcm9udGVuZCBpcyBjb2RlZC4K ClRoaXMgcGF0Y2ggaXMgaW50ZW5kZWQgdG8gY2xhcmlmeSB0aGUgc2l0dWF0aW9uIGFuZCBhbHNv IGludHJvZHVjZSBhCm1lY2hhbmlzbSB0byBhbGxvdyBsb2dpY2FsIGJsb2NrIHNpemVzIG9mIG1v cmUgdGhhbiA1MTIgdG8gYmUgc3VwcG9ydGVkLi4uCgpBIG5ldyBmcm9udGVuZCBmZWF0dXJlIG5v ZGUgaXMgc3BlY2lmaWVkOiAnZmVhdHVyZS1sYXJnZS1zZWN0b3Itc2l6ZScuCklmIHRoaXMgbm9k ZSBpcyBwcmVzZW50IGFuZCBzZXQgdG8gIjEiIHRoZW4gaXQgbWVhbnMgdGhhdCBmcm9udGVuZCBp cwpjb2RlZCB0byBzdXBwbHkgYW5kIGludGVycHJldCBhbGwgc2VjdG9yIGJhc2VkIHF1YW50aXRp ZXMgaW4gdGVybXMgb2YgdGhlCnRoZSBhZHZlcnRpemVkICJzZWN0b3Itc2l6ZSIgdmFsdWUgcmF0 aGVyIHRoYW4gYSBoYXJkY29kZWQgc2l6ZSBvZiA1MTIuCgpbMV0gaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDE5LTAzL21zZzAxNjAwLmh0bWwK ClNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Ci0t LQpDYzogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgpDYzog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CkNjOiBBdGhvbnkgUEVSQVJE IDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgpDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNv b3BlcjNAY2l0cml4LmNvbT4KQ2M6IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAZXUuY2l0 cml4LmNvbT4KQ2M6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXguY29tPgpDYzog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW4u Z3JhbGxAYXJtLmNvbT4KQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz4KQ2M6IFRpbSBEZWVnYW4gPHRpbUB4ZW4ub3JnPgpDYzogV2VpIExpdSA8d2VpLmxpdTJA Y2l0cml4LmNvbT4KCnYyOgogLSBEcm9wIEtvbnJhZCdzIG9yaWdpbmFsIGFjayBzaW5jZSB0aGUg cGF0Y2ggaGFzIHN1YnN0YW50aWFsbHkgY2hhbmdlZAogLSBDYyBzZXZlcmFsIGRpZmZlcmVudCBP UyBibGtmcm9udCBtYWludGFpbmVycyBhbmQgJ3RoZSByZXN0JyBtYWludGFpbmVycwogICBmb3Ig bW9yZSBvcGluaW9uCi0tLQogeGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggfCA0MCArKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMwIGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1Ymxp Yy9pby9ibGtpZi5oIGIveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmgKaW5kZXggMTVhNzFl M2ZlYS4uZDRhMzRkZTk0YyAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lm LmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmgKQEAgLTI1NCwxOCArMjU0LDI2 IEBACiAgKiBzZWN0b3Itc2l6ZQogICogICAgICBWYWx1ZXM6ICAgICAgICAgPHVpbnQzMl90Pgog ICoKLSAqICAgICAgVGhlIGxvZ2ljYWwgc2VjdG9yIHNpemUsIGluIGJ5dGVzLCBvZiB0aGUgYmFj a2VuZCBkZXZpY2UuCisgKiAgICAgIFRoZSBsb2dpY2FsIGJsb2NrIHNpemUsIGluIGJ5dGVzLCBv ZiB0aGUgdW5kZXJseWluZyBzdG9yYWdlLiBUaGlzCisgKiAgICAgIG11c3QgYmUgYSBwb3dlciBv ZiB0d28gd2l0aCBhIG1pbmltdW0gdmFsdWUgb2YgNTEyLgorICoKKyAqICAgICAgTk9URTogQmVj YXVzZSBvZiBpbXBsZW1lbnRhdGlvbiBidWdzIGluIHNvbWUgZnJvbnRlbmRzIHRoaXMgbXVzdCBi ZQorICogICAgICAgICAgICBzZXQgdG8gNTEyLCB1bmxlc3MgdGhlIGZyb250ZW5kIGFkdmVydGl6 ZXMgYSBub24temVybyB2YWx1ZQorICogICAgICAgICAgICBpbiBpdHMgImZlYXR1cmUtbGFyZ2Ut c2VjdG9yLXNpemUiIHhlbmJ1cyBub2RlLiAoU2VlIGJlbG93KS4KICAqCiAgKiBwaHlzaWNhbC1z ZWN0b3Itc2l6ZQogICogICAgICBWYWx1ZXM6ICAgICAgICAgPHVpbnQzMl90PgorICogICAgICBE ZWZhdWx0IFZhbHVlOiAgPCJzZWN0b3Itc2l6ZSI+CiAgKgotICogICAgICBUaGUgcGh5c2ljYWwg c2VjdG9yIHNpemUsIGluIGJ5dGVzLCBvZiB0aGUgYmFja2VuZCBkZXZpY2UuCisgKiAgICAgIFRo ZSBwaHlzaWNhbCBibG9jayBzaXplLCBpbiBieXRlcywgb2YgdGhlIGJhY2tlbmQgc3RvcmFnZS4g VGhpcworICogICAgICBtdXN0IGJlIGFuIGludGVnZXIgbXVsdGlwbGUgb2YgInNlY3Rvci1zaXpl Ii4KICAqCiAgKiBzZWN0b3JzCiAgKiAgICAgIFZhbHVlczogICAgICAgICA8dWludDY0X3Q+CiAg KgotICogICAgICBUaGUgc2l6ZSBvZiB0aGUgYmFja2VuZCBkZXZpY2UsIGV4cHJlc3NlZCBpbiB1 bml0cyBvZiBpdHMgbG9naWNhbAotICogICAgICBzZWN0b3Igc2l6ZSAoInNlY3Rvci1zaXplIiku CisgKiAgICAgIFRoZSBzaXplIG9mIHRoZSBiYWNrZW5kIGRldmljZSwgZXhwcmVzc2VkIGluIHVu aXRzIG9mICJzZWN0b3Itc2l6ZSIuCisgKiAgICAgIFRoZSBwcm9kdWN0IG9mICJzZWN0b3Itc2l6 ZSIgYW5kICJzZWN0b3JzIiBtdXN0IGFsc28gYmUgYW4gaW50ZWdlcgorICogICAgICBtdWx0aXBs ZSBvZiAicGh5c2ljYWwtc2VjdG9yLXNpemUiLCBpZiB0aGF0IG5vZGUgaXMgcHJlc2VudC4KICAq CiAgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioKICAqICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZy b250ZW5kIFhlbkJ1cyBOb2RlcwpAQCAtMzIxLDYgKzMyOSw4IEBACiAgKiAgICAgIFRoZSBzaXpl IG9mIHRoZSBmcm9udGVuZCBhbGxvY2F0ZWQgcmVxdWVzdCByaW5nIGJ1ZmZlciBpbiB1bml0cyBv ZgogICogICAgICBtYWNoaW5lIHBhZ2VzLiAgVGhlIHZhbHVlIG11c3QgYmUgYSBwb3dlciBvZiAy LgogICoKKyAqLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIEZlYXR1cmVzIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorICoKICAqIGZlYXR1cmUtcGVyc2lzdGVudAog ICogICAgICBWYWx1ZXM6ICAgICAgICAgMC8xIChib29sZWFuKQogICogICAgICBEZWZhdWx0IFZh bHVlOiAgMApAQCAtMzQyLDYgKzM1MiwxNyBAQAogICogICAgICBkZWNpZGVzIHRvIGxpbWl0IHRo ZSBtYXhpbXVtIG51bWJlciBvZiBwZXJzaXN0ZW50bHkgbWFwcGVkIGdyYW50cwogICogICAgICB0 byBhIHZhbHVlIGxlc3MgdGhhbiBSSU5HX1NJWkUgKiBCTEtJRl9NQVhfU0VHTUVOVFNfUEVSX1JF UVVFU1QuCiAgKgorICogZmVhdHVyZS1sYXJnZS1zZWN0b3Itc2l6ZQorICogICAgICBWYWx1ZXM6 ICAgICAgICAgMC8xIChib29sZWFuKQorICogICAgICBEZWZhdWx0IFZhbHVlOiAgMAorICoKKyAq ICAgICAgQSB2YWx1ZSBvZiAiMSIgaW5kaWNhdGVzIHRoYXQgdGhlIGZyb250ZW5kIHdpbGwgY29y cmVjdGx5IHN1cHBseSBhbmQKKyAqICAgICAgaW50ZXJwcmV0IGFsbCBzZWN0b3ItYmFzZWQgcXVh bnRpdGllcyBpbiB0ZXJtcyBvZiB0aGUgInNlY3Rvci1zaXplIgorICogICAgICB2YWx1ZSBzdXBw bGllZCBpbiB0aGUgYmFja2VuZCBpbmZvLCB3aGF0ZXZlciB0aGF0IG1heSBiZSBzZXQgdG8uCisg KiAgICAgIElmIHRoaXMgbm9kZSBpcyBub3QgcHJlc2VudCBvciBpdHMgdmFsdWUgaXMgIjAiIHRo ZW4gaXQgaXMgYXNzdW1lZAorICogICAgICB0aGF0IHRoZSBmcm9udGVuZCByZXF1aXJlcyB0aGF0 IHRoZSBsb2dpY2FsIGJsb2NrIHNpemUgaXMgNTEyIGFzIGl0CisgKiAgICAgIGlzIGhhcmRjb2Rl ZCAod2hpY2ggaXMgdGhlIGNhc2UgaW4gc29tZSBmcm9udGVuZCBpbXBsZW1lbnRhdGlvbnMpLgor ICoKICAqLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSBWaXJ0dWFsIERldmljZSBQcm9wZXJ0aWVz IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAqCiAgKiBkZXZpY2UtdHlwZQpAQCAtNjA3LDEy ICs2MjgsMTEgQEAKICNkZWZpbmUgQkxLSUZfTUFYX0lORElSRUNUX1BBR0VTX1BFUl9SRVFVRVNU IDgKIAogLyoKLSAqIE5CLiBmaXJzdF9zZWN0IGFuZCBsYXN0X3NlY3QgaW4gYmxraWZfcmVxdWVz dF9zZWdtZW50LCBhcyB3ZWxsIGFzCi0gKiBzZWN0b3JfbnVtYmVyIGluIGJsa2lmX3JlcXVlc3Qs IGFyZSBhbHdheXMgZXhwcmVzc2VkIGluIDUxMi1ieXRlIHVuaXRzLgotICogSG93ZXZlciB0aGV5 IG11c3QgYmUgcHJvcGVybHkgYWxpZ25lZCB0byB0aGUgcmVhbCBzZWN0b3Igc2l6ZSBvZiB0aGUK LSAqIHBoeXNpY2FsIGRpc2ssIHdoaWNoIGlzIHJlcG9ydGVkIGluIHRoZSAicGh5c2ljYWwtc2Vj dG9yLXNpemUiIG5vZGUgaW4KLSAqIHRoZSBiYWNrZW5kIHhlbmJ1cyBpbmZvLiBBbHNvIHRoZSB4 ZW5idXMgInNlY3RvcnMiIG5vZGUgaXMgZXhwcmVzc2VkIGluCi0gKiA1MTItYnl0ZSB1bml0cy4K KyAqIE5CLiAnZmlyc3Rfc2VjdCcgYW5kICdsYXN0X3NlY3QnIGluIGJsa2lmX3JlcXVlc3Rfc2Vn bWVudCwgYXMgd2VsbCBhcworICogJ3NlY3Rvcl9udW1iZXInIGluIGJsa2lmX3JlcXVlc3QsIGJs a2lmX3JlcXVlc3RfZGlzY2FyZCBhbmQKKyAqIGJsa2lmX3JlcXVlc3RfaW5kaXJlY3QgYXJlIHNl Y3Rvci1iYXNlZCBxdWFudGl0aWVzLiBTZWUgdGhlIGRlc2NyaXB0aW9uCisgKiBvZiB0aGUgImZl YXR1cmUtbGFyZ2Utc2VjdG9yLXNpemUiIGZyb250ZW5kIHhlbmJ1cyBub2RlIGFib3ZlIGZvcgor ICogbW9yZSBpbmZvcm1hdGlvbi4KICAqLwogc3RydWN0IGJsa2lmX3JlcXVlc3Rfc2VnbWVudCB7 CiAgICAgZ3JhbnRfcmVmX3QgZ3JlZjsgICAgICAgIC8qIHJlZmVyZW5jZSB0byBJL08gYnVmZmVy IGZyYW1lICAgICAgICAqLwotLSAKMi4yMC4xLjIuZ2IyMWViYjYKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs