From: Paul Durrant Subject: [PATCH v3] public/io/blkif.h: try to fix the semantics of sector based quantities Date: Thu, 4 Apr 2019 12:40:02 +0100 Message-ID: <20190404114002.30184-1-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hC0j5-0003mX-Ri for xen-devel@lists.xenproject.org; Thu, 04 Apr 2019 11:40:11 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Paul Durrant , Jan Beulich , Athony PERARD , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org VGhlIHNlbWFudGljcyBvZiBzZWN0b3IgYmFzZWQgcXVhbnRpdGllcywgc3VjaCBhcyBmaXJzdF9z ZWN0IGFuZCBsYXN0X3NlY3QKaW4gYmxraWZfcmVxdWVzdF9zZWdtZW50LCBhbmQgdGhlIHZhbHVl IG9mICJzZWN0b3JzIiBpbiB0aGUgYmFja2VuZCBpbmZvCmluIHhlbnN0b3JlIGhhdmUgYmVjb21l IGNvbmZ1c2VkLiBTb21lIGNvbW1lbnRzIGluIHRoZSBoZWFkZXIgc3VnZ2VzdCB0aGV5CnNob3Vs ZCBiZSBzdXBwbGllZC9pbnRlcnByZXRlZCBzdHJpY3RseSBpbiB0ZXJtcyBvZiA1MTItYnl0ZSB1 bml0cywgb3RoZXJzCnN1Z2dlc3QgdGhleSBzaG91bGQgYmUgc2NhbGVkIGJ5IHRoZSB2YWx1ZSBv ZiAic2VjdG9yLXNpemUiIGkuZS4gdGhlCmxvZ2ljYWwgYmxvY2sgc2l6ZSBvZiB0aGUgdW5kZXJs eWluZyBiYWNrZW5kIHN0b3JhZ2UuClRoaXMgY29uZnVzaW9uIGhhcyBjYXVzZWQgbWl4ZWQgc2Vt YW50aWNzIHRvIGJlY29tZSBpbmdyYWluZWQgaW4gZnJvbnRlbmQKaW1wbGVtZW50YXRpb25zLiBG b3IgaW5zdGFuY2UgTGludXggeGVuLWJsa2Zyb250LmMgY29udGFpbnMgY29kZSBzdWNoIGFzOgoK ICAgIGZzZWN0ID0gb2Zmc2V0ID4+IDk7CiAgICBsc2VjdCA9IGZzZWN0ICsgKGxlbiA+PiA5KSAt IDE7Cgp3aGVyZWFzIHRoZSBXaW5kb3dzIFhFTlZCRCBmcm9udGVuZCBjb250YWlucyB0aGUgZm9s bG93aW5nIGVxdWl2YWxlbnQgY29kZToKCiAgICBTZWdtZW50LT5GaXJzdFNlY3RvciA9IChVQ0hB UikoKE9mZnNldCArIFNlY3RvclNpemUgLSAxKSAvIFNlY3RvclNpemUpOwogICAgKlNlY3RvcnNO b3cgPSBfX21pbihTZWN0b3JzTGVmdCwgU2VjdG9yc1BlclBhZ2UgLSBTZWdtZW50LT5GaXJzdFNl Y3Rvcik7CiAgICBTZWdtZW50LT5MYXN0U2VjdG9yID0gKFVDSEFSKShTZWdtZW50LT5GaXJzdFNl Y3RvciArICpTZWN0b3JzTm93IC0gMSk7Cgood2hlcmUgU2VjdG9yU2l6ZSBpcyB0aGUgInNlY3Rv ci1zaXplIiB2YWx1ZSBhZHZlcnRpemVkIGluIHhlbnN0b3JlKS4KClRodXMgaXQgaGFzIGJlY29t ZSB1bnNhZmUgZm9yIGEgYmFja2VuZCB0byBzZXQgInNlY3Rvci1zaXplIiB0byBhbnl0aGluZwpv dGhlciB0aGFuIDUxMiBhcyBpdCBkb2VzIG5vdCBrbm93IHdoaWNoIHdheSB0aGUgZnJvbnRlbmQg aXMgY29kZWQuCgpUaGlzIHBhdGNoIGlzIGludGVuZGVkIHRvIGNsYXJpZnkgdGhlIHNpdHVhdGlv biBhbmQgYWxzbyBpbnRyb2R1Y2UgYQptZWNoYW5pc20gdG8gYWxsb3cgbG9naWNhbCBibG9jayBz aXplcyBvZiBtb3JlIHRoYW4gNTEyIHRvIGJlIHN1cHBvcnRlZC4uLgoKQSBuZXcgZnJvbnRlbmQg ZmVhdHVyZSBub2RlIGlzIHNwZWNpZmllZDogJ2ZlYXR1cmUtbGFyZ2Utc2VjdG9yLXNpemUnLgpJ ZiB0aGlzIG5vZGUgaXMgcHJlc2VudCBhbmQgc2V0IHRvICIxIiB0aGVuIGl0IG1lYW5zIHRoYXQg ZnJvbnRlbmQgaXMKY29kZWQgdG8gc3VwcGx5IGFuZCBpbnRlcnByZXQgYWxsIHNlY3RvciBiYXNl ZCBxdWFudGl0aWVzIGluIHRlcm1zIG9mIHRoZQp0aGUgYWR2ZXJ0aXplZCAic2VjdG9yLXNpemUi IHZhbHVlIHJhdGhlciB0aGFuIGEgaGFyZGNvZGVkIHNpemUgb2YgNTEyLgoKU2lnbmVkLW9mZi1i eTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KLS0tCkNjOiBLb25yYWQgUnplc3p1dGVrIFdp bGsgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+CkNjOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5w YXVAY2l0cml4LmNvbT4KQ2M6IEF0aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5j b20+CkNjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpDYzogR2Vv cmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPgpDYzogSWFuIEphY2tzb24g PGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+CkNjOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+CkNjOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgpDYzogU3RlZmFu byBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgpDYzogVGltIERlZWdhbiA8dGlt QHhlbi5vcmc+CkNjOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgoKVGhpcyBpcyBhY3R1 YWxseSB2MyBvZiB0aGUgcGF0Y2ggcG9zdGVkIGluIFsxXS4gUGxlYXNlIHNlZSB0aGUgdGhyZWFk CnN0YXJ0aW5nIHRoZXJlIGZvciBtb3JlIGNvbnRleHQuLi4KCnYzOgogLSBGaXggY29tbWl0IGNv bW1lbnQKCnYyOgogLSBEcm9wIEtvbnJhZCdzIG9yaWdpbmFsIGFjayBzaW5jZSB0aGUgcGF0Y2gg aGFzIHN1YnN0YW50aWFsbHkgY2hhbmdlZAogLSBDYyBzZXZlcmFsIGRpZmZlcmVudCBPUyBibGtm cm9udCBtYWludGFpbmVycyBhbmQgJ3RoZSByZXN0JyBtYWludGFpbmVycwogICBmb3IgbW9yZSBv cGluaW9uCgpbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hl bi1kZXZlbC8yMDE5LTAzL21zZzAxNjAwLmh0bWwKLS0tCiB4ZW4vaW5jbHVkZS9wdWJsaWMvaW8v YmxraWYuaCB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxr aWYuaAppbmRleCAxNWE3MWUzZmVhLi5kNGEzNGRlOTRjIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvaW8vYmxraWYuaAorKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYuaApA QCAtMjU0LDE4ICsyNTQsMjYgQEAKICAqIHNlY3Rvci1zaXplCiAgKiAgICAgIFZhbHVlczogICAg ICAgICA8dWludDMyX3Q+CiAgKgotICogICAgICBUaGUgbG9naWNhbCBzZWN0b3Igc2l6ZSwgaW4g Ynl0ZXMsIG9mIHRoZSBiYWNrZW5kIGRldmljZS4KKyAqICAgICAgVGhlIGxvZ2ljYWwgYmxvY2sg c2l6ZSwgaW4gYnl0ZXMsIG9mIHRoZSB1bmRlcmx5aW5nIHN0b3JhZ2UuIFRoaXMKKyAqICAgICAg bXVzdCBiZSBhIHBvd2VyIG9mIHR3byB3aXRoIGEgbWluaW11bSB2YWx1ZSBvZiA1MTIuCisgKgor ICogICAgICBOT1RFOiBCZWNhdXNlIG9mIGltcGxlbWVudGF0aW9uIGJ1Z3MgaW4gc29tZSBmcm9u dGVuZHMgdGhpcyBtdXN0IGJlCisgKiAgICAgICAgICAgIHNldCB0byA1MTIsIHVubGVzcyB0aGUg ZnJvbnRlbmQgYWR2ZXJ0aXplcyBhIG5vbi16ZXJvIHZhbHVlCisgKiAgICAgICAgICAgIGluIGl0 cyAiZmVhdHVyZS1sYXJnZS1zZWN0b3Itc2l6ZSIgeGVuYnVzIG5vZGUuIChTZWUgYmVsb3cpLgog ICoKICAqIHBoeXNpY2FsLXNlY3Rvci1zaXplCiAgKiAgICAgIFZhbHVlczogICAgICAgICA8dWlu dDMyX3Q+CisgKiAgICAgIERlZmF1bHQgVmFsdWU6ICA8InNlY3Rvci1zaXplIj4KICAqCi0gKiAg ICAgIFRoZSBwaHlzaWNhbCBzZWN0b3Igc2l6ZSwgaW4gYnl0ZXMsIG9mIHRoZSBiYWNrZW5kIGRl dmljZS4KKyAqICAgICAgVGhlIHBoeXNpY2FsIGJsb2NrIHNpemUsIGluIGJ5dGVzLCBvZiB0aGUg YmFja2VuZCBzdG9yYWdlLiBUaGlzCisgKiAgICAgIG11c3QgYmUgYW4gaW50ZWdlciBtdWx0aXBs ZSBvZiAic2VjdG9yLXNpemUiLgogICoKICAqIHNlY3RvcnMKICAqICAgICAgVmFsdWVzOiAgICAg ICAgIDx1aW50NjRfdD4KICAqCi0gKiAgICAgIFRoZSBzaXplIG9mIHRoZSBiYWNrZW5kIGRldmlj ZSwgZXhwcmVzc2VkIGluIHVuaXRzIG9mIGl0cyBsb2dpY2FsCi0gKiAgICAgIHNlY3RvciBzaXpl ICgic2VjdG9yLXNpemUiKS4KKyAqICAgICAgVGhlIHNpemUgb2YgdGhlIGJhY2tlbmQgZGV2aWNl LCBleHByZXNzZWQgaW4gdW5pdHMgb2YgInNlY3Rvci1zaXplIi4KKyAqICAgICAgVGhlIHByb2R1 Y3Qgb2YgInNlY3Rvci1zaXplIiBhbmQgInNlY3RvcnMiIG11c3QgYWxzbyBiZSBhbiBpbnRlZ2Vy CisgKiAgICAgIG11bHRpcGxlIG9mICJwaHlzaWNhbC1zZWN0b3Itc2l6ZSIsIGlmIHRoYXQgbm9k ZSBpcyBwcmVzZW50LgogICoKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgogICogICAgICAgICAgICAg ICAgICAgICAgICAgICAgRnJvbnRlbmQgWGVuQnVzIE5vZGVzCkBAIC0zMjEsNiArMzI5LDggQEAK ICAqICAgICAgVGhlIHNpemUgb2YgdGhlIGZyb250ZW5kIGFsbG9jYXRlZCByZXF1ZXN0IHJpbmcg YnVmZmVyIGluIHVuaXRzIG9mCiAgKiAgICAgIG1hY2hpbmUgcGFnZXMuICBUaGUgdmFsdWUgbXVz dCBiZSBhIHBvd2VyIG9mIDIuCiAgKgorICotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0gRmVhdHVyZXMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisgKgogICogZmVh dHVyZS1wZXJzaXN0ZW50CiAgKiAgICAgIFZhbHVlczogICAgICAgICAwLzEgKGJvb2xlYW4pCiAg KiAgICAgIERlZmF1bHQgVmFsdWU6ICAwCkBAIC0zNDIsNiArMzUyLDE3IEBACiAgKiAgICAgIGRl Y2lkZXMgdG8gbGltaXQgdGhlIG1heGltdW0gbnVtYmVyIG9mIHBlcnNpc3RlbnRseSBtYXBwZWQg Z3JhbnRzCiAgKiAgICAgIHRvIGEgdmFsdWUgbGVzcyB0aGFuIFJJTkdfU0laRSAqIEJMS0lGX01B WF9TRUdNRU5UU19QRVJfUkVRVUVTVC4KICAqCisgKiBmZWF0dXJlLWxhcmdlLXNlY3Rvci1zaXpl CisgKiAgICAgIFZhbHVlczogICAgICAgICAwLzEgKGJvb2xlYW4pCisgKiAgICAgIERlZmF1bHQg VmFsdWU6ICAwCisgKgorICogICAgICBBIHZhbHVlIG9mICIxIiBpbmRpY2F0ZXMgdGhhdCB0aGUg ZnJvbnRlbmQgd2lsbCBjb3JyZWN0bHkgc3VwcGx5IGFuZAorICogICAgICBpbnRlcnByZXQgYWxs IHNlY3Rvci1iYXNlZCBxdWFudGl0aWVzIGluIHRlcm1zIG9mIHRoZSAic2VjdG9yLXNpemUiCisg KiAgICAgIHZhbHVlIHN1cHBsaWVkIGluIHRoZSBiYWNrZW5kIGluZm8sIHdoYXRldmVyIHRoYXQg bWF5IGJlIHNldCB0by4KKyAqICAgICAgSWYgdGhpcyBub2RlIGlzIG5vdCBwcmVzZW50IG9yIGl0 cyB2YWx1ZSBpcyAiMCIgdGhlbiBpdCBpcyBhc3N1bWVkCisgKiAgICAgIHRoYXQgdGhlIGZyb250 ZW5kIHJlcXVpcmVzIHRoYXQgdGhlIGxvZ2ljYWwgYmxvY2sgc2l6ZSBpcyA1MTIgYXMgaXQKKyAq ICAgICAgaXMgaGFyZGNvZGVkICh3aGljaCBpcyB0aGUgY2FzZSBpbiBzb21lIGZyb250ZW5kIGlt cGxlbWVudGF0aW9ucykuCisgKgogICotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIFZpcnR1YWwg RGV2aWNlIFByb3BlcnRpZXMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogICoKICAqIGRldmlj ZS10eXBlCkBAIC02MDcsMTIgKzYyOCwxMSBAQAogI2RlZmluZSBCTEtJRl9NQVhfSU5ESVJFQ1Rf UEFHRVNfUEVSX1JFUVVFU1QgOAogCiAvKgotICogTkIuIGZpcnN0X3NlY3QgYW5kIGxhc3Rfc2Vj dCBpbiBibGtpZl9yZXF1ZXN0X3NlZ21lbnQsIGFzIHdlbGwgYXMKLSAqIHNlY3Rvcl9udW1iZXIg aW4gYmxraWZfcmVxdWVzdCwgYXJlIGFsd2F5cyBleHByZXNzZWQgaW4gNTEyLWJ5dGUgdW5pdHMu Ci0gKiBIb3dldmVyIHRoZXkgbXVzdCBiZSBwcm9wZXJseSBhbGlnbmVkIHRvIHRoZSByZWFsIHNl Y3RvciBzaXplIG9mIHRoZQotICogcGh5c2ljYWwgZGlzaywgd2hpY2ggaXMgcmVwb3J0ZWQgaW4g dGhlICJwaHlzaWNhbC1zZWN0b3Itc2l6ZSIgbm9kZSBpbgotICogdGhlIGJhY2tlbmQgeGVuYnVz IGluZm8uIEFsc28gdGhlIHhlbmJ1cyAic2VjdG9ycyIgbm9kZSBpcyBleHByZXNzZWQgaW4KLSAq IDUxMi1ieXRlIHVuaXRzLgorICogTkIuICdmaXJzdF9zZWN0JyBhbmQgJ2xhc3Rfc2VjdCcgaW4g YmxraWZfcmVxdWVzdF9zZWdtZW50LCBhcyB3ZWxsIGFzCisgKiAnc2VjdG9yX251bWJlcicgaW4g YmxraWZfcmVxdWVzdCwgYmxraWZfcmVxdWVzdF9kaXNjYXJkIGFuZAorICogYmxraWZfcmVxdWVz dF9pbmRpcmVjdCBhcmUgc2VjdG9yLWJhc2VkIHF1YW50aXRpZXMuIFNlZSB0aGUgZGVzY3JpcHRp b24KKyAqIG9mIHRoZSAiZmVhdHVyZS1sYXJnZS1zZWN0b3Itc2l6ZSIgZnJvbnRlbmQgeGVuYnVz IG5vZGUgYWJvdmUgZm9yCisgKiBtb3JlIGluZm9ybWF0aW9uLgogICovCiBzdHJ1Y3QgYmxraWZf cmVxdWVzdF9zZWdtZW50IHsKICAgICBncmFudF9yZWZfdCBncmVmOyAgICAgICAgLyogcmVmZXJl bmNlIHRvIEkvTyBidWZmZXIgZnJhbWUgICAgICAgICovCi0tIAoyLjIwLjEuMi5nYjIxZWJiNgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=