Received: from eggs.gnu.org ([209.51.188.92]:50687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCY5d-0007Yy-MS for qemu-devel@nongnu.org; Fri, 05 Apr 2019 19:17:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCY5c-0004Di-NK for qemu-devel@nongnu.org; Fri, 05 Apr 2019 19:17:41 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37719) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCY5b-00045k-SE for qemu-devel@nongnu.org; Fri, 05 Apr 2019 19:17:40 -0400 Received: by mail-qt1-f196.google.com with SMTP id z16so9389438qtn.4 for ; Fri, 05 Apr 2019 16:17:38 -0700 (PDT) Date: Fri, 5 Apr 2019 19:17:35 -0400 From: "Michael S. Tsirkin" Message-ID: <20190405191703-mutt-send-email-mst@kernel.org> References: <20190405115529.11590-1-philmd@redhat.com> <20190405140917.3af9b91d.olaf@aepfle.de> <6bdd3c91-1e65-db2d-8ff2-fa667a819a1f@redhat.com> <20190405150438.48c1cc84.olaf@aepfle.de> <3c212c03-80a3-a8bb-fbe0-0071ebfb6936@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3c212c03-80a3-a8bb-fbe0-0071ebfb6936@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Olaf Hering , qemu-devel@nongnu.org, Laszlo Ersek , Gerd Hoffmann , Igor Mammedov , ipxe-devel@lists.ipxe.org On Fri, Apr 05, 2019 at 03:14:30PM +0200, Philippe Mathieu-Daudé wrote: > On 4/5/19 3:04 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 14:59:16 +0200 > > schrieb Philippe Mathieu-Daudé : > >> On 4/5/19 2:09 PM, Olaf Hering wrote: > >>> Am Fri, 5 Apr 2019 13:55:29 +0200 > >>> schrieb Philippe Mathieu-Daudé : > >>> > >>>> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom > >>> > >>> This name is too generic and will conflict with ipxe.git if any of "bios seavgabios pxerom" is used for 'make -C roms'. > >> > >> This is similar to commit c9d18c1c150c84e where you said "it used to > >> work", what is the difference? > > > > Before there was no need to pass EFIROM= to make, so ipxe.git was happy. > > Now it is required, and ipxe.git gets an unexpected value. > > > >> IPXE override the EFIROM variable, so there is no change there. > > > > For me ipxe tries to rm $(type -P EfiRom). Let me double check. > > Eh you are right... > > $ make -C roms EFIROM=/bin/true clean > [...] > make -C ipxe/src veryclean > make[1]: Entering directory '/home/phil/source/qemu/roms/ipxe/src' > rm -f bin{,-*}/*.* bin{,-*}/.certificate.* bin{,-*}/.certificates.* > bin{,-*}/.private_key.* bin{,-*}/errors bin{,-*}/NIC ./util/zbin > ./util/elf2efi32 ./util/elf2efi64 /bin/true ./util/efifatbin > ./util/iccfix ./util/einfo TAGS bin{,-*}/symtab > rm: cannot remove '/bin/true': Permission denied > make[1]: *** [Makefile.housekeeping:1564: clean] Error 1 > > This seems to be a pre-existent IPXE bug: > > $ git checkout c9d18c1c150c84e7a976df989ad04ddf01083f46 > $ make -C roms EFIROM=/bin/true clean > [...] > rm: cannot remove '/bin/true': Permission denied > make[1]: *** [Makefile.housekeeping:1564: clean] Error 1 > > >> How can I trigger a SUSE package build with this patch? > > > > Not so easy without a VM. > > Oh, unfortunate :( > > > > > Olaf > > > Let's keep it simple: set a config variable, then check it here. -- MST