From: "Wang, Kevin(Yang)" Subject: [PATCH 2/2] drm/amd/powerplay: simplify the code of [get|set]_activity_monitor_coeff Date: Mon, 8 Apr 2019 08:43:05 +0000 Message-ID: <20190408084240.17192-2-kevin1.wang@amd.com> References: <20190408084240.17192-1-kevin1.wang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190408084240.17192-1-kevin1.wang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "Huang, Ray" , "Feng, Kenneth" , "Wang, Kevin(Yang)" dXNlIHNtdV91cGRhdGVfdGFibGVfd2l0aF9hcmcgdG8gcmVwbGFjZSBvbGQgY29kZSBsb2dpYw0K DQpTaWduZWQtb2ZmLWJ5OiBLZXZpbiBXYW5nIDxrZXZpbjEud2FuZ0BhbWQuY29tPg0KLS0tDQog Li4uL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9pbmMvYW1kZ3B1X3NtdS5oICAgIHwgIDYgLS0NCiBk cml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVfdjExXzAuYyAgICAgfCA3NSArKy0tLS0t LS0tLS0tLS0tLS0tDQogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDc0IGRlbGV0 aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaW5j L2FtZGdwdV9zbXUuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2luYy9hbWRncHVf c211LmgNCmluZGV4IGMxNDZiNWU4ODRmOC4uMjZhN2QyYzdmNGZhIDEwMDY0NA0KLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaW5jL2FtZGdwdV9zbXUuaA0KKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaW5jL2FtZGdwdV9zbXUuaA0KQEAgLTUyNCwxMiArNTI0 LDYgQEAgc3RydWN0IHNtdV9mdW5jcw0KIAkJCQkJICAgICAgIHN0cnVjdCBkbV9wcF93bV9zZXRz X3dpdGhfY2xvY2tfcmFuZ2VzX3NvYzE1ICpjbG9ja19yYW5nZXMpOw0KIAlpbnQgKCpzZXRfb2Q4 X2RlZmF1bHRfc2V0dGluZ3MpKHN0cnVjdCBzbXVfY29udGV4dCAqc211LA0KIAkJCQkJYm9vbCBp bml0aWFsaXplKTsNCi0JaW50ICgqZ2V0X2FjdGl2aXR5X21vbml0b3JfY29lZmYpKHN0cnVjdCBz bXVfY29udGV4dCAqc211LA0KLQkJCQkgICAgICB1aW50OF90ICp0YWJsZSwNCi0JCQkJICAgICAg dWludDE2X3Qgd29ya2xvYWRfdHlwZSk7DQotCWludCAoKnNldF9hY3Rpdml0eV9tb25pdG9yX2Nv ZWZmKShzdHJ1Y3Qgc211X2NvbnRleHQgKnNtdSwNCi0JCQkJICAgICAgdWludDhfdCAqdGFibGUs DQotCQkJCSAgICAgIHVpbnQxNl90IHdvcmtsb2FkX3R5cGUpOw0KIAlpbnQgKCpjb252X3Bvd2Vy X3Byb2ZpbGVfdG9fcHBsaWJfd29ya2xvYWQpKGludCBwb3dlcl9wcm9maWxlKTsNCiAJaW50ICgq Z2V0X3Bvd2VyX3Byb2ZpbGVfbW9kZSkoc3RydWN0IHNtdV9jb250ZXh0ICpzbXUsIGNoYXIgKmJ1 Zik7DQogCWludCAoKnNldF9wb3dlcl9wcm9maWxlX21vZGUpKHN0cnVjdCBzbXVfY29udGV4dCAq c211LCBsb25nICppbnB1dCwgdWludDMyX3Qgc2l6ZSk7DQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2FtZC9wb3dlcnBsYXkvc211X3YxMV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bv d2VycGxheS9zbXVfdjExXzAuYw0KaW5kZXggMGU0YjRiODhhZjI0Li40MzVjYjYwNmQ3ZWIgMTAw NjQ0DQotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVfdjExXzAuYw0KKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvc211X3YxMV8wLmMNCkBAIC0xNDYwLDYy ICsxNDYwLDYgQEAgc3RhdGljIGludCBzbXVfdjExXzBfc2V0X29kOF9kZWZhdWx0X3NldHRpbmdz KHN0cnVjdCBzbXVfY29udGV4dCAqc211LA0KIAlyZXR1cm4gMDsNCiB9DQogDQotc3RhdGljIGlu dCBzbXVfdjExXzBfc2V0X2FjdGl2aXR5X21vbml0b3JfY29lZmYoc3RydWN0IHNtdV9jb250ZXh0 ICpzbXUsDQotCQkJCSAgICAgIHVpbnQ4X3QgKnRhYmxlLCB1aW50MTZfdCB3b3JrbG9hZF90eXBl KQ0KLXsNCi0JaW50IHJldCA9IDA7DQotCW1lbWNweShzbXUtPnNtdV90YWJsZS50YWJsZXNbVEFC TEVfQUNUSVZJVFlfTU9OSVRPUl9DT0VGRl0uY3B1X2FkZHIsDQotCSAgICAgICB0YWJsZSwgc211 LT5zbXVfdGFibGUudGFibGVzW1RBQkxFX0FDVElWSVRZX01PTklUT1JfQ09FRkZdLnNpemUpOw0K LQlyZXQgPSBzbXVfc2VuZF9zbWNfbXNnX3dpdGhfcGFyYW0oc211LCBTTVVfTVNHX1NldERyaXZl ckRyYW1BZGRySGlnaCwNCi0JCQkJCSAgdXBwZXJfMzJfYml0cyhzbXUtPnNtdV90YWJsZS50YWJs ZXNbVEFCTEVfQUNUSVZJVFlfTU9OSVRPUl9DT0VGRl0ubWNfYWRkcmVzcykpOw0KLQlpZiAocmV0 KSB7DQotCQlwcl9lcnIoIlslc10gQXR0ZW1wdCB0byBTZXQgRHJhbSBBZGRyIEhpZ2ggRmFpbGVk ISIsIF9fZnVuY19fKTsNCi0JCXJldHVybiByZXQ7DQotCX0NCi0JcmV0ID0gc211X3NlbmRfc21j X21zZ193aXRoX3BhcmFtKHNtdSwgU01VX01TR19TZXREcml2ZXJEcmFtQWRkckxvdywNCi0JCQkJ CSAgbG93ZXJfMzJfYml0cyhzbXUtPnNtdV90YWJsZS50YWJsZXNbVEFCTEVfQUNUSVZJVFlfTU9O SVRPUl9DT0VGRl0ubWNfYWRkcmVzcykpOw0KLQlpZiAocmV0KSB7DQotCQlwcl9lcnIoIlslc10g QXR0ZW1wdCB0byBTZXQgRHJhbSBBZGRyIExvdyBGYWlsZWQhIiwgX19mdW5jX18pOw0KLQkJcmV0 dXJuIHJldDsNCi0JfQ0KLQlyZXQgPSBzbXVfc2VuZF9zbWNfbXNnX3dpdGhfcGFyYW0oc211LCBT TVVfTVNHX1RyYW5zZmVyVGFibGVTbXUyRHJhbSwNCi0JCQkJCSAgVEFCTEVfQUNUSVZJVFlfTU9O SVRPUl9DT0VGRiB8ICh3b3JrbG9hZF90eXBlIDw8IDE2KSk7DQotCWlmIChyZXQpIHsNCi0JCXBy X2VycigiWyVzXSBBdHRlbXB0IHRvIFRyYW5zZmVyIFRhYmxlIEZyb20gU01VIEZhaWxlZCEiLCBf X2Z1bmNfXyk7DQotCQlyZXR1cm4gcmV0Ow0KLQl9DQotDQotCXJldHVybiByZXQ7DQotfQ0KLQ0K LXN0YXRpYyBpbnQgc211X3YxMV8wX2dldF9hY3Rpdml0eV9tb25pdG9yX2NvZWZmKHN0cnVjdCBz bXVfY29udGV4dCAqc211LA0KLQkJCQkgICAgICB1aW50OF90ICp0YWJsZSwgdWludDE2X3Qgd29y a2xvYWRfdHlwZSkNCi17DQotCWludCByZXQgPSAwOw0KLQlyZXQgPSBzbXVfc2VuZF9zbWNfbXNn X3dpdGhfcGFyYW0oc211LCBTTVVfTVNHX1NldERyaXZlckRyYW1BZGRySGlnaCwNCi0JCQkJCSAg dXBwZXJfMzJfYml0cyhzbXUtPnNtdV90YWJsZS50YWJsZXNbVEFCTEVfQUNUSVZJVFlfTU9OSVRP Ul9DT0VGRl0ubWNfYWRkcmVzcykpOw0KLQlpZiAocmV0KSB7DQotCQlwcl9lcnIoIlslc10gQXR0 ZW1wdCB0byBTZXQgRHJhbSBBZGRyIEhpZ2ggRmFpbGVkISIsIF9fZnVuY19fKTsNCi0JCXJldHVy biByZXQ7DQotCX0NCi0NCi0JcmV0ID0gc211X3NlbmRfc21jX21zZ193aXRoX3BhcmFtKHNtdSwg U01VX01TR19TZXREcml2ZXJEcmFtQWRkckxvdywNCi0JCQkJCSAgbG93ZXJfMzJfYml0cyhzbXUt PnNtdV90YWJsZS50YWJsZXNbVEFCTEVfQUNUSVZJVFlfTU9OSVRPUl9DT0VGRl0ubWNfYWRkcmVz cykpOw0KLQlpZiAocmV0KSB7DQotCQlwcl9lcnIoIlslc10gQXR0ZW1wdCB0byBTZXQgRHJhbSBB ZGRyIExvdyBGYWlsZWQhIiwgX19mdW5jX18pOw0KLQkJcmV0dXJuIHJldDsNCi0JfQ0KLQ0KLQly ZXQgPSBzbXVfc2VuZF9zbWNfbXNnX3dpdGhfcGFyYW0oc211LCBTTVVfTVNHX1RyYW5zZmVyVGFi bGVTbXUyRHJhbSwNCi0JCQkJCSAgVEFCTEVfQUNUSVZJVFlfTU9OSVRPUl9DT0VGRiB8ICh3b3Jr bG9hZF90eXBlIDw8IDE2KSk7DQotCWlmIChyZXQpIHsNCi0JCXByX2VycigiWyVzXSBBdHRlbXB0 IHRvIFRyYW5zZmVyIFRhYmxlIEZyb20gU01VIEZhaWxlZCEiLCBfX2Z1bmNfXyk7DQotCQlyZXR1 cm4gcmV0Ow0KLQl9DQotDQotCXJldHVybiByZXQ7DQotfQ0KLQ0KIHN0YXRpYyBpbnQgc211X3Yx MV8wX2NvbnZfcG93ZXJfcHJvZmlsZV90b19wcGxpYl93b3JrbG9hZChpbnQgcG93ZXJfcHJvZmls ZSkNCiB7DQogCWludCBwcGxpYl93b3JrbG9hZCA9IDA7DQpAQCAtMTU4NCw5ICsxNTI4LDggQEAg c3RhdGljIGludCBzbXVfdjExXzBfZ2V0X3Bvd2VyX3Byb2ZpbGVfbW9kZShzdHJ1Y3Qgc211X2Nv bnRleHQgKnNtdSwgY2hhciAqYnVmKQ0KIAlmb3IgKGkgPSAwOyBpIDw9IFBQX1NNQ19QT1dFUl9Q Uk9GSUxFX0NVU1RPTTsgaSsrKSB7DQogCQkvKiBjb252IFBQX1NNQ19QT1dFUl9QUk9GSUxFKiB0 byBXT1JLTE9BRF9QUExJQl8qX0JJVCAqLw0KIAkJd29ya2xvYWRfdHlwZSA9IHNtdV92MTFfMF9j b252X3Bvd2VyX3Byb2ZpbGVfdG9fcHBsaWJfd29ya2xvYWQoaSk7DQotCQlyZXN1bHQgPSBzbXVf djExXzBfZ2V0X2FjdGl2aXR5X21vbml0b3JfY29lZmYoc211LA0KLQkJCQkJCQkgICAgICAodWlu dDhfdCAqKSgmYWN0aXZpdHlfbW9uaXRvciksDQotCQkJCQkJCSAgICAgIHdvcmtsb2FkX3R5cGUp Ow0KKwkJcmVzdWx0ID0gc211X3VwZGF0ZV90YWJsZV93aXRoX2FyZyhzbXUsIFRBQkxFX0FDVElW SVRZX01PTklUT1JfQ09FRkYsDQorCQkJCQkJICAgd29ya2xvYWRfdHlwZSwgJmFjdGl2aXR5X21v bml0b3IsIGZhbHNlKTsNCiAJCWlmIChyZXN1bHQpIHsNCiAJCQlwcl9lcnIoIlslc10gRmFpbGVk IHRvIGdldCBhY3Rpdml0eSBtb25pdG9yISIsIF9fZnVuY19fKTsNCiAJCQlyZXR1cm4gcmVzdWx0 Ow0KQEAgLTE2NTgsNyArMTYwMSw3IEBAIHN0YXRpYyBpbnQgc211X3YxMV8wX2dldF9wb3dlcl9w cm9maWxlX21vZGUoc3RydWN0IHNtdV9jb250ZXh0ICpzbXUsIGNoYXIgKmJ1ZikNCiBzdGF0aWMg aW50IHNtdV92MTFfMF9zZXRfcG93ZXJfcHJvZmlsZV9tb2RlKHN0cnVjdCBzbXVfY29udGV4dCAq c211LCBsb25nICppbnB1dCwgdWludDMyX3Qgc2l6ZSkNCiB7DQogCURwbUFjdGl2aXR5TW9uaXRv ckNvZWZmSW50X3QgYWN0aXZpdHlfbW9uaXRvcjsNCi0JaW50IHdvcmtsb2FkX3R5cGUsIHJldCA9 IDA7DQorCWludCB3b3JrbG9hZF90eXBlID0gMCwgcmV0ID0gMDsNCiANCiAJc211LT5wb3dlcl9w cm9maWxlX21vZGUgPSBpbnB1dFtzaXplXTsNCiANCkBAIC0xNjY4LDkgKzE2MTEsOCBAQCBzdGF0 aWMgaW50IHNtdV92MTFfMF9zZXRfcG93ZXJfcHJvZmlsZV9tb2RlKHN0cnVjdCBzbXVfY29udGV4 dCAqc211LCBsb25nICppbnB1dA0KIAl9DQogDQogCWlmIChzbXUtPnBvd2VyX3Byb2ZpbGVfbW9k ZSA9PSBQUF9TTUNfUE9XRVJfUFJPRklMRV9DVVNUT00pIHsNCi0JCXJldCA9IHNtdV92MTFfMF9n ZXRfYWN0aXZpdHlfbW9uaXRvcl9jb2VmZihzbXUsDQotCQkJCQkJCSAgICh1aW50OF90ICopKCZh Y3Rpdml0eV9tb25pdG9yKSwNCi0JCQkJCQkJICAgV09SS0xPQURfUFBMSUJfQ1VTVE9NX0JJVCk7 DQorCQlyZXQgPSBzbXVfdXBkYXRlX3RhYmxlX3dpdGhfYXJnKHNtdSwgVEFCTEVfQUNUSVZJVFlf TU9OSVRPUl9DT0VGRiwNCisJCQkJCQl3b3JrbG9hZF90eXBlLCAmYWN0aXZpdHlfbW9uaXRvciwg ZmFsc2UpOw0KIAkJaWYgKHJldCkgew0KIAkJCXByX2VycigiWyVzXSBGYWlsZWQgdG8gZ2V0IGFj dGl2aXR5IG1vbml0b3IhIiwgX19mdW5jX18pOw0KIAkJCXJldHVybiByZXQ7DQpAQCAtMTcyMyw5 ICsxNjY1LDggQEAgc3RhdGljIGludCBzbXVfdjExXzBfc2V0X3Bvd2VyX3Byb2ZpbGVfbW9kZShz dHJ1Y3Qgc211X2NvbnRleHQgKnNtdSwgbG9uZyAqaW5wdXQNCiAJCQlicmVhazsNCiAJCX0NCiAN Ci0JCXJldCA9IHNtdV92MTFfMF9zZXRfYWN0aXZpdHlfbW9uaXRvcl9jb2VmZihzbXUsDQotCQkJ CQkJCSAgICh1aW50OF90ICopKCZhY3Rpdml0eV9tb25pdG9yKSwNCi0JCQkJCQkJICAgV09SS0xP QURfUFBMSUJfQ1VTVE9NX0JJVCk7DQorCQlyZXQgPSBzbXVfdXBkYXRlX3RhYmxlX3dpdGhfYXJn KHNtdSwgVEFCTEVfQUNUSVZJVFlfTU9OSVRPUl9DT0VGRiwNCisJCQkJCQlXT1JLTE9BRF9QUExJ Ql9DT01QVVRFX0JJVCwgJmFjdGl2aXR5X21vbml0b3IsIHRydWUpOw0KIAkJaWYgKHJldCkgew0K IAkJCXByX2VycigiWyVzXSBGYWlsZWQgdG8gc2V0IGFjdGl2aXR5IG1vbml0b3IhIiwgX19mdW5j X18pOw0KIAkJCXJldHVybiByZXQ7DQpAQCAtMTk5NCw4ICsxOTM1LDYgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBzbXVfZnVuY3Mgc211X3YxMV8wX2Z1bmNzID0gew0KIAkuZ2V0X3NjbGsgPSBzbXVf djExXzBfZHBtX2dldF9zY2xrLA0KIAkuZ2V0X21jbGsgPSBzbXVfdjExXzBfZHBtX2dldF9tY2xr LA0KIAkuc2V0X29kOF9kZWZhdWx0X3NldHRpbmdzID0gc211X3YxMV8wX3NldF9vZDhfZGVmYXVs dF9zZXR0aW5ncywNCi0JLmdldF9hY3Rpdml0eV9tb25pdG9yX2NvZWZmID0gc211X3YxMV8wX2dl dF9hY3Rpdml0eV9tb25pdG9yX2NvZWZmLA0KLQkuc2V0X2FjdGl2aXR5X21vbml0b3JfY29lZmYg PSBzbXVfdjExXzBfc2V0X2FjdGl2aXR5X21vbml0b3JfY29lZmYsDQogCS5jb252X3Bvd2VyX3By b2ZpbGVfdG9fcHBsaWJfd29ya2xvYWQgPSBzbXVfdjExXzBfY29udl9wb3dlcl9wcm9maWxlX3Rv X3BwbGliX3dvcmtsb2FkLA0KIAkuZ2V0X3Bvd2VyX3Byb2ZpbGVfbW9kZSA9IHNtdV92MTFfMF9n ZXRfcG93ZXJfcHJvZmlsZV9tb2RlLA0KIAkuc2V0X3Bvd2VyX3Byb2ZpbGVfbW9kZSA9IHNtdV92 MTFfMF9zZXRfcG93ZXJfcHJvZmlsZV9tb2RlLA0KLS0gDQoyLjIxLjANCg0KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QK YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4