Received: from eggs.gnu.org ([209.51.188.92]:39601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDQXu-0001o5-TO for qemu-devel@nongnu.org; Mon, 08 Apr 2019 05:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDQKb-0007gs-F9 for qemu-devel@nongnu.org; Mon, 08 Apr 2019 05:12:46 -0400 Date: Mon, 8 Apr 2019 11:04:48 +0200 From: Cornelia Huck Message-ID: <20190408110448.4ac62234.cohuck@redhat.com> In-Reply-To: <9223e19f-878f-636e-2c48-6d9e47485a65@redhat.com> References: <20190408083627.7479-1-armbru@redhat.com> <20190408083627.7479-10-armbru@redhat.com> <9223e19f-878f-636e-2c48-6d9e47485a65@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Thomas Huth , qemu-devel@nongnu.org, qemu-s390x@nongnu.org On Mon, 8 Apr 2019 10:39:40 +0200 Thomas Huth wrote: > On 08/04/2019 10.36, Markus Armbruster wrote: > > kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns > > -ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by > > ioctl(). Its caller s390_cpu_virt_mem_rw() recovers from both > > failures. > > > > kvm_s390_mem_op() prints "KVM_S390_MEM_OP failed" with error_printf() > > in the latter failure mode. Since this is obviously a warning, use > > warn_report(). > > > > Perhaps the reporting should be left to the caller. It could warn on > > failure other than -ENOSYS. > > > > Cc: Thomas Huth > > Cc: qemu-s390x@nongnu.org > > Signed-off-by: Markus Armbruster > > --- > > target/s390x/kvm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > > index 19530fb94e..2c6e35b5aa 100644 > > --- a/target/s390x/kvm.c > > +++ b/target/s390x/kvm.c > > @@ -782,7 +782,7 @@ int kvm_s390_mem_op(S390CPU *cpu, vaddr addr, uint8_t ar, void *hostbuf, > > > > ret = kvm_vcpu_ioctl(CPU(cpu), KVM_S390_MEM_OP, &mem_op); > > if (ret < 0) { > > - error_printf("KVM_S390_MEM_OP failed: %s\n", strerror(-ret)); > > + warn_report("KVM_S390_MEM_OP failed: %s", strerror(-ret)); > > } > > return ret; > > } > > > > Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck (Markus, I think you wanted to take this?)