From: guro at fb.com (Roman Gushchin) Date: Mon, 8 Apr 2019 21:46:33 +0000 Subject: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control() In-Reply-To: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org> References: <20190328025659.25684-1-guro@fb.com> <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org> Message-ID: <20190408214628.GA14748@castle> On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote: > On 3/27/19 8:56 PM, Roman Gushchin wrote: > > Dan reported, that cleanup path in test_memcg_subtree_control() > > triggers a static checker warning: > > ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ > > test_memcg_subtree_control() > > error: uninitialized symbol 'child2'. > > > > Fix this by initializing child2 and parent2 variables and > > split the cleanup path into few stages. > > > > Signed-off-by: Roman Gushchin > > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests") > > Reported-by: Dan Carpenter > > Cc: Dan Carpenter > > Cc: Shuah Khan (Samsung OSG) > > Cc: Mike Rapoport > > > From and Signed-off don't match. Please fix it and resend the patch. Done. Thank you! Roman