Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/5] usb: gadget: udc: lpc32xx: simplify probe From: Alexandre Belloni Message-Id: <20190409120908.12079-2-alexandre.belloni@bootlin.com> Date: Tue, 9 Apr 2019 14:09:04 +0200 To: Felipe Balbi , Vladimir Zapolskiy Cc: Greg Kroah-Hartman , Sylvain Lemieux , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni List-ID: U2ltcGxpZnkgLnByb2JlIGFuZCAucmVtb3ZlIGJ5IHVzaW5nIGRldm0gbWFuYWdlZCBhbGxvY2F0 aW9ucyBhbmQgcmVxdWVzdHMuCgpTaWduZWQtb2ZmLWJ5OiBBbGV4YW5kcmUgQmVsbG9uaSA8YWxl eGFuZHJlLmJlbGxvbmlAYm9vdGxpbi5jb20+Ci0tLQogZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9s cGMzMnh4X3VkYy5jIHwgOTMgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDY4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdXNiL2dhZGdldC91ZGMvbHBjMzJ4eF91ZGMuYyBiL2RyaXZlcnMvdXNiL2dhZGdldC91 ZGMvbHBjMzJ4eF91ZGMuYwppbmRleCBiMDc4MTc3MTcwNGUuLjU1NDZjYjUwOTA4NSAxMDA2NDQK LS0tIGEvZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9scGMzMnh4X3VkYy5jCisrKyBiL2RyaXZlcnMv dXNiL2dhZGdldC91ZGMvbHBjMzJ4eF91ZGMuYwpAQCAtMTI5LDggKzEyOSw2IEBAIHN0cnVjdCBs cGMzMnh4X3VkYyB7CiAKIAkvKiBCb2FyZCBhbmQgZGV2aWNlIHNwZWNpZmljICovCiAJc3RydWN0 IGxwYzMyeHhfdXNiZF9jZmcJKmJvYXJkOwotCXUzMgkJCWlvX3Bfc3RhcnQ7Ci0JdTMyCQkJaW9f cF9zaXplOwogCXZvaWQgX19pb21lbQkJKnVkcF9iYXNlYWRkcjsKIAlpbnQJCQl1ZHBfaXJxWzRd OwogCXN0cnVjdCBjbGsJCSp1c2Jfc2x2X2NsazsKQEAgLTI5OTksNyArMjk5Nyw3IEBAIHN0YXRp YyBpbnQgbHBjMzJ4eF91ZGNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlk bWFfYWRkcl90IGRtYV9oYW5kbGU7CiAJc3RydWN0IGRldmljZV9ub2RlICppc3AxMzAxX25vZGU7 CiAKLQl1ZGMgPSBrbWVtZHVwKCZjb250cm9sbGVyX3RlbXBsYXRlLCBzaXplb2YoKnVkYyksIEdG UF9LRVJORUwpOworCXVkYyA9IGRldm1fa21lbWR1cChkZXYsICZjb250cm9sbGVyX3RlbXBsYXRl LCBzaXplb2YoKnVkYyksIEdGUF9LRVJORUwpOwogCWlmICghdWRjKQogCQlyZXR1cm4gLUVOT01F TTsKIApAQCAtMzAyMiw4ICszMDIwLDcgQEAgc3RhdGljIGludCBscGMzMnh4X3VkY19wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCiAJdWRjLT5pc3AxMzAxX2kyY19jbGllbnQg PSBpc3AxMzAxX2dldF9jbGllbnQoaXNwMTMwMV9ub2RlKTsKIAlpZiAoIXVkYy0+aXNwMTMwMV9p MmNfY2xpZW50KSB7Ci0JCXJldHZhbCA9IC1FUFJPQkVfREVGRVI7Ci0JCWdvdG8gcGh5X2ZhaWw7 CisJCXJldHVybiAtRVBST0JFX0RFRkVSOwogCX0KIAogCWRldl9pbmZvKHVkYy0+ZGV2LCAiSVNQ MTMwMSBJMkMgZGV2aWNlIGF0IGFkZHJlc3MgMHgleFxuIiwKQEAgLTMwMzIsNyArMzAyOSw3IEBA IHN0YXRpYyBpbnQgbHBjMzJ4eF91ZGNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAlwZGV2LT5kZXYuZG1hX21hc2sgPSAmbHBjMzJ4eF91c2JkX2RtYW1hc2s7CiAJcmV0dmFs ID0gZG1hX3NldF9jb2hlcmVudF9tYXNrKCZwZGV2LT5kZXYsIERNQV9CSVRfTUFTSygzMikpOwog CWlmIChyZXR2YWwpCi0JCWdvdG8gcmVzb3VyY2VfZmFpbDsKKwkJcmV0dXJuIHJldHZhbDsKIAog CXVkYy0+Ym9hcmQgPSAmbHBjMzJ4eF91c2JkZGF0YTsKIApAQCAtMzA0NSwxMCArMzA0Miw4IEBA IHN0YXRpYyBpbnQgbHBjMzJ4eF91ZGNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAkgKiAgSU9SRVNPVVJDRV9JUlEsIFVTQiB0cmFuc2NlaXZlciBpbnRlcnJ1cHQgbnVtYmVy CiAJICovCiAJcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVN LCAwKTsKLQlpZiAoIXJlcykgewotCQlyZXR2YWwgPSAtRU5YSU87Ci0JCWdvdG8gcmVzb3VyY2Vf ZmFpbDsKLQl9CisJaWYgKCFyZXMpCisJCXJldHVybiAtRU5YSU87CiAKIAlzcGluX2xvY2tfaW5p dCgmdWRjLT5sb2NrKTsKIApAQCAtMzA1OCwzOSArMzA1MywyOCBAQCBzdGF0aWMgaW50IGxwYzMy eHhfdWRjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJCWlmICh1ZGMtPnVk cF9pcnFbaV0gPCAwKSB7CiAJCQlkZXZfZXJyKHVkYy0+ZGV2LAogCQkJCSJpcnEgcmVzb3VyY2Ug JWQgbm90IGF2YWlsYWJsZSFcbiIsIGkpOwotCQkJcmV0dmFsID0gdWRjLT51ZHBfaXJxW2ldOwot CQkJZ290byBpcnFfZmFpbDsKKwkJCXJldHVybiB1ZGMtPnVkcF9pcnFbaV07CiAJCX0KIAl9CiAK LQl1ZGMtPmlvX3Bfc3RhcnQgPSByZXMtPnN0YXJ0OwotCXVkYy0+aW9fcF9zaXplID0gcmVzb3Vy Y2Vfc2l6ZShyZXMpOwotCWlmICghcmVxdWVzdF9tZW1fcmVnaW9uKHVkYy0+aW9fcF9zdGFydCwg dWRjLT5pb19wX3NpemUsIGRyaXZlcl9uYW1lKSkgewotCQlkZXZfZXJyKHVkYy0+ZGV2LCAic29t ZW9uZSdzIHVzaW5nIFVEQyBtZW1vcnlcbiIpOwotCQlyZXR2YWwgPSAtRUJVU1k7Ci0JCWdvdG8g cmVxdWVzdF9tZW1fcmVnaW9uX2ZhaWw7Ci0JfQotCi0JdWRjLT51ZHBfYmFzZWFkZHIgPSBpb3Jl bWFwKHVkYy0+aW9fcF9zdGFydCwgdWRjLT5pb19wX3NpemUpOworCXVkYy0+dWRwX2Jhc2VhZGRy ID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKIAlpZiAoIXVkYy0+dWRwX2Jhc2Vh ZGRyKSB7Ci0JCXJldHZhbCA9IC1FTk9NRU07CiAJCWRldl9lcnIodWRjLT5kZXYsICJJTyBtYXAg ZmFpbHVyZVxuIik7Ci0JCWdvdG8gaW9fbWFwX2ZhaWw7CisJCXJldHVybiAtRU5PTUVNOwogCX0K IAogCS8qIEdldCBVU0IgZGV2aWNlIGNsb2NrICovCi0JdWRjLT51c2Jfc2x2X2NsayA9IGNsa19n ZXQoJnBkZXYtPmRldiwgTlVMTCk7CisJdWRjLT51c2Jfc2x2X2NsayA9IGRldm1fY2xrX2dldCgm cGRldi0+ZGV2LCBOVUxMKTsKIAlpZiAoSVNfRVJSKHVkYy0+dXNiX3Nsdl9jbGspKSB7CiAJCWRl dl9lcnIodWRjLT5kZXYsICJmYWlsZWQgdG8gYWNxdWlyZSBVU0IgZGV2aWNlIGNsb2NrXG4iKTsK LQkJcmV0dmFsID0gUFRSX0VSUih1ZGMtPnVzYl9zbHZfY2xrKTsKLQkJZ290byB1c2JfY2xrX2dl dF9mYWlsOworCQlyZXR1cm4gUFRSX0VSUih1ZGMtPnVzYl9zbHZfY2xrKTsKIAl9CiAKIAkvKiBF bmFibGUgVVNCIGRldmljZSBjbG9jayAqLwogCXJldHZhbCA9IGNsa19wcmVwYXJlX2VuYWJsZSh1 ZGMtPnVzYl9zbHZfY2xrKTsKIAlpZiAocmV0dmFsIDwgMCkgewogCQlkZXZfZXJyKHVkYy0+ZGV2 LCAiZmFpbGVkIHRvIHN0YXJ0IFVTQiBkZXZpY2UgY2xvY2tcbiIpOwotCQlnb3RvIHVzYl9jbGtf ZW5hYmxlX2ZhaWw7CisJCXJldHVybiByZXR2YWw7CiAJfQogCiAJLyogU2V0dXAgZGVmZXJyZWQg d29ya3F1ZXVlIGRhdGEgKi8KQEAgLTMxMzQsMzcgKzMxMTgsMzcgQEAgc3RhdGljIGludCBscGMz Mnh4X3VkY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCiAJLyogUmVxdWVz dCBJUlFzIC0gbG93IGFuZCBoaWdoIHByaW9yaXR5IFVTQiBkZXZpY2UgSVJRcyBhcmUgcm91dGVk IHRvCiAJICogdGhlIHNhbWUgaGFuZGxlciwgd2hpbGUgdGhlIERNQSBpbnRlcnJ1cHQgaXMgcm91 dGVkIGVsc2V3aGVyZSAqLwotCXJldHZhbCA9IHJlcXVlc3RfaXJxKHVkYy0+dWRwX2lycVtJUlFf VVNCX0xQXSwgbHBjMzJ4eF91c2JfbHBfaXJxLAotCQkJICAgICAwLCAidWRjX2xwIiwgdWRjKTsK KwlyZXR2YWwgPSBkZXZtX3JlcXVlc3RfaXJxKGRldiwgdWRjLT51ZHBfaXJxW0lSUV9VU0JfTFBd LAorCQkJCSAgbHBjMzJ4eF91c2JfbHBfaXJxLCAwLCAidWRjX2xwIiwgdWRjKTsKIAlpZiAocmV0 dmFsIDwgMCkgewogCQlkZXZfZXJyKHVkYy0+ZGV2LCAiTFAgcmVxdWVzdCBpcnEgJWQgZmFpbGVk XG4iLAogCQkJdWRjLT51ZHBfaXJxW0lSUV9VU0JfTFBdKTsKLQkJZ290byBpcnFfbHBfZmFpbDsK KwkJZ290byBpcnFfcmVxX2ZhaWw7CiAJfQotCXJldHZhbCA9IHJlcXVlc3RfaXJxKHVkYy0+dWRw X2lycVtJUlFfVVNCX0hQXSwgbHBjMzJ4eF91c2JfaHBfaXJxLAotCQkJICAgICAwLCAidWRjX2hw IiwgdWRjKTsKKwlyZXR2YWwgPSBkZXZtX3JlcXVlc3RfaXJxKGRldiwgdWRjLT51ZHBfaXJxW0lS UV9VU0JfSFBdLAorCQkJCSAgbHBjMzJ4eF91c2JfaHBfaXJxLCAwLCAidWRjX2hwIiwgdWRjKTsK IAlpZiAocmV0dmFsIDwgMCkgewogCQlkZXZfZXJyKHVkYy0+ZGV2LCAiSFAgcmVxdWVzdCBpcnEg JWQgZmFpbGVkXG4iLAogCQkJdWRjLT51ZHBfaXJxW0lSUV9VU0JfSFBdKTsKLQkJZ290byBpcnFf aHBfZmFpbDsKKwkJZ290byBpcnFfcmVxX2ZhaWw7CiAJfQogCi0JcmV0dmFsID0gcmVxdWVzdF9p cnEodWRjLT51ZHBfaXJxW0lSUV9VU0JfREVWRE1BXSwKLQkJCSAgICAgbHBjMzJ4eF91c2JfZGV2 ZG1hX2lycSwgMCwgInVkY19kbWEiLCB1ZGMpOworCXJldHZhbCA9IGRldm1fcmVxdWVzdF9pcnEo ZGV2LCB1ZGMtPnVkcF9pcnFbSVJRX1VTQl9ERVZETUFdLAorCQkJCSAgbHBjMzJ4eF91c2JfZGV2 ZG1hX2lycSwgMCwgInVkY19kbWEiLCB1ZGMpOwogCWlmIChyZXR2YWwgPCAwKSB7CiAJCWRldl9l cnIodWRjLT5kZXYsICJERVYgcmVxdWVzdCBpcnEgJWQgZmFpbGVkXG4iLAogCQkJdWRjLT51ZHBf aXJxW0lSUV9VU0JfREVWRE1BXSk7Ci0JCWdvdG8gaXJxX2Rldl9mYWlsOworCQlnb3RvIGlycV9y ZXFfZmFpbDsKIAl9CiAKIAkvKiBUaGUgdHJhbnNjZWl2ZXIgaW50ZXJydXB0IGlzIHVzZWQgZm9y IFZCVVMgZGV0ZWN0aW9uIGFuZCB3aWxsCiAJICAga2ljayBvZmYgdGhlIFZCVVMgaGFuZGxlciBm dW5jdGlvbiAqLwotCXJldHZhbCA9IHJlcXVlc3RfaXJxKHVkYy0+dWRwX2lycVtJUlFfVVNCX0FU WF0sIGxwYzMyeHhfdXNiX3ZidXNfaXJxLAotCQkJICAgICAwLCAidWRjX290ZyIsIHVkYyk7CisJ cmV0dmFsID0gZGV2bV9yZXF1ZXN0X2lycShkZXYsIHVkYy0+dWRwX2lycVtJUlFfVVNCX0FUWF0s CisJCQkJICBscGMzMnh4X3VzYl92YnVzX2lycSwgMCwgInVkY19vdGciLCB1ZGMpOwogCWlmIChy ZXR2YWwgPCAwKSB7CiAJCWRldl9lcnIodWRjLT5kZXYsICJWQlVTIHJlcXVlc3QgaXJxICVkIGZh aWxlZFxuIiwKIAkJCXVkYy0+dWRwX2lycVtJUlFfVVNCX0FUWF0pOwotCQlnb3RvIGlycV94Y3Zy X2ZhaWw7CisJCWdvdG8gaXJxX3JlcV9mYWlsOwogCX0KIAogCS8qIEluaXRpYWxpemUgd2FpdCBx dWV1ZSAqLwpAQCAtMzE5MCwzMiArMzE3NCwxNSBAQCBzdGF0aWMgaW50IGxwYzMyeHhfdWRjX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAJcmV0dXJuIDA7CiAKIGFkZF9nYWRn ZXRfZmFpbDoKLQlmcmVlX2lycSh1ZGMtPnVkcF9pcnFbSVJRX1VTQl9BVFhdLCB1ZGMpOwotaXJx X3hjdnJfZmFpbDoKLQlmcmVlX2lycSh1ZGMtPnVkcF9pcnFbSVJRX1VTQl9ERVZETUFdLCB1ZGMp OwotaXJxX2Rldl9mYWlsOgotCWZyZWVfaXJxKHVkYy0+dWRwX2lycVtJUlFfVVNCX0hQXSwgdWRj KTsKLWlycV9ocF9mYWlsOgotCWZyZWVfaXJxKHVkYy0+dWRwX2lycVtJUlFfVVNCX0xQXSwgdWRj KTsKLWlycV9scF9mYWlsOgoraXJxX3JlcV9mYWlsOgogCWRtYV9wb29sX2Rlc3Ryb3kodWRjLT5k ZF9jYWNoZSk7CiBkbWFfYWxsb2NfZmFpbDoKIAlkbWFfZnJlZV9jb2hlcmVudCgmcGRldi0+ZGV2 LCBVRENBX0JVRkZfU0laRSwKIAkJCSAgdWRjLT51ZGNhX3ZfYmFzZSwgdWRjLT51ZGNhX3BfYmFz ZSk7CiBpMmNfZmFpbDoKIAljbGtfZGlzYWJsZV91bnByZXBhcmUodWRjLT51c2Jfc2x2X2Nsayk7 Ci11c2JfY2xrX2VuYWJsZV9mYWlsOgotCWNsa19wdXQodWRjLT51c2Jfc2x2X2Nsayk7Ci11c2Jf Y2xrX2dldF9mYWlsOgotCWlvdW5tYXAodWRjLT51ZHBfYmFzZWFkZHIpOwotaW9fbWFwX2ZhaWw6 Ci0JcmVsZWFzZV9tZW1fcmVnaW9uKHVkYy0+aW9fcF9zdGFydCwgdWRjLT5pb19wX3NpemUpOwog CWRldl9lcnIodWRjLT5kZXYsICIlcyBwcm9iZSBmYWlsZWQsICVkXG4iLCBkcml2ZXJfbmFtZSwg cmV0dmFsKTsKLXJlcXVlc3RfbWVtX3JlZ2lvbl9mYWlsOgotaXJxX2ZhaWw6Ci1yZXNvdXJjZV9m YWlsOgotcGh5X2ZhaWw6Ci0Ja2ZyZWUodWRjKTsKKwogCXJldHVybiByZXR2YWw7CiB9CiAKQEAg LTMyMzEsMjQgKzMxOTgsMTQgQEAgc3RhdGljIGludCBscGMzMnh4X3VkY19yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAl1ZGNfZGlzYWJsZSh1ZGMpOwogCXB1bGx1cCh1ZGMs IDApOwogCi0JZnJlZV9pcnEodWRjLT51ZHBfaXJxW0lSUV9VU0JfQVRYXSwgdWRjKTsKLQogCWRl dmljZV9pbml0X3dha2V1cCgmcGRldi0+ZGV2LCAwKTsKIAlyZW1vdmVfZGVidWdfZmlsZSh1ZGMp OwogCiAJZG1hX3Bvb2xfZGVzdHJveSh1ZGMtPmRkX2NhY2hlKTsKIAlkbWFfZnJlZV9jb2hlcmVu dCgmcGRldi0+ZGV2LCBVRENBX0JVRkZfU0laRSwKIAkJCSAgdWRjLT51ZGNhX3ZfYmFzZSwgdWRj LT51ZGNhX3BfYmFzZSk7Ci0JZnJlZV9pcnEodWRjLT51ZHBfaXJxW0lSUV9VU0JfREVWRE1BXSwg dWRjKTsKLQlmcmVlX2lycSh1ZGMtPnVkcF9pcnFbSVJRX1VTQl9IUF0sIHVkYyk7Ci0JZnJlZV9p cnEodWRjLT51ZHBfaXJxW0lSUV9VU0JfTFBdLCB1ZGMpOwogCiAJY2xrX2Rpc2FibGVfdW5wcmVw YXJlKHVkYy0+dXNiX3Nsdl9jbGspOwotCWNsa19wdXQodWRjLT51c2Jfc2x2X2Nsayk7Ci0KLQlp b3VubWFwKHVkYy0+dWRwX2Jhc2VhZGRyKTsKLQlyZWxlYXNlX21lbV9yZWdpb24odWRjLT5pb19w X3N0YXJ0LCB1ZGMtPmlvX3Bfc2l6ZSk7Ci0Ja2ZyZWUodWRjKTsKIAogCXJldHVybiAwOwogfQo=