Received: from eggs.gnu.org ([209.51.188.92]:53875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDsDD-0003Vi-7G for qemu-devel@nongnu.org; Tue, 09 Apr 2019 10:59:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDsDC-0007j2-1D for qemu-devel@nongnu.org; Tue, 09 Apr 2019 10:58:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45306) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDsDB-0007h3-P5 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 10:58:57 -0400 Date: Tue, 9 Apr 2019 16:58:45 +0200 From: Igor Mammedov Message-ID: <20190409165845.48abd4ec@redhat.com> In-Reply-To: <20190409134536.15548-3-philmd@redhat.com> References: <20190409134536.15548-1-philmd@redhat.com> <20190409134536.15548-3-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Laszlo Ersek , qemu-devel@nongnu.org, Olaf Hering , Gerd Hoffmann , "Michael S . Tsirkin" , Paolo Bonzini On Tue, 9 Apr 2019 15:45:36 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > Since commit f590a812c210 we build the EDK2 EfiRom utility > unconditionally. >=20 > Some distributions require to use extra compiler/linker flags, > i.e. SUSE which enforces the PIE protection (see [*]). >=20 > EDK2 build tools already provide a set of variables for that, > use them to allow the caller to easily inject compiler/linker > options.. >=20 > Now build scripts can pass extra options, example: >=20 > $ make -C roms \ > EDK2_BASETOOLS_OPTFLAGS=3D'-fPIE' \ > efirom >=20 > [*] https://lists.opensuse.org/opensuse-factory/2017-06/msg00403.html >=20 > Reported-by: Olaf Hering > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Igor Mammedov > --- > roms/Makefile | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/roms/Makefile b/roms/Makefile > index d28252dafdf..1ff78b63bb3 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -120,8 +120,21 @@ build-efi-roms: build-pxe-roms > $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ > $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) > =20 > +# Build scripts can pass compiler/linker flags to the EDK2 build tools > +# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and > +# EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. > +# > +# Example: > +# > +# make -C roms \ > +# EDK2_BASETOOLS_OPTFLAGS=3D'...' \ > +# EDK2_BASETOOLS_LDFLAGS=3D'...' \ > +# efirom > +# > $(EDK2_EFIROM): > - $(MAKE) -C edk2/BaseTools > + $(MAKE) -C edk2/BaseTools \ > + EXTRA_OPTFLAGS=3D'$(EDK2_BASETOOLS_OPTFLAGS)' \ > + EXTRA_LDFLAGS=3D'$(EDK2_BASETOOLS_LDFLAGS)' > =20 > slof: > $(MAKE) -C SLOF CROSS=3D$(powerpc64_cross_prefix) qemu