Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9446BC10F0E for ; Tue, 9 Apr 2019 19:44:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 605992077C for ; Tue, 9 Apr 2019 19:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbfDITof (ORCPT ); Tue, 9 Apr 2019 15:44:35 -0400 Received: from lb2-smtp-cloud8.xs4all.net ([194.109.24.25]:38526 "EHLO lb2-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfDITof (ORCPT ); Tue, 9 Apr 2019 15:44:35 -0400 Received: from localhost.localdomain ([217.27.238.190]) by smtp-cloud8.xs4all.net with ESMTPA id DwfXhkttUUjKfDwfYheje0; Tue, 09 Apr 2019 21:44:33 +0200 From: Antony Antony To: netdev@vger.kernel.org Cc: Stephen Hemminger , Matt Ellison , Antony Antony Subject: [PATCH] ip: xfrm if_id -ve value is error Date: Tue, 9 Apr 2019 21:44:25 +0200 Message-Id: <20190409194425.38063-1-antony@phenome.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfAwZlX3zonUMUAWEzQo8qUlvVck7Cq2WCM/xelLcobO1pP7tzc2TT/zwdtmnOJ5gziSAwPzXP3hWS0vAy2RGTCKjNCWXoEePhCJyrI1jNtLzL9IAvLr8 fFq/HWx+nJ/2BgAYPOdsO7CgSjSUcjL6PVTwl26r13Nph95kclXfWsn7lv23BY+/t8Kbmm71KU1EK6mURAfEA4rJhHlJ0GpIVuvDFxi3vbobwdxiCJxUNIhG FOxd9WQeVjlzkvJd5X6D11DtmTCJxG+WrljVkkqA4uk= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org if_id is u32, error on -ve values instead of setting to 0 after : ip link add ipsec0 type xfrm dev enp0s5 if_id -10 Error: argument "-10" is wrong: if_id value is invalid before : ip link add ipsec0 type xfrm dev enp0s5 if_id -10 ip -d link show dev ipsec0 67: ipsec0@enp0s5: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/none 00:1c:42:55:d6:ab brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500 xfrm if_id 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 Fixes: 286446c1e8c error on -ve if_id Signed-off-by: Antony Antony --- ip/link_xfrm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ip/link_xfrm.c b/ip/link_xfrm.c index 79a902fd..7f66bad6 100644 --- a/ip/link_xfrm.c +++ b/ip/link_xfrm.c @@ -34,7 +34,9 @@ static int xfrm_parse_opt(struct link_util *lu, int argc, char **argv, exit(nodev(*argv)); } else if (!matches(*argv, "if_id")) { NEXT_ARG(); - if (!get_u32(&if_id, *argv, 0)) + if (get_u32(&if_id, *argv, 0)) + invarg("if_id value is invalid", *argv); + else addattr32(n, 1024, IFLA_XFRM_IF_ID, if_id); } else { xfrm_print_help(lu, argc, argv, stderr); -- 2.17.2