From: Sam Ravnborg Subject: Re: [PATCH] drm/bochs: use simple display pipe Date: Wed, 10 Apr 2019 23:22:40 +0200 Message-ID: <20190410212240.GA31691@ravnborg.org> References: <20190410074828.10296-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190410074828.10296-1-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , open list , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" List-Id: dri-devel@lists.freedesktop.org Hi Gerd. > > #include > > @@ -69,9 +70,8 @@ struct bochs_device { > struct edid *edid; > > /* drm */ > - struct drm_device *dev; > - struct drm_crtc crtc; > - struct drm_encoder encoder; > + struct drm_device *dev; > + struct drm_simple_display_pipe pipe; > struct drm_connector connector; Have you considered to embed drm_device in the bochs_device struct? This is the new way to do it. This should likely be a follow-up patch... Rest of the patch looked good. Did not do a proper review but you can add my: Acked-by: Sam Ravnborg Sam