From: Thomas Petazzoni Date: Thu, 11 Apr 2019 08:25:28 +0200 Subject: [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf In-Reply-To: <20190411082218.2503be2d@windsurf.home> References: <20190409131754.24516-1-giulio.benetti@micronovasrl.com> <20190411082218.2503be2d@windsurf.home> Message-ID: <20190411082528.3152fca9@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 11 Apr 2019 08:22:18 +0200 Thomas Petazzoni wrote: > We don't typically re-use the target dependencies variable for the host > dependencies. So I changed this to = host-pkgconf and applied. An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't do what you think it does: $ cat foo.mk FOO_DEPENDENCIES = host-pkgconf HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES) FOO_DEPENDENCIES += zlib HOST_FOO_DEPENDENCIES += host-zlib all: @echo $(FOO_DEPENDENCIES) @echo $(HOST_FOO_DEPENDENCIES) $ make -f foo.mk host-pkgconf zlib host-pkgconf zlib host-zlib See how HOST_FOO_DEPENDENCIES contains "zlib" ? = assignments are evaluated at the time of use, not at the time of assignment (contrary to := assignments). Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com