Received: from eggs.gnu.org ([209.51.188.92]:38962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEb4b-0003Kt-0l for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEb4W-0000lZ-Rg for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51178) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEb4W-0000kv-Hb for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:00 -0400 From: Markus Armbruster Date: Thu, 11 Apr 2019 16:52:46 +0200 Message-Id: <20190411145256.8614-6-armbru@redhat.com> In-Reply-To: <20190411145256.8614-1-armbru@redhat.com> References: <20190411145256.8614-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 05/15] mips/boston: Report errors with error_report(), not error_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paul Burton , Aleksandar Rikalo Cc: Paul Burton Cc: Aleksandar Rikalo Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/boston.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index e5bab3cadc..a8b29f62f5 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -528,21 +528,21 @@ static void boston_mach_init(MachineState *machine) fw_size =3D load_image_targphys(machine->firmware, 0x1fc00000, 4 * MiB); if (fw_size =3D=3D -1) { - error_printf("unable to load firmware image '%s'\n", + error_report("unable to load firmware image '%s'", machine->firmware); exit(1); } } else if (machine->kernel_filename) { fit_err =3D load_fit(&boston_fit_loader, machine->kernel_filenam= e, s); if (fit_err) { - error_printf("unable to load FIT image\n"); + error_report("unable to load FIT image"); exit(1); } =20 gen_firmware(memory_region_get_ram_ptr(flash) + 0x7c00000, s->kernel_entry, s->fdt_base, is_64b); } else if (!qtest_enabled()) { - error_printf("Please provide either a -kernel or -bios argument\= n"); + error_report("Please provide either a -kernel or -bios argument"= ); exit(1); } } --=20 2.17.2