From: Joerg Roedel Subject: Re: [PATCH] iommu/amd: remove the leftover of bypass support Date: Thu, 11 Apr 2019 17:38:09 +0200 Message-ID: <20190411153809.GG4518@8bytes.org> References: <20190410165014.9932-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190410165014.9932-1-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Apr 10, 2019 at 06:50:14PM +0200, Christoph Hellwig wrote: > The AMD iommu dma_ops are only attached on a per-device basis when an > actual translation is needed. Remove the leftover bypass support which > in parts was already broken (e.g. it always returns 0 from ->map_sg). > > Use the opportunity to remove a few local variables and move assignments > into the declaration line where they were previously separated by the > bypass check. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/amd_iommu.c | 80 +++++++++------------------------------ > 1 file changed, 17 insertions(+), 63 deletions(-) Nice cleanup, applied, thanks!