Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7DC0C10F13 for ; Thu, 11 Apr 2019 16:21:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 878392146F for ; Thu, 11 Apr 2019 16:21:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iHj93nX3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 878392146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o5zhww8B9kcjntKuKAelGIIKR6CrdJqIxpmQ0lm4Am0=; b=iHj93nX39TLRVN F1KintVCnq2WWWr765SBi+r6BWqsWDcjh+vvi43mgawNevD/9J7Tv1tNITV/bA7dKFx+Gx6CG4AOR mfb1eHQGzlOH1k+GQXhMU7IoJ4HTMTo2OWJ1byCFmt6T5M0Z69RqyLB3syaJweSlt3DuYKsF1Z2Nu gh75/f5cqsmjonq/1afMt+zNCEs2xK7R47RR9gQ2c9jXoazgzDPcrPa2jZUbrJA6qX7iq4GfMXP+n io5kDQzOAdUFWmhTm5LVLlOGUQeMWmgBPcxCEd42ZLYg8+P2NL9djqohrygUu+16JFYQuXsFdG6/8 5vqETLiIko86UfJJ/z/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcSU-0000J2-LC; Thu, 11 Apr 2019 16:21:50 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcSS-0000If-2B for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 16:21:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96E3580D; Thu, 11 Apr 2019 09:21:47 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB02D3F59C; Thu, 11 Apr 2019 09:21:46 -0700 (PDT) Date: Thu, 11 Apr 2019 17:21:44 +0100 From: Mark Rutland To: Raphael Gault Subject: Re: [PATCH] arm64: perf_event: Remove wrongfully used inline Message-ID: <20190411162144.GC384@lakrids.cambridge.arm.com> References: <20190411161646.22097-1-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190411161646.22097-1-raphael.gault@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_092148_105170_B75F1175 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2019 at 05:16:46PM +0100, Raphael Gault wrote: > The functions armv8pmu_read_counter() and armv8pmu_write_counter() > are `static inline` while they are only referenced when assigned > to a function pointer field in a `struct arm_pmu` instance. > > The inline keyword is thus counter intuitive and shouldn't be used. > > Signed-off-by: Raphael Gault This looks like a sensible cleanup, so: Acked-by: Mark Rutland Will, I assume you'll pick this up. Thanks, Mark. > --- > arch/arm64/kernel/perf_event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c > index 4addb38bc250..6164d389eed6 100644 > --- a/arch/arm64/kernel/perf_event.c > +++ b/arch/arm64/kernel/perf_event.c > @@ -431,7 +431,7 @@ static inline u64 armv8pmu_read_hw_counter(struct perf_event *event) > return val; > } > > -static inline u64 armv8pmu_read_counter(struct perf_event *event) > +static u64 armv8pmu_read_counter(struct perf_event *event) > { > struct arm_pmu *cpu_pmu = to_arm_pmu(event->pmu); > struct hw_perf_event *hwc = &event->hw; > @@ -468,7 +468,7 @@ static inline void armv8pmu_write_hw_counter(struct perf_event *event, > } > } > > -static inline void armv8pmu_write_counter(struct perf_event *event, u64 value) > +static void armv8pmu_write_counter(struct perf_event *event, u64 value) > { > struct arm_pmu *cpu_pmu = to_arm_pmu(event->pmu); > struct hw_perf_event *hwc = &event->hw; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel