Received: from eggs.gnu.org ([209.51.188.92]:59617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEdtg-00029f-BZ for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEdtf-0007go-5P for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:54:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35584) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEdte-0007fE-Sz for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:53:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DAB43168914 for ; Thu, 11 Apr 2019 17:53:57 +0000 (UTC) From: Thomas Huth Date: Thu, 11 Apr 2019 19:53:45 +0200 Message-Id: <20190411175345.19414-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "Michael S . Tsirkin" Cc: Paolo Bonzini , libvir-list@redhat.com, Eduardo Habkost The old -realtime mlock=3Don|off parameter does exactly the same as the new -overcommit mem-lock=3Don|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option. Signed-off-by: Thomas Huth --- Deprecation has already been suggested last year: https://patchwork.kernel.org/patch/10480963/#22026215 ... but apparently we forgot to really do it. qemu-deprecated.texi | 5 +++++ vl.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..2c45204f3f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,11 @@ backend settings instead of environment variables. To= ease migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options= . =20 +@subsection -realtime (since 4.1) + +The @code{-realtime mlock=3Don|off} argument has been replaced by the +@code{-overcommit mem-lock=3Don|off} argument. + @section QEMU Machine Protocol (QMP) commands =20 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) diff --git a/vl.c b/vl.c index c696ad2a13..d6a2779b70 100644 --- a/vl.c +++ b/vl.c @@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp) } break; case QEMU_OPTION_realtime: + warn_report("'-realtime mlock=3D...' is deprecated, plea= se use " + "'-overcommit mem-lock=3D...' instead"); opts =3D qemu_opts_parse_noisily(qemu_find_opts("realtim= e"), optarg, false); if (!opts) { --=20 2.21.0