From: Thomas Petazzoni Date: Thu, 11 Apr 2019 18:27:16 +0200 Subject: [Buildroot] [PATCH] package/tpm2-totp: blacklist Codesourcery ARM toolchain In-Reply-To: <20190411105906.12289-1-peter@korsgaard.com> References: <20190411105906.12289-1-peter@korsgaard.com> Message-ID: <20190411182716.7865e234@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 11 Apr 2019 12:59:06 +0200 Peter Korsgaard wrote: > Fixes: > http://autobuild.buildroot.net/results/6c9bb17920749409e5a0c3388ccda411c6c7cfb4/ > > tpm2-totp uses _DEFAULT_SOURCE to make the htobe64() macro available, > support for which was only added in glibc 2.20: > > https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fDEFAULT_005fSOURCE > > From glibc 2.20 NEWS: > > * The _BSD_SOURCE and _SVID_SOURCE feature test macros are no longer > supported; they now act the same as _DEFAULT_SOURCE (but generate a > warning). Except for cases where _BSD_SOURCE enabled BSD interfaces that > conflicted with POSIX (support for which was removed in 2.19), the > interfaces those macros enabled remain available when compiling with > _GNU_SOURCE defined, with _DEFAULT_SOURCE defined, or without any feature > test macros defined. > > This could be worked around by defining _BSD_SOURCE for this old toolchain > (cannot be done unconditionally as it generated warnings for modern glibc > versions), but given that platforms using this old toolchain are unlikely to > have a TPM 2.0 and use it for TOTP, simply blacklist it instead. > > Signed-off-by: Peter Korsgaard > --- > package/tpm2-totp/Config.in | 2 ++ > 1 file changed, 2 insertions(+) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com