Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8C6C10F13 for ; Thu, 11 Apr 2019 23:02:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 100B72146F for ; Thu, 11 Apr 2019 23:02:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U4pmd0gr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbfDKXCs (ORCPT ); Thu, 11 Apr 2019 19:02:48 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41533 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbfDKXCs (ORCPT ); Thu, 11 Apr 2019 19:02:48 -0400 Received: by mail-wr1-f67.google.com with SMTP id r4so9409815wrq.8 for ; Thu, 11 Apr 2019 16:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=W05qVvSwhvdYMVbMishv3xrqBbBAgaGH3SHJ3n/1LYU=; b=U4pmd0grpcQVGZ/jM2HhR11NmVjUvuIjzKEjKoqHspw9s1PG87uJY6wBNbUQS3wHAP PbvkiPTOXtJnGhfbMvCTi5Ui7JPqrd+RNkXmjt/r4WiyAufC9MwsFcsSkrDNp7cNT6tU hhGqrg/7HBUH3a36nd/4gb5PFGvIIKF1sU+CSdsQdWiy4nOFDkpnAbh468/WThfI+bBM kuFq5e+ElfujSvaXiAVGet4kvL4b3Br1nz+U6ou0oemSj6Q6ne71gYy2/+M5cnC22eSP fQGkyyatTuN6XqZcs7GZg8YGdDz7dUO6GBuThXSBJl9PnFiVwjR5BFblm9WdlQ81BAxD SRrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=W05qVvSwhvdYMVbMishv3xrqBbBAgaGH3SHJ3n/1LYU=; b=LdqKMdzWv+8gFXjvzmOpMDjrTSgiVO+RKFZkTdAc03+LzQYNb9fBUOnUNYR9hmbSNU epc5o+eouWiYHgyhHIQxz/aL52ZeFRfiRnHC3FzWXn+lbzBO8NJibp3YJ6wNzgeFPC2q 76Z27JxZCXIF2ikPpxSvEMNZ+lbDMd0uuA5tTK4rR8wvFMNJlmMWlJABA9SH5erHMcpA PbcsM2OhBJVz3Vi+fjchsmjnsOhYLJWEf8lkT0sYfcGDCTHz7aIoDVQC+EMXoYKh/F/I KARXSBXm7ZwtOnDv2jGRXxNib8IpEuODIVYWAOKuvRBJ0t/RPGa6c+6kjGcKoXVs9CJa WaAA== X-Gm-Message-State: APjAAAXmmC0PDk+RPdnt1gp1H4wjrmgRGXEOJBymf25HvB1c9vRrEjbG zopzrxl5txbU2+z+uOsPuCk= X-Google-Smtp-Source: APXvYqzCnOEOow1v6DODOGqJGdvRYK636qnh+ra8FxbDL0pklLhRh2RE6AZzBuqoEdIvtqufhUkC+g== X-Received: by 2002:adf:efc1:: with SMTP id i1mr32809261wrp.199.1555023766214; Thu, 11 Apr 2019 16:02:46 -0700 (PDT) Received: from localhost.localdomain (5-12-225-227.residential.rdsnet.ro. [5.12.225.227]) by smtp.gmail.com with ESMTPSA id j22sm120077208wrd.91.2019.04.11.16.02.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:02:44 -0700 (PDT) From: Vladimir Oltean To: f.fainelli@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net Cc: netdev@vger.kernel.org, Vladimir Oltean Subject: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN Date: Fri, 12 Apr 2019 02:01:39 +0300 Message-Id: <20190411230139.13160-1-olteanv@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With Heiner's recent patch "b6163f194c69 net: phy: improve genphy_read_status", the phydev->speed is now initialized by default to SPEED_UNKNOWN even for fixed PHYs. This is not necessarily bad, since it is not correct to call genphy_config_init() and genphy_read_status() for a fixed PHY. This dates back all the way to "39b0c705195e net: dsa: Allow configuration of CPU & DSA port speeds/duplex" (discussion thread: https://www.spinics.net/lists/netdev/msg340862.html). I don't seem to understand why these calls were necessary back then, but removing these calls seemingly has no impact now apart from preventing the phydev->speed that was set in of_phy_register_fixed_link() from getting overwritten. Signed-off-by: Vladimir Oltean --- net/dsa/port.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/dsa/port.c b/net/dsa/port.c index 87769cb38c31..481412c892a7 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -485,9 +485,6 @@ static int dsa_port_fixed_link_register_of(struct dsa_port *dp) mode = PHY_INTERFACE_MODE_NA; phydev->interface = mode; - genphy_config_init(phydev); - genphy_read_status(phydev); - if (ds->ops->adjust_link) ds->ops->adjust_link(ds, port, phydev); -- 2.17.1