Received: from eggs.gnu.org ([209.51.188.92]:53748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF3XT-0008Mv-CA for qemu-devel@nongnu.org; Fri, 12 Apr 2019 17:16:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hF3XR-0002VW-B1 for qemu-devel@nongnu.org; Fri, 12 Apr 2019 17:16:47 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]:52708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hF3XP-0002QC-5a for qemu-devel@nongnu.org; Fri, 12 Apr 2019 17:16:43 -0400 Date: Fri, 12 Apr 2019 23:16:33 +0200 From: Samuel Thibault Message-ID: <20190412211633.6pyn6cfm5dnwjzji@function> References: <20190405184648.17029-1-dgilbert@redhat.com> <20190405212501.cdg4u3m7ihldcop4@function> <20190408084653.GB2687@work-vm> <20190411184502.xvesnriqcocyvuan@function> <20190412154942.GF2906@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190412154942.GF2906@work-vm> Subject: Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, jan.kiszka@siemens.com Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit: > * Samuel Thibault (samuel.thibault@gnu.org) wrote: > > Hello, > > > > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit: > > > 'soread' has the comment: > > > > > > /* > > > * No need to check if there's enough room to read. > > > * soread wouldn't have been called if there weren't > > > */ > > > sopreprbuf(so, iov, &n); > > > > > > the compiler doesn't realise that, and is moaning about the case > > > where the if (len <=0) return happens and the following > > > code tries to use iov. > > > > I see. Perhaps we should make this an assert then? In case this isn't > > true, i.e. soread() is called even if no room is available, returning 0 > > would probably just let the caller just try again, and we should rather > > just plainly crash than hang? > > Adding the assert in soread sorts that case out: > assert(sopreprbuf(so, iov, &n) != 0); > > however, I also need to fix soreadbuf; is it legal to call that with > a 0 size? It does not really make sense to, so an assert >0 should be fine. Samuel