From: Andrew Lunn Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection Date: Sat, 13 Apr 2019 00:47:37 +0200 Message-ID: <20190412224737.GA1004@lunn.ch> References: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com> Sender: netdev-owner@vger.kernel.org To: Heiner Kallweit Cc: Florian Fainelli , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. > > I don't have access to most of these PHY's, therefore I'd appreciate > regression testing. Hi Heiner I tested v1 on the following PHYs: 88E1510, 88E1540, 88E6390, KSZ8041, 88E1545 No obvious regressions. Tested-by: Andrew Lunn Andrew