Received: from eggs.gnu.org ([209.51.188.92]:36983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGJeU-0005tU-4D for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGJeT-0001wR-2u for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:41:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47920) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGJeS-0001w7-QZ for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:41:13 -0400 Date: Tue, 16 Apr 2019 09:40:59 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190416084059.GD31311@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190415154503.6758-1-berrange@redhat.com> <20190415165426.GT5718@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190415165426.GT5718@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: Peter Maydell , Thomas Huth , Greg Kurz , qemu-devel@nongnu.org, Gerd Hoffmann On Mon, Apr 15, 2019 at 05:54:26PM +0100, Daniel P. Berrang=C3=A9 wrote: > On Mon, Apr 15, 2019 at 12:52:41PM -0400, Bandan Das wrote: > > Daniel P. Berrang=C3=A9 writes: > >=20 > > > Two previous attempts to fix this due to GCC 9 highlighting > > > unaligned data access. My attempt: > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.ht= ml > > > > > > And a previous one: > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07923.ht= ml > > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00162.ht= ml > > > > > > There are a number of bugs in the USB MTP usb_mtp_write_metadata > > > method handling the filename character set conversion. > > > > > > The 2nd patch in this series is a security flaw fix since the > > > code was not correctly validating guest provided data length. > > > > > > I've been unable to figure out how to exercise the codepath that > > > calls usb_mtp_write_metadata. At a guess, it looks like something > > > that should be called when writing to a file from a guest, but the > > > GNOME GVFS MTP driver doesn't provide write support. Using the > > > command line MTP tools "mtp-sendfile" command results in an > > > protocol error > > > > > > # mtp-sendfile foo eek.txt > > > libmtp version: 1.1.14 > > > > >=20 > > The store is read only by default. Are you trying something like: > > -device usb-mtp,rootdir=3D/code/mtpshare,readonly=3Dfalse ? >=20 > Ah ha, I didn't realize I had to enable write support explicitly. Will > retry with that. Even after setting readonly=3Dfalse, I still can't get "mtp-sendfile" to succeed in a guest. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|