Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94ACC10F13 for ; Tue, 16 Apr 2019 09:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 774A52086A for ; Tue, 16 Apr 2019 09:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729162AbfDPJ32 (ORCPT ); Tue, 16 Apr 2019 05:29:28 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:40660 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729026AbfDPJ30 (ORCPT ); Tue, 16 Apr 2019 05:29:26 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 9F577201E3; Tue, 16 Apr 2019 11:29:24 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mdMLILCDSNTy; Tue, 16 Apr 2019 11:29:23 +0200 (CEST) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 54CBC201E6; Tue, 16 Apr 2019 11:29:23 +0200 (CEST) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.439.0; Tue, 16 Apr 2019 11:29:22 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id B82A9318037A; Tue, 16 Apr 2019 11:29:22 +0200 (CEST) Date: Tue, 16 Apr 2019 11:29:22 +0200 From: Steffen Klassert To: Florian Westphal CC: , Randy Dunlap Subject: Re: [PATCH ipsec-next] xfrm: kconfig: make xfrm depend on inet Message-ID: <20190416092922.GL17989@gauss3.secunet.de> References: <20190412081446.19213-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190412081446.19213-1-fw@strlen.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: F5EF7F68-327E-425D-9C6F-360AAD60A30F X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 12, 2019 at 10:14:46AM +0200, Florian Westphal wrote: > when CONFIG_INET is not enabled: > net/xfrm/xfrm_output.c: In function ‘xfrm4_tunnel_encap_add’: > net/xfrm/xfrm_output.c:234:2: error: implicit declaration of function ‘ip_select_ident’ [-Werror=implicit-function-declaration] > ip_select_ident(dev_net(dst->dev), skb, NULL); > > XFRM only supports ipv4 and ipv6 so change dependency to INET and place > user-visible options (pfkey sockets, migrate support and the like) > under 'if INET' guard as well. > > Fixes: 1de70830066b7 ("xfrm: remove output2 indirection from xfrm_mode") > Reported-by: Randy Dunlap > Signed-off-by: Florian Westphal Applied to ipsec-next, thanks Florian!