From: Liu Bo Date: Wed, 17 Apr 2019 02:03:22 +0800 Message-Id: <20190416180322.65113-10-bo.liu@linux.alibaba.com> In-Reply-To: <20190416180322.65113-1-bo.liu@linux.alibaba.com> References: <20190416180322.65113-1-bo.liu@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Virtio-fs] [PATCH 9/9] fuse: fix deadlock in __fuse_file_fallocate() List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: virtio-fs@redhat.com From: Xiaoguang Wang This bug is obvious, fix it. Reviewed-by: Joseph Qi Signed-off-by: Xiaoguang Wang --- fs/fuse/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 6ab23d7..0236783 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -3623,7 +3623,7 @@ static long __fuse_file_fallocate(struct file *file, int mode, if (mode & FALLOC_FL_PUNCH_HOLE) { down_write(&fi->i_mmap_sem); truncate_pagecache_range(inode, offset, offset + length - 1); - down_write(&fi->i_mmap_sem); + up_write(&fi->i_mmap_sem); } fuse_invalidate_attr(inode); -- 1.8.3.1