Received: from eggs.gnu.org ([209.51.188.92]:58911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGasx-0006Z3-I2 for qemu-devel@nongnu.org; Tue, 16 Apr 2019 23:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGasu-0001sG-44 for qemu-devel@nongnu.org; Tue, 16 Apr 2019 23:05:17 -0400 Date: Wed, 17 Apr 2019 11:59:34 +1000 From: David Gibson Message-ID: <20190417015934.GH32705@umbus.fritz.box> References: <20190416045552.24573-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hlh2aiwFLCZwGcpw" Content-Disposition: inline In-Reply-To: <20190416045552.24573-1-npiggin@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] spapr: add splpar hcalls H_PROD, H_CONFER List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nicholas Piggin Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Benjamin Herrenschmidt , =?iso-8859-1?Q?C=E9dric?= Le Goater --Hlh2aiwFLCZwGcpw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2019 at 02:55:52PM +1000, Nicholas Piggin wrote: > These implementations have a few deficiencies that are noted, but are > good enough for Linux to use. >=20 > Signed-off-by: Nicholas Piggin > --- >=20 > v3: Removed wrong comment about GPR3, drop H_JOIN for now (at least until > it is tested some more in Linux/KVM), and expand the comment about not > prod bit. >=20 > hw/ppc/spapr_hcall.c | 71 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) >=20 > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > index 8a736797b9..8892ad008b 100644 > --- a/hw/ppc/spapr_hcall.c > +++ b/hw/ppc/spapr_hcall.c > @@ -1065,6 +1065,74 @@ static target_ulong h_cede(PowerPCCPU *cpu, SpaprM= achineState *spapr, > return H_SUCCESS; > } > =20 > +static target_ulong h_confer(PowerPCCPU *cpu, SpaprMachineState *spapr, > + target_ulong opcode, target_ulong *args) > +{ > + target_long target =3D args[0]; > + CPUState *cs =3D CPU(cpu); > + > + /* > + * This does not do a targeted yield or confer, but check the parame= ter > + * anyway. -1 means confer to all/any other CPUs. > + */ > + if (target !=3D -1 && !CPU(spapr_find_cpu(target))) { > + return H_PARAMETER; > + } > + > + /* > + * PAPR calls for waiting until proded in this case (or presumably > + * an external interrupt if MSR[EE]=3D1, without dispatch sequence c= ount > + * check. Is this comment complete? It's missing a closing parenthesis at the very least. > + */ > + if (cpu =3D=3D spapr_find_cpu(target)) { > + cs->halted =3D 1; > + cs->exception_index =3D EXCP_HALTED; > + cs->exit_request =3D 1; > + > + return H_SUCCESS; > + } > + > + /* > + * This does not implement the dispatch sequence check that PAPR cal= ls for, > + * but PAPR also specifies a stronger implementation where the targe= t must > + * be run (or EE, or H_PROD) before H_CONFER returns. Without such a= hard > + * scheduling requirement implemented, there is no correctness reaso= n to > + * implement the dispatch sequence check. > + */ > + cs->exception_index =3D EXCP_YIELD; > + cpu_loop_exit(cs); > + > + return H_SUCCESS; > +} > + > +static target_ulong h_prod(PowerPCCPU *cpu, SpaprMachineState *spapr, > + target_ulong opcode, target_ulong *args) > +{ > + target_long target =3D args[0]; > + CPUState *cs; > + > + /* > + * PAPR specifies there should be a prod flag should be associated w= ith > + * a vCPU, which gets set here, tested by H_CEDE, and cleared any ti= me > + * the vCPU is dispatched, including via preemption. > + * > + * We don't implement this because it is not used by Linux. The bit = would > + * be difficult or impossible to use properly because preemption can= not > + * be prevented so dispatch sequence count would have to somehow be = used > + * to detect it. Hm. AFAIK the dispatch sequence count only exists with KVM, so I don't see how testing it would fit with a userspace implementation of PROD. > + */ > + > + cs =3D CPU(spapr_find_cpu(target)); > + if (!cs) { > + return H_PARAMETER; > + } > + > + cs->halted =3D 0; > + qemu_cpu_kick(cs); > + > + return H_SUCCESS; > +} > + > static target_ulong h_rtas(PowerPCCPU *cpu, SpaprMachineState *spapr, > target_ulong opcode, target_ulong *args) > { > @@ -1860,6 +1928,9 @@ static void hypercall_register_types(void) > /* hcall-splpar */ > spapr_register_hypercall(H_REGISTER_VPA, h_register_vpa); > spapr_register_hypercall(H_CEDE, h_cede); > + spapr_register_hypercall(H_CONFER, h_confer); > + spapr_register_hypercall(H_PROD, h_prod); > + > spapr_register_hypercall(H_SIGNAL_SYS_RESET, h_signal_sys_reset); You're no longer enabling the KVM CONFER and PROD hypercalls. Are they enabled by default, or is that an intentional change? > /* processor register resource access h-calls */ --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Hlh2aiwFLCZwGcpw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAly2iIQACgkQbDjKyiDZ s5Kuuw//eznmY7qwsa31ezrdfG1UNnQRBFzbjxmbYq55WFfJnT+yTsG2BE7eVfN/ A1fmLyXjuxT8k8tdVMsP2tT1N+3o2okAhMLLLp1WeUgW2KF++EyDzaM2BK/YEUtr YD1cm3gN5Jrfg7xZ3gQOL37UGz9S6NNyXThOr3HCzTYqaO9BXOVn69wQyEpOGw7i +4SpemMN9hrKA/6JmfoLnjl6tmmodF9PfdXpgY7W4WPTtjL5g/UsEbA1KyDxn5u8 pmvgdfsrX2SaGCCtlLMUW8Db2ZyeK6ErYndu6UrutCON+SDAbFeR4NBxxwylyVO6 fZVjL6Eapj3ASlDsRQnMSf91wFFzT5AG6n/CIbjxDMSYSF4uKmbzhNWoSVrorShx 9MOeKS7PeKPU1hIzcEHwt2DB6tLpwahMTl0mM17ZcRqSddASItzrhe+CpqKgvkYX HKgl9v/67sgELYlGwFzNCtkypXsWyT3X+Td7LR9JwoBo0Pqs6QodzPLtmpeK5Kb3 OuikwXVFLQvMtup/lBwkzvMmrCllRTx8VAH+C9+ObV9IaPjl9IaglJddfXquboIh G48lK1mYzVS1s7XyXWImbH4ytN1PZCTff/PXtHlyDfseFL7QeQXIcIfVBy1LSf6c TKip0M/MEkyjkXHk6L70a6QH4Ie6DNFo8m7fQ72Agq3kJ36gcSU= =deig -----END PGP SIGNATURE----- --Hlh2aiwFLCZwGcpw--