From: Christoph Hellwig Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Date: Wed, 17 Apr 2019 08:33:58 +0200 Message-ID: <20190417063358.GA24139@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190410061157.GA5278@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: > > On 27/03/2019 08:04, Christoph Hellwig wrote: > >> This keeps the code together and will simplify compiling the code > >> out on architectures that are always dma coherent. > > > > And this is where things take a turn in the direction I just can't get on > > with - I'm looking at the final result and the twisty maze of little > > disjoint helpers all overlapping each other in functionality is really > > difficult to follow. And I would *much* rather have things rely on > > compile-time constant optimisation than spend the future having to fix the > > #ifdefed parts for arm64 whenever x86-centric changes fail to test them. > > Can you draft up a patch on top of my series to show me what you > want? I can take care of finishing it up and moving the changes > into the right patches in the series. Any chance to make some progress on this? Or at least a better description of what you want?