From: Daniel Vetter Subject: Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv Date: Wed, 17 Apr 2019 10:10:58 +0200 Message-ID: <20190417081058.GN13337@phenom.ffwll.local> References: <20190416214046.3551-1-andresx7@gmail.com> <9e3278ad-a1d2-c45e-9ee6-a6f80ada7969@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 405D288284 for ; Wed, 17 Apr 2019 08:11:03 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id g6so16211651edc.8 for ; Wed, 17 Apr 2019 01:11:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9e3278ad-a1d2-c45e-9ee6-a6f80ada7969@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: christian.koenig@amd.com Cc: Keith Packard , David Airlie , dri-devel@lists.freedesktop.org, Andres Rodriguez , Alex Deucher , Emil Velikov List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMDk6MDk6MjdBTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAxNi4wNC4xOSB1bSAyMzo0MCBzY2hyaWViIEFuZHJlcyBSb2RyaWd1ZXo6 Cj4gPiBBZnRlciBhIHJlY2VudCBjb21taXQsIGFjY2VzcyB0byB0aGUgRFJNX0FVVEggaW9jdGxz IGJlY29tZSBtb3JlCj4gPiBwZXJtaXNzaXZlLiBUaGlzIHJlc3VsdGVkIGluIGEgYnVnZ3kgY2hl Y2sgZm9yIGRybV9tYXN0ZXIgY2FwYWJpbGl0aWVzCj4gPiBpbnNpZGUgcmFkdiBzdG9wIHdvcmtp bmcuCj4gPiAKPiA+IFRoaXMgY29tbWl0IGFkZHMgYSBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSB3 b3JrYXJvdW5kIHNvIHRoYXQgdGhlIHJhZHYKPiA+IGRybV9tYXN0ZXIgY2hlY2sga2VlcHMgd29y a2luZyBhcyBwcmV2aW91c2x5IGV4cGVjdGVkLgo+ID4gCj4gPiBUaGlzIGZpeGVzIFN0ZWFtVlIg YW5kIG90aGVyIGRybSBsZWFzZSBiYXNlZCBhcHBzIGJlaW5nIGJyb2tlbiBzaW5jZQo+ID4gdjUu MS1yYzEKPiA+IAo+ID4gIEZyb20gdGhlIHVzZXJtb2RlIHNpZGUsIHJhZHYgd2lsbCBhbHNvIGJl IGZpeGVkIHRvIHByb3Blcmx5IHRlc3QgZm9yCj4gPiBtYXN0ZXIgY2FwYWJpbGl0aWVzOgo+ID4g aHR0cHM6Ly9naXRsYWIuZnJlZWRlc2t0b3Aub3JnL21lc2EvbWVzYS9tZXJnZV9yZXF1ZXN0cy82 NjkKPiA+IAo+ID4gRml4ZXM6IDgwNTlhZGQwNDc4ZSAoImRybTogYWxsb3cgcmVuZGVyIGNhcGFi bGUgbWFzdGVyIHdpdGggRFJNX0FVVEggaW9jdGxzIikKPiA+IFNpZ25lZC1vZmYtYnk6IEFuZHJl cyBSb2RyaWd1ZXogPGFuZHJlc3g3QGdtYWlsLmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxk YW5pZWxAZmZ3bGwuY2g+Cj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ ID4gQ2M6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gPiBDYzog QWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+ID4gQ2M6IEtlaXRoIFBh Y2thcmQgPGtlaXRocEBrZWl0aHAuY29tPgo+ID4gUmV2aWV3ZWQtYnk6IEtlaXRoIFBhY2thcmQg PGtlaXRocEBrZWl0aHAuY29tPgo+ID4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bEBmZndsbC5jaD4KPiAKPiBXZWxsIGRlZmluaXRlbHkgYSBOQUsuIElJUkMgd2UgaGF2ZSB1bml0 IHRlc3RzIHdoZXJlIHRoZSBleGFjdGx5IGZpcnN0IHRoaW5nCj4gdGhleSBkbyBpcyBxdWVyeWlu ZyBBTURHUFVfSU5GT19BQ0NFTF9XT1JLSU5HLgo+IAo+IEFuZCBJIGRlZmluaXRlbHkgbm90IGdv aW5nIHRvIHJpc2sgYnJlYWtpbmcgdGhvc2UganVzdCB0byBmaXggYnVnZ3kgYmVoYXZpb3IKPiBp biByYWR2LgoKcy9idWdneS9mcmFnaWxlIDotKQoKT3B0aW9uIEIgd291bGQgYmUgdG8gZGlzYWJs ZSA4MDU5YWRkMDQ3OGUgKCJkcm06IGFsbG93IHJlbmRlciBjYXBhYmxlCm1hc3RlciB3aXRoIERS TV9BVVRIIGlvY3RscyIpIGp1c3QgZm9yIGFtZGdwdS5rbywgYnV0IHRoYXQncyBhIGJpdCBtb3Jl CnRyaWNreSB0byBpbXBsZW1lbnQgSSBndWVzcyAoc2luY2UgaXQnZCBsZWFrIGFsbCBvdmVyIHRo ZSBwbGFjZSkuCgpPcHRpb24gQyBpcyB0byByZXZlcnQgODA1OWFkZDA0LCBidXQgdGhhdCdzIGEg Yml0IHNpbGx5IHNpbmNlIGl0IHNlZW1zIHRvCndvcmsgZXZlcnl3aGVyZS4KCkJyZWFraW5nIHJh ZHYgaXNuJ3QgYW4gb3B0aW9uLCBiZWNhdXNlIG5vIHJlZ3Jlc3Npb24uIEFzaWRlOiBObyBvbmUg aXMKc3RvcHBpbmcgYW1kIGZvbGtzIGZyb20gcmV2aWV3aW5nIHJhZHYgcGF0Y2hlcyBhbmQgbWFr aW5nIHN1cmUgdGhlcmUncyBubwpmcmFnaWxlIHN0dWZmIGluIHRoZXJlLgoKV2UgZGlzY3Vzc2Vk IHRoaXMgcXVpdGUgYSBiaXQgb24gaXJjIHdpdGggQmVuIGFuZCBLZWl0aCBhbmQgb3RoZXJzLCBh bmQKZmlndXJlZCBvcHRpb24gQSBpcyB0aGUgbW9zdCBwcm9taXNpbmcgdG8gZ28gZm9yd2FyZCB3 aXRoLiBBbnl0aGluZyB1c2luZwphbWRncHVfZGV2aWNlX2luaXQgKHdoaWNoIEkgdGhpbmsgYXJl IGFsbCB0aGUgdW1kcywgYnV0IEkgZGlkbid0IGNoZWNrKQp3aWxsIGtlZXAgd29ya2luZywgYXMg d2lsbCByYWR2IGxlYXNlcy92a2Rpc3BsYXksIHBsdXMgd2UgY2FuIGtlZXAKODA1OWFkZDA0IGZv ciBldmVyeW9uZSAobm90IGp1c3QgZXZlcm9ueSBleGNlcHQgYW1kZ3B1KS4gSWYgdGhhdCBtZWFu cwpicmVha2luZyBhIGZldyB1bml0IHRlc3RzIC4uLiAqc2hydWdoKi4gTmVlZHMgcGF0Y2hlcyB0 byBmaXggdGhlbSBvZmMsIGJ1dApzaG91bGRuJ3QgYmUgdGhhdCBtdWNoIHdvcmsgcmVhbGx5Lgot RGFuaWVsCgo+IAo+IENocmlzdGlhbi4KPiAKPiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHUuaCAgICAgfCAgMyArKysKPiA+ICAgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2Rydi5jIHwgIDIgKysKPiA+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2ttcy5jIHwgMjIgKysrKysrKysrKysrKysrKysrKysrKwo+ID4gICAzIGZp bGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1LmgKPiA+IGluZGV4IDhkMGQ3ZjNkZDVmYi4uZTY3YmZlZThkNDExIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gPiBAQCAtNDA5LDYgKzQwOSw5IEBA IHN0cnVjdCBhbWRncHVfZnByaXYgewo+ID4gICAJc3RydWN0IG11dGV4CQlib19saXN0X2xvY2s7 Cj4gPiAgIAlzdHJ1Y3QgaWRyCQlib19saXN0X2hhbmRsZXM7Cj4gPiAgIAlzdHJ1Y3QgYW1kZ3B1 X2N0eF9tZ3IJY3R4X21ncjsKPiA+ICsKPiA+ICsJLyogUGFydCBvZiBhIGJhY2t3YXJkcyBjb21w YXRpYmlsaXR5IGhhY2sgKi8KPiA+ICsJYm9vbAkJCWlzX2ZpcnN0X2lvY3RsOwo+ID4gICB9Owo+ ID4gICBpbnQgYW1kZ3B1X2ZpbGVfdG9fZnByaXYoc3RydWN0IGZpbGUgKmZpbHAsIHN0cnVjdCBh bWRncHVfZnByaXYgKipmcHJpdik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2Rydi5jCj4gPiBpbmRleCA3NDE5ZWE4YTM4OGIuLmNkNDM4YWZhNzA5MiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kcnYuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rydi5jCj4gPiBAQCAtMTEyOCw2ICsxMTI4 LDcgQEAgbG9uZyBhbWRncHVfZHJtX2lvY3RsKHN0cnVjdCBmaWxlICpmaWxwLAo+ID4gICAJCSAg ICAgIHVuc2lnbmVkIGludCBjbWQsIHVuc2lnbmVkIGxvbmcgYXJnKQo+ID4gICB7Cj4gPiAgIAlz dHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiA9IGZpbHAtPnByaXZhdGVfZGF0YTsKPiA+ICsJc3Ry dWN0IGFtZGdwdV9mcHJpdiAqZnByaXYgPSBmaWxlX3ByaXYtPmRyaXZlcl9wcml2Owo+ID4gICAJ c3RydWN0IGRybV9kZXZpY2UgKmRldjsKPiA+ICAgCWxvbmcgcmV0Owo+ID4gICAJZGV2ID0gZmls ZV9wcml2LT5taW5vci0+ZGV2Owo+ID4gQEAgLTExMzYsNiArMTEzNyw3IEBAIGxvbmcgYW1kZ3B1 X2RybV9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlscCwKPiA+ICAgCQlyZXR1cm4gcmV0Owo+ID4gICAJ cmV0ID0gZHJtX2lvY3RsKGZpbHAsIGNtZCwgYXJnKTsKPiA+ICsJZnByaXYtPmlzX2ZpcnN0X2lv Y3RsID0gZmFsc2U7Cj4gPiAgIAlwbV9ydW50aW1lX21hcmtfbGFzdF9idXN5KGRldi0+ZGV2KTsK PiA+ICAgCXBtX3J1bnRpbWVfcHV0X2F1dG9zdXNwZW5kKGRldi0+ZGV2KTsKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMKPiA+IGluZGV4IGU4NjA0MTIwNDNiYi4uMDBj MGEyZmIyYTY5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2ttcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z LmMKPiA+IEBAIC00NTUsNiArNDU1LDcgQEAgc3RhdGljIGludCBhbWRncHVfaHdfaXBfaW5mbyhz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiA+ICAgc3RhdGljIGludCBhbWRncHVfaW5mb19p b2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbHApCj4gPiAgIHsKPiA+ICAgCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPiA+ICsJc3RydWN0IGFtZGdwdV9mcHJpdiAqZnByaXYgPSBmaWxwLT5kcml2 ZXJfcHJpdjsKPiA+ICAgCXN0cnVjdCBkcm1fYW1kZ3B1X2luZm8gKmluZm8gPSBkYXRhOwo+ID4g ICAJc3RydWN0IGFtZGdwdV9tb2RlX2luZm8gKm1pbmZvID0gJmFkZXYtPm1vZGVfaW5mbzsKPiA+ ICAgCXZvaWQgX191c2VyICpvdXQgPSAodm9pZCBfX3VzZXIgKikodWludHB0cl90KWluZm8tPnJl dHVybl9wb2ludGVyOwo+ID4gQEAgLTQ3MCw2ICs0NzEsMjYgQEAgc3RhdGljIGludCBhbWRncHVf aW5mb19pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJt X2ZpbGUKPiA+ICAgCXN3aXRjaCAoaW5mby0+cXVlcnkpIHsKPiA+ICAgCWNhc2UgQU1ER1BVX0lO Rk9fQUNDRUxfV09SS0lORzoKPiA+ICsJCS8qIEhBQ0s6IHJhZHYgaGFzIGEgZnJhZ2lsZSBvcGVu LWNvZGVkIGNoZWNrIGZvciBkcm0gbWFzdGVyCj4gPiArCQkgKiBUaGUgcGF0dGVybiBmb3IgdGhl IGNhbGwgaXM6Cj4gPiArCQkgKiAgICAgb3BlbihEUk1fTk9ERV9QUklNQVJZKQo+ID4gKwkJICog ICAgIGRybU1vZGVDb21tYW5kV3JpdGUoIHF1ZXJ5PUFNREdQVV9JTkZPX0FDQ0VMX1dPUktJTkcg KQo+ID4gKwkJICoKPiA+ICsJCSAqIEFmdGVyIGNvbW1pdCA4MDU5YWRkMDQgdGhpcyBjaGVjayBz dG9wcGVkIHdvcmtpbmcgZHVlIHRvCj4gPiArCQkgKiBvcGVyYXRpb25zIG9uIGEgcHJpbWFyeSBu b2RlIGZyb20gbm9uLW1hc3RlciBjbGllbnRzIGJlY29taW5nCj4gPiArCQkgKiBtb3JlIHBlcm1p c3NpdmUuCj4gPiArCQkgKgo+ID4gKwkJICogVGhpcyBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSBo YWNrIHRhcmdldHMgdGhlIGNhbGxpbmcgcGF0dGVybgo+ID4gKwkJICogYWJvdmUgdG8gZmFpbCBy YWR2IGZyb20gdGhpbmtpbmcgaXQgaGFzIG1hc3RlciBhY2Nlc3MgdG8gdGhlCj4gPiArCQkgKiBk aXNwbGF5IHN5c3RlbSAoIHdpdGhvdXQgcmV2ZXJ0aW5nIDgwNTlhZGQwNCApLgo+ID4gKwkJICoK PiA+ICsJCSAqIFVzZXJzIG9mIGxpYmRybSB3aWxsIG5vdCBiZSBhZmZlY3RlZCBhcyBzb21lIG90 aGVyIGlvY3RscyBhcmUKPiA+ICsJCSAqIHBlcmZvcm1lZCBiZXR3ZWVuIG9wZW4oKSBhbmQgdGhl IEFNREdQVV9JTkZPX0FDQ0VMX1dPUktJTkcKPiA+ICsJCSAqIHF1ZXJ5Lgo+ID4gKwkJICovCj4g PiArCQlpZiAoZnByaXYtPmlzX2ZpcnN0X2lvY3RsICYmICFmaWxwLT5pc19tYXN0ZXIpCj4gPiAr CQkJcmV0dXJuIC1FQUNDRVM7Cj4gPiArCj4gPiAgIAkJdWkzMiA9IGFkZXYtPmFjY2VsX3dvcmtp bmc7Cj4gPiAgIAkJcmV0dXJuIGNvcHlfdG9fdXNlcihvdXQsICZ1aTMyLCBtaW4oc2l6ZSwgNHUp KSA/IC1FRkFVTFQgOiAwOwo+ID4gICAJY2FzZSBBTURHUFVfSU5GT19DUlRDX0ZST01fSUQ6Cj4g PiBAQCAtOTg3LDYgKzEwMDgsNyBAQCBpbnQgYW1kZ3B1X2RyaXZlcl9vcGVuX2ttcyhzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKPiA+ICAgCQkJZ290 byBlcnJvcl92bTsKPiA+ICAgCX0KPiA+ICsJZnByaXYtPmlzX2ZpcnN0X2lvY3RsID0gdHJ1ZTsK PiA+ICAgCW11dGV4X2luaXQoJmZwcml2LT5ib19saXN0X2xvY2spOwo+ID4gICAJaWRyX2luaXQo JmZwcml2LT5ib19saXN0X2hhbmRsZXMpOwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5n aW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==