From: Daniel Vetter Subject: Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv Date: Wed, 17 Apr 2019 14:00:42 +0200 Message-ID: <20190417120042.GW13337@phenom.ffwll.local> References: <20190416214046.3551-1-andresx7@gmail.com> <9e3278ad-a1d2-c45e-9ee6-a6f80ada7969@gmail.com> <20190417081058.GN13337@phenom.ffwll.local> <48b47310-caa6-7519-c81f-0c91501cd73a@amd.com> <38971d43-0f7d-9888-1b0b-0c0d45694066@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id D71EF6E041 for ; Wed, 17 Apr 2019 12:00:46 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id u57so20101772edm.3 for ; Wed, 17 Apr 2019 05:00:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <38971d43-0f7d-9888-1b0b-0c0d45694066@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Koenig, Christian" Cc: Keith Packard , David Airlie , "dri-devel@lists.freedesktop.org" , Andres Rodriguez , "Deucher, Alexander" , Emil Velikov List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMTE6MTg6MzVBTSArMDAwMCwgS29lbmlnLCBDaHJpc3Rp YW4gd3JvdGU6Cj4gQW0gMTcuMDQuMTkgdW0gMTM6MDYgc2NocmllYiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMTI6MjkgUE0gS29lbmlnLCBDaHJpc3RpYW4KPiA+ IDxDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20+IHdyb3RlOgo+ID4+IEhpIGd1eXMsCj4gPj4KPiA+ PiB3ZWxsIGdvaW5nIGJhY2sgdG8gdGhlIGJlZ2lubmluZyBvbmNlIG1vcmUgYmVjYXVzZSBzb21l dGhpbmcgZG9lc24ndCBmaXQKPiA+PiB0b2dldGhlciBoZXJlLgo+ID4+Cj4gPj4gSSBtZWFuIHdo YXQgZXhhY3RseSBpcyB0aGUgcHVycG9zZSBvZiA4MDU5YWRkMDQ3OGUgImRybTogYWxsb3cgcmVu ZGVyCj4gPj4gY2FwYWJsZSBtYXN0ZXIgd2l0aCBEUk1fQVVUSCBpb2N0bHMiPwo+ID4+Cj4gPj4g V2hlbiBJIHJlYWQgdGhlIGNvZGUgY29ycmVjdGx5IHRoZSBlZmZlY3QgaXMgdGhhdCB3ZSBpZ25v cmUgdGhlIERSTV9BVVRICj4gPj4gZmxhZyB3aGVuIGFsc28gdGhlIERSTV9SRU5ERVJfQUxMT1cg ZmxhZyBpcyBzZXQgYW5kIHRoZSBkcml2ZXIgaXMgYQo+ID4+IHJlbmRlciBub2RlIGRyaXZlci4K PiA+Pgo+ID4+IFdlbGwgd2hlbiB0aGlzIGlzIGNvcnJlY3QgdGhlbiB3aHkgdGhlIGhlY2sgYXJl bid0IHdlIHJlbW92aW5nIHRoZQo+ID4+IERSTV9BVVRIIGZsYWcgZnJvbSB0aGUgYWZmZWN0ZWQg SU9DVExzIGluc3RlYWQ/Cj4gPj4KPiA+PiBUaGUgb25seSBjb21tb24gSU9DVExzIGFmZmVjdGlu ZyB0aGlzIGFyZSBEUk1fSU9DVExfUFJJTUVfSEFORExFX1RPX0ZECj4gPj4gYW5kIERSTV9JT0NU TF9QUklNRV9GRF9UT19IQU5ETEUgYW5kIHRob3NlIGFyZSBwcm90ZWN0ZWQgYnkgY2FwYWJpbGl0 eQo+ID4+IGZsYWdzIHNlcGFyYXRlbHkuCj4gPj4KPiA+PiBTbyB0aGUgcGF0Y2ggODA1OWFkZDA0 NzhlIGRvZXNuJ3QgbWFrZSBhbnkgc2Vuc2UgYXMgZmFyIGFzIEkgY2FuIHRlbGwuCj4gPj4gV2hh dCBJJ20gbWlzc2luZz8KPiA+IFRoZSBpZGVhIGlzIHRoYXQgaWYgeW91ciBkcml2ZXIgc3VwcG9y dHMgcmVuZGVyIG5vZGUgKGkuZS4gaXNvbGF0ZXMKPiA+IHVucHJpdmlsZWRnZWQgY2xpZW50cyks IHRoZW4gd2UgY291bGQgYWxsb3cgdGhlIHNhbWUgb24gcHJpbWFyeSBub2Rlcy4KPiA+IFRoZXJl J3MgYSBidW5jaCBvZiB1c2Vyc3BhY2Ugd2hpY2ggYmxpbmRseSBvbmx5IG9wZW5zIHByaW1hcnkg bm9kZXMKPiA+IChpbnN0ZWFkIG9mIGFsc28gb3BlbmluZyByZW5kZXIgbm9kZXMpLCBhbmQgdGhp cyBtYWtlcyB0aGVtIHdvcmsKPiA+IHdpdGhvdXQgcmVxdWlyaW5nIHJvb3Qgb3Igc2ltaWxhci4g QWZhaXVpIHRoZSBtYWluIG9mZmVuZGVyIGlzIGxpYnZhCj4gPiBiZWluZyByZWFsbHkgZGVuc2Ug KGFuZCBzZW1pLWFiYW5kb25kZWQsIHBhcnRpYWxseSBhbHNvIGJlY2F1c2UgaW50ZWwKPiA+IGhh cyBjaGFuZ2VkIGZvciB0aGUgd29yc2UgaW4gdGhhdCBhcmVhKS4KPiAKPiBBbmQgZXhhY3RseSB0 aGF0J3MgdGhlIHByb2JsZW0sIHdlIGNhbid0IGRvIHRoaXMuIEl0J3Mgbm90IG9ubHkgcmFkdiAK PiB3aGljaCBicmVha3MsIGJ1dCBhbHNvIG9sZGVyIGxpYmRybV9hbWRncHUgdmVyc2lvbnMgYXMg d2VsbCBhcyBhIGJ1bmNoIAo+IG9mIG90aGVyIHN0dWZmLgo+IAo+IEtleSBwcm9ibGVtIGlzIHRo YXQgb2xkZXIgbGliZHJtX2FtZGdwdSBjb2RlIGRpZCBleGFjdGx5IHRoZSBzYW1lIHRoaW5nIAo+ IGFuZCBjYWxsZWQgYW4gSU9DVEwgdG8gY2hlY2sgaWYgYSBoYW5kbGUgaXMgYXV0aGVudGljYXRl ZCBvciBub3QuIElmIEknbSAKPiBub3QgY29tcGxldGVseSBtaXN0YWtlbiB0aGUgcmFkdiBjb2Rl IGNvdWxkIGFjdHVhbGx5IGJlIGNvcHkmcGFzdGVkIGZyb20gCj4gdGhlcmUuCj4gCj4gQWRkaXRp b25hbCB0byB0aGF0IHdlIG1pZ2h0IHJ1biBpbnRvIHByb2JsZW1zIHdpdGggdGhlIGxpYmRybSB1 bml0IAo+IHRlc3RzLCBidXQgdGhvc2UgcHJvYmFibHkgZGlkbid0IGJyZWFrIG9idmlvdXNseSBi ZWNhdXNlIHRoZXkgYXJlIGFsbW9zdCAKPiBhbGwgdGhlIHRpbWUgcnVuIGFzIHJvb3QuCgpJIGxv b2tlZCBhdCB0aGUgdmVyeSBmaXJzdCB2ZXJzaW9uIG9mIGFtZGdwdV9kZXZpY2VfaW5pdGlhbGl6 ZS4gVGhhdCBzdGlsbApkb2VzIHNvbWUgb3RoZXIgaW9jdGwgY2FsbHMgYmVmb3JlIHF1ZXJ5aW5n IEFNREdQVV9JTkZPX0FDQ0VMX1dPUktJTkcuIFNvCnNob3VsZCB3b3JrIGV2ZW4gb24gdGhlIHZl cnkgZmlyc3QgYW1kZ3B1IGJhc2VkIHVzZXJzcGFjZSByZWxlYXNlLgoKSSBhbHNvIHF1aWNrbHkg Y2hlY2tlZCBmb3IgdGhlc2UgdW5pdCB0ZXN0cywgYW5kIGF0IGxlYXN0IHRoZSBvbmVzIGluCmxp YmRybSBkb24ndCBoYXZlIGEgY2FsbCB0byBBTURHUFVfSU5GT19BQ0NFTF9XT1JLSU5HIGRpcmVj dGx5IGFmdGVyCm9wZW5pbmcgdGhlIGZpbGUuIElmIHlvdSB3YW50IEkgY2FuIGFsc28gY3Jhd2wg dGhyb3VnaCByb2NtLCBhbWR2bGsgYW5kCmRkeCBzb3VyY2VzLgoKPiA+IE5vdGUgdGhhdCB0aGUg Y2FwYWJpbGl0eSBjaGVja3MgYXJlIGZvciBhbGwgaW9jdGwsIGluY2x1ZGluZyBkcml2ZXIKPiA+ IHByaXZhdGUgb25lcywgaS5lLiByZW5kZXJpbmcgd2lsbCBKdXN0IFdvcmsuIEkgdGhpbmsgaXQg bWFrZXMgc2Vuc2UgdG8KPiA+IGhhdmUgdGhhdC4KPiA+Cj4gPiBJIGd1ZXNzIHRoZXJlIG1pZ2h0 IGJlIDEwMCUgb3ZlcmxhcCBiZXR3ZWVuIERSTV9BVVRIIGFuZAo+ID4gRFJNX1JFTkRFUl9BTExP VyBpbiBpb2N0bCBmbGFncyBub3csIGJ1dCBmaXhpbmcgdGhhdCB3b3VsZCBtZWFuCj4gPiBhdWRp dGluZyBhbGwgdGhlIGRyaXZlciBpb2N0bCB0YWJsZXMuIEkgZ3Vlc3Mgd2UgY291bGQgYWRkIHRo YXQgYXMgYQo+ID4gdG9kby5yc3QgaXRlbS4gSXQgd291bGQgbWFrZSBzZW5zZSB0aGF0IGVpdGhl ciB0aGUgZHJpdmVyIGlzIGlzb2xhdGluZwo+ID4gY2xpZW50cyBzdWZmaWNpZW50bHkgdG8gbm90 IG5lZWQgYXV0aGVudGljYXRlZCBjbGllbnRzIG9ubHksIG9yIGFsbG93Cj4gPiB0aGVtIGFsbC4K PiA+Cj4gPiBJIGd1ZXNzIHdlIGNvdWxkIGxhbWVudCB3aHkgcmVuZGVybm9kZXMgYXJlIHN0aWxs IG5vdCB5ZXQgZnVsbHkgcm9sbGVkCj4gPiBvdXQgZXZlcnl3aGVyZSwgZGVzcGl0ZSBhbGwgdGhl c2UgeWVhcnMuIEJ1dCB0aGVuIEkgc3RvcHBlZCBiZWluZwo+ID4gc3VycHJpc2VkIGFib3V0IGVj b3N5c3RlbSBpbmVydGlhLCBhbmQgaW4gdGhlIGVuZCBhIHN0cmljdCBzcGxpdAo+ID4gYmV0d2Vl biBkaXNwbGF5IChkb25lIG9uIHRoZSBwcmltYXJ5KSBhbmQgcmVuZGVyaW5nIChwcmVmZXJyYWJs eSBkb25lCj4gPiBvbiByZW5kZXIgbm9kZXMpIGlzIG5vdCByZXF1aXJlZCBvbiBpbnRlbC9hbWQv bnYsIHNvIG5vdCBtYW55IGNhcmUgdG8KPiA+IG1ha2UgdGhpcyB3b3JrIGJldHRlci4gVGhlIHBh dGNoIGZyb20gRW1pbCBzZWVtZWQgbGlrZSBhIG5lYXQgbGl0dGxlCj4gPiB0cmljayB0byBnZXQg dGhlcmUgZmFzdGVyLCB1bnRpbCB0aGUgcmFkdiBoaWNjdXAuCj4gCj4gV2VsbCB0aGF0IGlzIGEg Y2xlYXIgTkFLIGZvciB0aGF0IGFwcHJvYWNoLgo+IAo+IElmIHlvdSBoYXZlIHByb2JsZW1zIHdp dGggbGlidmEgKHdoaWNoIGFyZSBkZXNpZ24gcHJvYmxlbXMgaW4gbGlidmEgYW5kIAo+IG5vdCBr ZXJuZWwgcmVsYXRlZCBhdCBhbGwpIHRoZW4gcGxlYXNlIHdvcmsgYXJvdW5kIHRoYXQgYnkgcmVt b3ZpbmcgCj4gRFJNX0FVVEggZnJvbSB0aGUgYWZmZWN0ZWQgSU9DVExzIGFuZCBub3QgYnkgbWVz c2luZyB1cCBnZW5lcmFsIAo+IGF1dGhlbnRpY2F0aW9uIGNvZGUuCgpUaGF0J3Mgd2hhdCB3ZSd2 ZSBkb25lIGRlZmFjdG8sIGV4Y2VwdCB3ZSd2ZSBkb25lIGl0IGZvciBhbGwgZHJpdmVycy4gQXMK bWVudGlvbmVkIGFib3ZlLCBvcHRpb24gQyB3b3VsZCBiZSB0byBkaXNhYmxlIHRoYXQgZm9yIGFt ZGdwdS4gV2hpY2ggc2VlbXMKc2lsbHksIGdpdmVuIHRoYXQgdGhlIHdvcmthcm91bmQgaGFjayBp cyBqdXN0IDMgbGluZXMuCgpJIGFsc28gdGhpbmsgdGhhdCB0aGUgZ29hbCBvZiB0aGUgb3JpZ2lu YWwgcGF0Y2ggaXMgcHJldHR5IHNvdW5kIGFuZApvdmVyYWxsIHdlbGwgbW90aXZhdGVkLCBnaXZl biB0aGUgcmVhbGl0eSB0aGF0IHJlbmRlcm5vZGVzIGFyZW4ndCBzdXBlcgpwb3B1bGFyIHVuZm9y dHVuYXRlbHkuIEFsc28sIGZyb20gYW4gYWNjZXNzIHBlcm1pc3Npb24gcG92IGl0J3MgdGhlIHJp Z2h0CnRoaW5nIHRvIGRvIHJlYWxseS4KCj4gV2VsbCwgd2hhdCB5b3UgZ3V5cyBkaWQgaGVyZSBp cyBhIHNlcmlvdXMgbm8tZ28uCgpOb3QgcmVhbGx5IHVuZGVyc3RhbmRpbmcgeW91ciByZWFzb25z IGZvciBhbiB1bmNvbmRpdGlvbmFsIG5hayBvbiBhbGwgdGhpcwpzdGlsbC4KLURhbmllbAotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs