Received: from eggs.gnu.org ([209.51.188.92]:40869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGjGB-0000F9-Bu for qemu-devel@nongnu.org; Wed, 17 Apr 2019 08:01:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGjGA-0008SS-DJ for qemu-devel@nongnu.org; Wed, 17 Apr 2019 08:01:51 -0400 Received: from 3.mo1.mail-out.ovh.net ([46.105.60.232]:45471) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGjGA-0008MP-1P for qemu-devel@nongnu.org; Wed, 17 Apr 2019 08:01:50 -0400 Received: from player762.ha.ovh.net (unknown [10.109.146.211]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id A1EEA16AC09 for ; Wed, 17 Apr 2019 14:01:38 +0200 (CEST) Date: Wed, 17 Apr 2019 14:01:29 +0200 From: Greg Kurz Message-ID: <20190417140129.18980f0e@bahia.lan> In-Reply-To: <1555498879.055yucy998.astroid@bobo.none> References: <20190416045552.24573-1-npiggin@gmail.com> <20190417015934.GH32705@umbus.fritz.box> <1555498879.055yucy998.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] spapr: add splpar hcalls H_PROD, H_CONFER List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nicholas Piggin Cc: David Gibson , qemu-ppc@nongnu.org, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , qemu-devel@nongnu.org On Wed, 17 Apr 2019 21:20:00 +1000 Nicholas Piggin wrote: > [...] > >> @@ -1860,6 +1928,9 @@ static void hypercall_register_types(void) > >> /* hcall-splpar */ > >> spapr_register_hypercall(H_REGISTER_VPA, h_register_vpa); > >> spapr_register_hypercall(H_CEDE, h_cede); > >> + spapr_register_hypercall(H_CONFER, h_confer); > >> + spapr_register_hypercall(H_PROD, h_prod); > >> + > >> spapr_register_hypercall(H_SIGNAL_SYS_RESET, h_signal_sys_reset); > > > > You're no longer enabling the KVM CONFER and PROD hypercalls. Are > > they enabled by default, or is that an intentional change? > AFAICT they seem to be enabled by default in HV KVM. > Oh, it was not intentional, I must not understand how this works. Why > is this no longer enabling the those hcalls? > Since linux commit 699a0ea0823d ("KVM: PPC: Book3S: Controls for in-kernel sPAPR hypercall handling"), in-kernel hypercalls are disabled by default and must be explicitely enabled by userspace. QEMU does that for some hypercalls already (search kvmppc_enable_set_mode_hcall() in QEMU for an example). Since H_CONFER and H_PROD are listed in default_hcall_list[] in book3s_hv.c, no need for QEMU to enable them in KVM. Not sure about David's "no longer" wording though. > Thanks, > Nick > > Cheers, -- Greg