Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6E1C282DA for ; Wed, 17 Apr 2019 21:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E858217FA for ; Wed, 17 Apr 2019 21:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="fuq3V4Sw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730239AbfDQV7j (ORCPT ); Wed, 17 Apr 2019 17:59:39 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:45998 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbfDQV7g (ORCPT ); Wed, 17 Apr 2019 17:59:36 -0400 Received: by mail-qk1-f196.google.com with SMTP id z76so6055qkb.12 for ; Wed, 17 Apr 2019 14:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=dbe9PpGAWAPkfGXDuSr87tJkk4ndWbS7NPNvmWfJqYg=; b=fuq3V4SwxRN6kJRdV9wpXCK9xJkBl0p7RBgkgChuuZPJu2kROrl+NzjXqfUmeTKzWp aI/6l8yKIBjgc9pn7ddTEjXdrBh8RPp17p9VjugPCQ0jEXm95t3tnWK0XJa12o4qYtzK PFuLgS31PEV4/UToLwITHdG428UPbjLxjL2YNHGq/aviUu9GPvmlA/HgwQMskyZK657h WB0ALlFJFom2GenDkvrGjJ4fTnMomPB0fuj/pQxLutNGo4hJatnExVWmvDJrJhIffKZM ezzs8hOJo0OKmAJE07I1BLw9wyLiqE/ZhqOBdCPydZbuMNzRFxtqnacLOAbua8VbJXIK 0rLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=dbe9PpGAWAPkfGXDuSr87tJkk4ndWbS7NPNvmWfJqYg=; b=ZjqaHCpAjTmdl7EF8RNJONP4dFMf5bLZRBk9jYJCE//vEHKpVXS5w69eoddkz74ly4 2bgq5d8nW3z7UFJiQZOvBhklSjIQzP+DoMaczLxtoUvifp8bXbHCZJdEvzAC+VYTwGEu VMgsvSxmZHPfCAH8XJ3EcGKs+qzVZL3TQ+aznDKiL8SvEhu/rDNnUWGInsWFA1ZJk+2W mrW49V7TuAa2xX649KoTlzGPgXLw9q9QdG98YSOPVufmZfN3KfR3hb1NZMQ7B+SlqAfG s7Yp63Z8Zbz1jrf4/RhCBm0FqBps1i/7LETl6Yf+QnU36czVQOt4cLTpr/FdrtC4CmG1 HRKw== X-Gm-Message-State: APjAAAWZ7Pz4O8w4+uYEuSYvPj05440kyYyASgxV4l14KFWuithX7mHF 5aIVENPMUvrFvxEsQf5hupbokQ== X-Google-Smtp-Source: APXvYqxIBAYu5Iq7QH5tNdPUBb/zlAOdgs3QrdFjLVpBd1x5JCccWZ6SCQwFEoq9+o2BAPNKfKZmAg== X-Received: by 2002:a05:620a:1429:: with SMTP id k9mr67769652qkj.238.1555538375932; Wed, 17 Apr 2019 14:59:35 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id u3sm16128qkc.21.2019.04.17.14.59.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 14:59:35 -0700 (PDT) Date: Wed, 17 Apr 2019 14:59:32 -0700 From: Jakub Kicinski To: Jonathan Lemon Cc: , , , Subject: Re: [PATCH net-next] xsk: Have xsk_umem_peek_addr_rq() return chunk-aligned handles. Message-ID: <20190417145932.4d696a29@cakuba.netronome.com> In-Reply-To: <20190417195255.2800907-1-jonathan.lemon@gmail.com> References: <20190417195255.2800907-1-jonathan.lemon@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Apr 2019 12:52:55 -0700, Jonathan Lemon wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c > index 61d75a7b3ce2..2f0b5fd1ee97 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c > @@ -309,7 +309,7 @@ int mlx5e_xsk_page_alloc_umem(struct mlx5e_rq *rq, > > static inline void mlx5e_xsk_recycle_frame(struct mlx5e_rq *rq, u64 handle) > { > - xsk_umem_fq_reuse(rq->umem, handle & rq->umem->chunk_mask); > + xsk_umem_fq_reuse(rq->umem, handle); > } > The mlx5 af_xdp stuff you're using is not upstream :)