Received: from eggs.gnu.org ([209.51.188.92]:60209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGptO-0007dy-Hx for qemu-devel@nongnu.org; Wed, 17 Apr 2019 15:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGptN-0003Y8-Eq for qemu-devel@nongnu.org; Wed, 17 Apr 2019 15:06:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGptN-0003Wr-2l for qemu-devel@nongnu.org; Wed, 17 Apr 2019 15:06:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B46453199363 for ; Wed, 17 Apr 2019 19:06:43 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82A805D9D6 for ; Wed, 17 Apr 2019 19:06:43 +0000 (UTC) From: Markus Armbruster Date: Wed, 17 Apr 2019 21:06:26 +0200 Message-Id: <20190417190641.26814-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 00/15] Clean up use of error_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This series cleans up two kinds of error_printf() misuse: * Errors and warnings should be reported with error_report() and warn_report(). * Help output should be go to stdout, not stderr. This is obviously for 4.1. If nobody objects, I'll take the whole series through my tree. Based-on: <20190131164614.19209-1-cfergeau@redhat.com> v3: * PATCH 03: Replaced by new PATCH 14 [Paolo] * PATCH 10: Trivial conflict with "[PATCH v7 0/2] log: Make glib logging go through QEMU" resolved. v2: * PATCH 02: Commit message tweaked, indentation fixed [Eric] * PATCH 10: Indentation fixed [Marcel] * PATCH 11: Use-after-free fixed [Patchew] * PATCH 12: test-util-sockets.c updated along with stubs/monitor.c * PATCH 14: Commit message typo [Eric] Markus Armbruster (15): qemu-img: Use error_vreport() in error_exit() block/ssh: Do not report read/write/flush errors to the user loader-fit: Wean off error_printf() mips/boston: Report errors with error_report(), not error_printf() pci: Report fatal errors with error_report(), not error_printf() hpet: Report warnings with warn_report(), not error_printf() vfio: Report warnings with warn_report(), not error_printf() s390x/kvm: Report warnings with warn_report(), not error_printf() vl: Make -machine $TYPE,help and -accel help print to stdout monitor error: Make printf()-like functions return a value qemu-print: New qemu_printf(), qemu_vprintf() etc. blockdev: Make -drive format=3Dhelp print to stdout char: Make -chardev help print to stdout char-pty: Print "char device redirected" message to stdout monitor: Simplify how -device/device_add print help MAINTAINERS | 2 ++ block/ssh.c | 38 +++++++------------- block/trace-events | 3 ++ blockdev.c | 9 ++--- chardev/char-pty.c | 5 +-- chardev/char.c | 3 +- hw/core/loader-fit.c | 62 +++++++++++++++++++-------------- hw/mips/boston.c | 6 ++-- hw/pci/pci.c | 2 +- hw/timer/hpet.c | 2 +- hw/vfio/pci.c | 19 ++++++---- include/monitor/monitor.h | 7 ++-- include/qemu/error-report.h | 8 ++--- include/qemu/qemu-print.h | 19 ++++++++++ monitor.c | 69 ++++++++++++++++++------------------- qdev-monitor.c | 36 ++++++++----------- qemu-img.c | 6 ++-- stubs/error-printf.c | 13 ++++--- stubs/monitor.c | 5 +++ target/s390x/kvm.c | 2 +- tests/test-util-sockets.c | 1 + util/Makefile.objs | 1 + util/qemu-error.c | 12 ++++--- util/qemu-print.c | 42 ++++++++++++++++++++++ vl.c | 10 +++--- 25 files changed, 227 insertions(+), 155 deletions(-) create mode 100644 include/qemu/qemu-print.h create mode 100644 util/qemu-print.c --=20 2.17.2