Received: from eggs.gnu.org ([209.51.188.92]:43397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGqdK-0000YW-IJ for qemu-devel@nongnu.org; Wed, 17 Apr 2019 15:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGqdJ-00070V-OH for qemu-devel@nongnu.org; Wed, 17 Apr 2019 15:54:14 -0400 From: Maxim Levitsky Date: Wed, 17 Apr 2019 22:53:51 +0300 Message-Id: <20190417195355.16123-2-mlevitsk@redhat.com> In-Reply-To: <20190417195355.16123-1-mlevitsk@redhat.com> References: <20190417195355.16123-1-mlevitsk@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/5] block/nvme: don't flip CQ phase bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Maxim Levitsky , Fam Zheng , Kevin Wolf , Max Reitz , qemu-devel@nongnu.org Phase bits are only set by the hardware to indicate new completions and not by the device driver. Signed-off-by: Maxim Levitsky --- block/nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 0684bbd077..2d208000df 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -340,8 +340,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q) qemu_mutex_lock(&q->lock); c->cid = cpu_to_le16(0); q->inflight--; - /* Flip Phase Tag bit. */ - c->status = cpu_to_le16(le16_to_cpu(c->status) ^ 0x1); progress = true; } if (progress) { -- 2.17.2